| Message ID | 20241016065700.1090-9-quic_kangyang@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Jeff Johnson |
| Headers | show |
| Series | wifi: ath12k: some fixes and clean up for monitor mode | expand |
Kang Yang <quic_kangyang@quicinc.com> writes: > ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor > vdev. But this is not needed for monitor vdev. > > So delete them. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 > > Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> Does this fix any known issues? Or is just cleanup?
On 10/21/2024 4:46 PM, Kalle Valo wrote: > Kang Yang <quic_kangyang@quicinc.com> writes: > >> ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor >> vdev. But this is not needed for monitor vdev. >> >> So delete them. >> >> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >> >> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> > > Does this fix any known issues? Or is just cleanup? Clean up >
Kang Yang <quic_kangyang@quicinc.com> writes: > On 10/21/2024 4:46 PM, Kalle Valo wrote: >> Kang Yang <quic_kangyang@quicinc.com> writes: >> >>> ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor >>> vdev. But this is not needed for monitor vdev. >>> >>> So delete them. >>> >>> Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 >>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 >>> >>> Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> >> Does this fix any known issues? Or is just cleanup? > > Clean up Ok, please always mention this in the commit message. In essence you need to answer to the question 'why are we doing this?'.
diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index a145cb217cbd..e4412f7a35b4 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -1068,7 +1068,6 @@ static int ath12k_mac_monitor_vdev_create(struct ath12k *ar) struct ath12k_wmi_vdev_create_arg arg = {}; int bit, ret; u8 tmp_addr[6]; - u16 nss; lockdep_assert_wiphy(ath12k_ar_to_hw(ar)->wiphy); @@ -1108,19 +1107,6 @@ static int ath12k_mac_monitor_vdev_create(struct ath12k *ar) return ret; } - nss = hweight32(ar->cfg_tx_chainmask) ? : 1; - ret = ath12k_wmi_vdev_set_param_cmd(ar, ar->monitor_vdev_id, - WMI_VDEV_PARAM_NSS, nss); - if (ret) { - ath12k_warn(ar->ab, "failed to set vdev %d chainmask 0x%x, nss %d :%d\n", - ar->monitor_vdev_id, ar->cfg_tx_chainmask, nss, ret); - return ret; - } - - ret = ath12k_mac_txpower_recalc(ar); - if (ret) - return ret; - ar->allocated_vdev_map |= 1LL << ar->monitor_vdev_id; ar->ab->free_vdev_map &= ~(1LL << ar->monitor_vdev_id); ar->num_created_vdevs++;
ath12k_mac_monitor_vdev_create() will set NSS and TX power for monitor vdev. But this is not needed for monitor vdev. So delete them. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1 Signed-off-by: Kang Yang <quic_kangyang@quicinc.com> --- drivers/net/wireless/ath/ath12k/mac.c | 14 -------------- 1 file changed, 14 deletions(-)