| Message ID | 20250313-mhi_bw_up-v2-9-869ca32170bf@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | bus: mhi: host: Add support for mhi bus bw | expand |
On Thu, Mar 13, 2025 at 05:10:16PM +0530, Krishna Chaitanya Chundru wrote: > Add a exported function to convert lnkctl2speed to enum pci_bus_speed, > so that other kernel drivers can use it. > > Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> > --- > drivers/pci/pci.c | 12 ++++++++++++ > include/linux/pci.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > index 869d204a70a3..75505437a9c9 100644 > --- a/drivers/pci/pci.c > +++ b/drivers/pci/pci.c > @@ -6011,6 +6011,18 @@ int pcie_link_speed_mbps(struct pci_dev *pdev) > } > EXPORT_SYMBOL(pcie_link_speed_mbps); > > +/** > + * pci_lnkctl2_bus_speed - converts lnkctl2 speed to pci_bus_speed I try to use imperative mood ("convert lnkctl2") to match commit log style. > + * @speed: LNKCAP2 SLS value > + * > + * Returns pci_bus_speed Not sure how strict kernel-doc is about this, but I've been told it wants "Return:" with a colon here: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/doc-guide/kernel-doc.rst?id=v6.13#n142
On 3/13/2025 10:16 AM, Bjorn Helgaas wrote: > On Thu, Mar 13, 2025 at 05:10:16PM +0530, Krishna Chaitanya Chundru wrote: >> + * @speed: LNKCAP2 SLS value >> + * >> + * Returns pci_bus_speed > > Not sure how strict kernel-doc is about this, but I've been told > it wants "Return:" with a colon here: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/doc-guide/kernel-doc.rst?id=v6.13#n142 Yes, patchwork is flagging kernel-doc issues in this series. However, there are numerous pre-existing kdoc issues in the MHI and PCI files being modified in this series. Just look at the patches with errors being flagged in patchwork (including build errors with 06/10): https://patchwork.kernel.org/project/linux-wireless/list/?series=943497
diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index 869d204a70a3..75505437a9c9 100644 --- a/drivers/pci/pci.c +++ b/drivers/pci/pci.c @@ -6011,6 +6011,18 @@ int pcie_link_speed_mbps(struct pci_dev *pdev) } EXPORT_SYMBOL(pcie_link_speed_mbps); +/** + * pci_lnkctl2_bus_speed - converts lnkctl2 speed to pci_bus_speed + * @speed: LNKCAP2 SLS value + * + * Returns pci_bus_speed + */ +enum pci_bus_speed pci_lnkctl2_bus_speed(int speed) +{ + return pcie_link_speed[speed]; +} +EXPORT_SYMBOL(pci_lnkctl2_bus_speed); + /** * pcie_bandwidth_available - determine minimum link settings of a PCIe * device and its bandwidth limitation diff --git a/include/linux/pci.h b/include/linux/pci.h index 9ae199c1e698..b84473f228c8 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1653,6 +1653,7 @@ unsigned char pci_bus_max_busnr(struct pci_bus *bus); void pci_setup_bridge(struct pci_bus *bus); resource_size_t pcibios_window_alignment(struct pci_bus *bus, unsigned long type); +enum pci_bus_speed pci_lnkctl2_bus_speed(int speed); #define PCI_VGA_STATE_CHANGE_BRIDGE (1 << 0) #define PCI_VGA_STATE_CHANGE_DECODES (1 << 1)
Add a exported function to convert lnkctl2speed to enum pci_bus_speed, so that other kernel drivers can use it. Signed-off-by: Krishna Chaitanya Chundru <krishna.chundru@oss.qualcomm.com> --- drivers/pci/pci.c | 12 ++++++++++++ include/linux/pci.h | 1 + 2 files changed, 13 insertions(+)