| Message ID | 20250321-ath12k-dont-put-chanctx-in-arvif-v1-1-c8e93061952b@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Johnson |
| Headers | show |
| Series | [ath-next] wifi: ath12k: don't put ieee80211_chanctx_conf struct in ath12k_link_vif | expand |
On 3/21/2025 7:15 AM, Baochen Qiang wrote: > ieee80211_chanctx_conf struct is not put at the end of ath12k_link_vif. > Note ieee80211_chanctx_conf has flexible array member inside it, causing > below warning with GCC-14: > > drivers/net/wireless/ath/ath12k/core.h:298:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Although there is no issue for now since the array is not getting used, > this should be fixed to avoid any potential data corruption issue in the > future. > > Remove this struct from ath12k_link_vif, fetch it from ieee80211_bss_conf > instead when needed. > > This change only applies to WCN7850, and should has no impact on other > chipsets. > > This is an alternative to the solution proposed in [1]. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Reported-by: Gustavo A. R. Silva <gustavoars@kernel.org> > Link: https://msgid.link/Z8-Snz86Xfwdlyd7@kspp # [1] > Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
On 3/20/2025 6:45 PM, Baochen Qiang wrote: > ieee80211_chanctx_conf struct is not put at the end of ath12k_link_vif. > Note ieee80211_chanctx_conf has flexible array member inside it, causing > below warning with GCC-14: > > drivers/net/wireless/ath/ath12k/core.h:298:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Although there is no issue for now since the array is not getting used, > this should be fixed to avoid any potential data corruption issue in the > future. > > Remove this struct from ath12k_link_vif, fetch it from ieee80211_bss_conf > instead when needed. > > This change only applies to WCN7850, and should has no impact on other > chipsets. > > This is an alternative to the solution proposed in [1]. > > Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 > > Reported-by: Gustavo A. R. Silva <gustavoars@kernel.org> > Link: https://msgid.link/Z8-Snz86Xfwdlyd7@kspp # [1] I'll change this to Closes: in pending to address checkpatch: WARNING:BAD_REPORTED_BY_LINK: Reported-by: should be immediately followed by Closes: with a URL to the report
On Fri, 21 Mar 2025 09:45:53 +0800, Baochen Qiang wrote: > ieee80211_chanctx_conf struct is not put at the end of ath12k_link_vif. > Note ieee80211_chanctx_conf has flexible array member inside it, causing > below warning with GCC-14: > > drivers/net/wireless/ath/ath12k/core.h:298:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] > > Although there is no issue for now since the array is not getting used, > this should be fixed to avoid any potential data corruption issue in the > future. > > [...] Applied, thanks! [1/1] wifi: ath12k: don't put ieee80211_chanctx_conf struct in ath12k_link_vif commit: ce0779378c62758a0c503bf85e643c6d8f343703 Best regards,
diff --git a/drivers/net/wireless/ath/ath12k/core.h b/drivers/net/wireless/ath/ath12k/core.h index bed996919f040645fd8b474d9709539758a34150..4675648c7bcb1f282db7935c92bb6a46821e550a 100644 --- a/drivers/net/wireless/ath/ath12k/core.h +++ b/drivers/net/wireless/ath/ath12k/core.h @@ -295,7 +295,6 @@ struct ath12k_link_vif { int txpower; bool rsnie_present; bool wpaie_present; - struct ieee80211_chanctx_conf chanctx; u8 vdev_stats_id; u32 punct_bitmap; u8 link_id; diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c index 9fda97667d4e3468f28194bf55cc194fe123533c..842eda56c8b152b3303c83b43fbef400442c59fc 100644 --- a/drivers/net/wireless/ath/ath12k/mac.c +++ b/drivers/net/wireless/ath/ath12k/mac.c @@ -9550,16 +9550,26 @@ static int ath12k_start_vdev_delay(struct ath12k *ar, struct ath12k_base *ab = ar->ab; struct ath12k_vif *ahvif = arvif->ahvif; struct ieee80211_vif *vif = ath12k_ahvif_to_vif(arvif->ahvif); + struct ieee80211_chanctx_conf *chanctx; + struct ieee80211_bss_conf *link_conf; int ret; if (WARN_ON(arvif->is_started)) return -EBUSY; - ret = ath12k_mac_vdev_start(arvif, &arvif->chanctx); + link_conf = ath12k_mac_get_link_bss_conf(arvif); + if (!link_conf) { + ath12k_warn(ab, "failed to get link conf for vdev %u\n", arvif->vdev_id); + return -EINVAL; + } + + chanctx = wiphy_dereference(ath12k_ar_to_hw(arvif->ar)->wiphy, + link_conf->chanctx_conf); + ret = ath12k_mac_vdev_start(arvif, chanctx); if (ret) { ath12k_warn(ab, "failed to start vdev %i addr %pM on freq %d: %d\n", arvif->vdev_id, vif->addr, - arvif->chanctx.def.chan->center_freq, ret); + chanctx->def.chan->center_freq, ret); return ret; } @@ -9622,7 +9632,6 @@ ath12k_mac_op_assign_vif_chanctx(struct ieee80211_hw *hw, ahvif->vdev_type != WMI_VDEV_TYPE_AP && ahvif->vdev_type != WMI_VDEV_TYPE_MONITOR && !ath12k_peer_exist_by_vdev_id(ab, arvif->vdev_id)) { - memcpy(&arvif->chanctx, ctx, sizeof(*ctx)); ret = 0; goto out; }
ieee80211_chanctx_conf struct is not put at the end of ath12k_link_vif. Note ieee80211_chanctx_conf has flexible array member inside it, causing below warning with GCC-14: drivers/net/wireless/ath/ath12k/core.h:298:39: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end] Although there is no issue for now since the array is not getting used, this should be fixed to avoid any potential data corruption issue in the future. Remove this struct from ath12k_link_vif, fetch it from ieee80211_bss_conf instead when needed. This change only applies to WCN7850, and should has no impact on other chipsets. This is an alternative to the solution proposed in [1]. Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3 Reported-by: Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://msgid.link/Z8-Snz86Xfwdlyd7@kspp # [1] Signed-off-by: Baochen Qiang <quic_bqiang@quicinc.com> --- drivers/net/wireless/ath/ath12k/core.h | 1 - drivers/net/wireless/ath/ath12k/mac.c | 15 ++++++++++++--- 2 files changed, 12 insertions(+), 4 deletions(-) --- base-commit: b6f473c96421b8b451a8df8ccb620bcd71d4b3f4 change-id: 20250321-ath12k-dont-put-chanctx-in-arvif-5004547c6201 Best regards,