| Message ID | 20250409152341.944628-1-ramya.gnanasekar@oss.qualcomm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Jeff Johnson |
| Headers | show |
| Series | [ath-next] wifi: ath12k: Fix WMI tag for EHT rate in peer assoc | expand |
On Wed, 09 Apr 2025 20:53:41 +0530, Ramya Gnanasekar wrote: > Incorrect WMI tag is used for EHT rate update from host to firmware > while encoding peer assoc WMI. > > Correct the WMI tag used for EHT rate update from WMI_TAG_HE_RATE_SET > to the proper tag. This ensures firmware does not mistakenly update HE rate during parsing. > > Found during code review. Compile tested only. > > [...] Applied, thanks! [1/1] wifi: ath12k: Fix WMI tag for EHT rate in peer assoc commit: 1a0e65750b55d2cf5de4a9bf7d6d55718784bdb7 Best regards,
diff --git a/drivers/net/wireless/ath/ath12k/wmi.c b/drivers/net/wireless/ath/ath12k/wmi.c index ad29c4c99dc7..664d03dcc041 100644 --- a/drivers/net/wireless/ath/ath12k/wmi.c +++ b/drivers/net/wireless/ath/ath12k/wmi.c @@ -2330,7 +2330,7 @@ int ath12k_wmi_send_peer_assoc_cmd(struct ath12k *ar, for (i = 0; i < arg->peer_eht_mcs_count; i++) { eht_mcs = ptr; - eht_mcs->tlv_header = ath12k_wmi_tlv_cmd_hdr(WMI_TAG_HE_RATE_SET, + eht_mcs->tlv_header = ath12k_wmi_tlv_cmd_hdr(WMI_TAG_EHT_RATE_SET, sizeof(*eht_mcs)); eht_mcs->rx_mcs_set = cpu_to_le32(arg->peer_eht_rx_mcs_set[i]);
Incorrect WMI tag is used for EHT rate update from host to firmware while encoding peer assoc WMI. Correct the WMI tag used for EHT rate update from WMI_TAG_HE_RATE_SET to the proper tag. This ensures firmware does not mistakenly update HE rate during parsing. Found during code review. Compile tested only. Fixes: 5b70ec6036c1 ("wifi: ath12k: add WMI support for EHT peer") Signed-off-by: Ramya Gnanasekar <ramya.gnanasekar@oss.qualcomm.com> --- drivers/net/wireless/ath/ath12k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: 58b976e4f4b4d727eea27c0e40830853ef7ecf0e