diff mbox series

wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration

Message ID 30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com (mailing list archive)
State Accepted
Commit e963a19c64ac0d2f8785d36a27391abd91ac77aa
Delegated to: Kalle Valo
Headers show
Series wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration | expand

Commit Message

Bitterblue Smith Sept. 2, 2022, 11:48 a.m. UTC
Found by comparing with the vendor driver. Currently this affects
only the RTL8192EU, which is the only gen2 chip with 2 TX paths
supported by this driver. It's unclear what kind of effect the
mistake had in practice, since I don't have any RTL8192EU devices
to test it.

Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts")
Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Kalle Valo Sept. 12, 2022, 11:57 a.m. UTC | #1
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Found by comparing with the vendor driver. Currently this affects
> only the RTL8192EU, which is the only gen2 chip with 2 TX paths
> supported by this driver. It's unclear what kind of effect the
> mistake had in practice, since I don't have any RTL8192EU devices
> to test it.
> 
> Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts")
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Patch applied to wireless-next.git, thanks.

e963a19c64ac wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index 422b396a1af6..b4e09da1c683 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -2959,12 +2959,12 @@  bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv,
 		}
 
 		if (!(simubitmap & 0x30) && priv->tx_paths > 1) {
-			/* path B RX OK */
+			/* path B TX OK */
 			for (i = 4; i < 6; i++)
 				result[3][i] = result[c1][i];
 		}
 
-		if (!(simubitmap & 0x30) && priv->tx_paths > 1) {
+		if (!(simubitmap & 0xc0) && priv->tx_paths > 1) {
 			/* path B RX OK */
 			for (i = 6; i < 8; i++)
 				result[3][i] = result[c1][i];