diff mbox

[v5] staging: rtl8723bs: remove re-positioned call to kfree in os_dep/ioctl_cfg80211.c

Message ID 40c81df4-d17f-c374-e5a8-c5b8edd914b5@gmail.com (mailing list archive)
State Not Applicable
Delegated to: Kalle Valo
Headers show

Commit Message

Ian W MORRISON May 7, 2017, 10:04 a.m. UTC 
A kernel cloned from 
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and 
built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m) 
fails when booting on an Intel Atom device with the RTL8723BS wifi 
chipset due to an error in 
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.

The kernel when booted with Ubuntu 17.04 results in an unusable system 
however with the following patch booting is successful and the system 
is usable. The patch and kernel builds have been tested against on an 
Intel Compute Stick (STCK1A32WFC model).

This version of the patch (version 5) has tabs rather than spaces, no 
wrap around, a changelog and a sign-off email. 

Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Ian W Morrison <ianwmorrison@gmail.com>
---
 drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko May 8, 2017, 2:42 p.m. UTC | #1 
On Sun, May 7, 2017 at 1:04 PM, Ian W MORRISON <ianwmorrison@gmail.com> wrote:
> A kernel cloned from
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git and
> built with the latest RTL8723BS driver included (CONFIG_RTL8723BS=m)
> fails when booting on an Intel Atom device with the RTL8723BS wifi
> chipset due to an error in
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c.
>
> The kernel when booted with Ubuntu 17.04 results in an unusable system
> however with the following patch booting is successful and the system
> is usable. The patch and kernel builds have been tested against on an
> Intel Compute Stick (STCK1A32WFC model).
>
> This version of the patch (version 5) has tabs rather than spaces, no
> wrap around, a changelog and a sign-off email.

What are you trying to achieve by posting this patch over and over so often?

Version 5 look pretty good to me. Just stop posting it again and wait
when Greg takes it.

FWIW (version 5!):
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
diff mbox

Patch

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index f17f4fb..2ee9df5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
@@ -3527,7 +3527,6 @@  int rtw_wdev_alloc(struct adapter *padapter, struct device *dev)
 		pwdev_priv->power_mgmt = true;
 	else
 		pwdev_priv->power_mgmt = false;
-	kfree((u8 *)wdev);
 
 	return ret;