| Message ID | 421a4b4673da8fb610850f674d0994ad46bc1ed6.1666038048.git.gustavoars@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Avoid clashing function prototypes | expand |
On Mon, Oct 17, 2022 at 03:34:48PM -0500, Gustavo A. R. Silva wrote: > Previous patches have removed the rest of the casts to iw_handler in > ipw_wx_handlers array definition, and with that multiple > -Wcast-function-type-strict warnings have been fixed. > > Remove the one cast to iw_handler remaining, which was not removed in > previous patches because there was no -Wcast-function-type-strict warning > associated with it. > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> > /* Rebase the WE IOCTLs to zero for the handler array */ > static iw_handler ipw_wx_handlers[] = { > - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname), > + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname), > IW_HANDLER(SIOCSIWFREQ, ipw_wx_set_freq), > IW_HANDLER(SIOCGIWFREQ, ipw_wx_get_freq), > IW_HANDLER(SIOCSIWMODE, ipw_wx_set_mode), I'd just collapse this into the previous cfg80211_wext patch...
diff --git a/drivers/net/wireless/intel/ipw2x00/ipw2200.c b/drivers/net/wireless/intel/ipw2x00/ipw2200.c index 5b483de18c81..3158f91b18d5 100644 --- a/drivers/net/wireless/intel/ipw2x00/ipw2200.c +++ b/drivers/net/wireless/intel/ipw2x00/ipw2200.c @@ -9870,7 +9870,7 @@ static int ipw_wx_sw_reset(struct net_device *dev, /* Rebase the WE IOCTLs to zero for the handler array */ static iw_handler ipw_wx_handlers[] = { - IW_HANDLER(SIOCGIWNAME, (iw_handler)cfg80211_wext_giwname), + IW_HANDLER(SIOCGIWNAME, cfg80211_wext_giwname), IW_HANDLER(SIOCSIWFREQ, ipw_wx_set_freq), IW_HANDLER(SIOCGIWFREQ, ipw_wx_get_freq), IW_HANDLER(SIOCSIWMODE, ipw_wx_set_mode),
Previous patches have removed the rest of the casts to iw_handler in ipw_wx_handlers array definition, and with that multiple -Wcast-function-type-strict warnings have been fixed. Remove the one cast to iw_handler remaining, which was not removed in previous patches because there was no -Wcast-function-type-strict warning associated with it. Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> --- drivers/net/wireless/intel/ipw2x00/ipw2200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)