diff mbox

[wireless] wireless: Keep phy name consistent across module reloads.

Message ID 4C9D2487.5040202@candelatech.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Ben Greear Sept. 24, 2010, 10:21 p.m. UTC
None
diff mbox

Patch

diff --git a/net/wireless/core.c b/net/wireless/core.c
index 8226ba7..312a44b 100644
--- a/net/wireless/core.c
+++ b/net/wireless/core.c
@@ -319,9 +319,12 @@  static void cfg80211_event_work(struct work_struct *work)

  struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv)
  {
+	static int wiphy_counter;
  	int i;
-	struct cfg80211_registered_device *rdev;
+	struct cfg80211_registered_device *rdev, *rdev2;
  	int alloc_size;
+	char nname[IFNAMSIZ + 1];
+	bool found = false;

  	WARN_ON(ops->add_key && (!ops->del_key || !ops->set_default_key));
  	WARN_ON(ops->auth && (!ops->assoc || !ops->deauth || !ops->disassoc));
@@ -341,26 +344,38 @@  struct wiphy *wiphy_new(const struct cfg80211_ops *ops, int sizeof_priv)

  	mutex_lock(&cfg80211_mutex);

+	rdev->wiphy_idx = wiphy_counter++;
+
+	if (unlikely(!wiphy_idx_valid(rdev->wiphy_idx)))
+		goto too_many_devs;
+
  	/* 64k wiphy devices is enough for anyone! */
  	for (i = 0; i < 0xFFFF; i++) {
-		if (!cfg80211_rdev_by_wiphy_idx(i))
+		found = false;
+		snprintf(nname, sizeof(nname)-1, PHY_NAME "%d", i);
+		nname[sizeof(nname)-1] = 0;
+		list_for_each_entry(rdev2, &cfg80211_rdev_list, list)
+			if (strcmp(nname, dev_name(&rdev2->wiphy.dev)) == 0) {
+				found = true;
+				break;
+			}
+
+		if (!found)
  			break;
  	}
-	if (i == 0xFFFF)
-		i = -1; /* invalid */
-	rdev->wiphy_idx = i;

-	if (unlikely(!wiphy_idx_valid(rdev->wiphy_idx))) {
+	if (unlikely(found)) {
+too_many_devs:
  		mutex_unlock(&cfg80211_mutex);
  		/* ugh, too many devices already! */
  		kfree(rdev);
  		return NULL;
  	}

-	mutex_unlock(&cfg80211_mutex);
-
  	/* give it a proper name */
-	dev_set_name(&rdev->wiphy.dev, PHY_NAME "%d", rdev->wiphy_idx);
+	dev_set_name(&rdev->wiphy.dev, "%s", nname);
+
+	mutex_unlock(&cfg80211_mutex);

  	mutex_init(&rdev->mtx);
  	mutex_init(&rdev->devlist_mtx);