Trial change to rtl8192ce used as AP

Message ID	4FF5F600.9040900@lwfinger.net (mailing list archive)
State	Not Applicable, archived
Headers	show Return-Path: <linux-wireless-owner@vger.kernel.org> Message-ID: <4FF5F600.9040900@lwfinger.net> Date: Thu, 05 Jul 2012 15:16:00 -0500 From: Larry Finger <Larry.Finger@lwfinger.net> User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ivan Ivanich <ivanich@ivanich.org.ua> CC: wireless <linux-wireless@vger.kernel.org> Subject: Trial change to rtl8192ce used as AP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk

Message ID

4FF5F600.9040900@lwfinger.net (mailing list archive)

State

Not Applicable, archived

Headers

Message-ID: <4FF5F600.9040900@lwfinger.net>
Date: Thu, 05 Jul 2012 15:16:00 -0500
From: Larry Finger <Larry.Finger@lwfinger.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
	rv:13.0) Gecko/20120614 Thunderbird/13.0.1
MIME-Version: 1.0
To: Ivan Ivanich <ivanich@ivanich.org.ua>
CC: wireless <linux-wireless@vger.kernel.org>
Subject: Trial change to rtl8192ce used as AP
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-wireless-owner@vger.kernel.org
Precedence: bulk

Commit Message

Larry Finger July 5, 2012, 8:16 p.m. UTC

Ivan,

The following patch is suggested by the code-analysis tool cppcheck as the test 
is always false. As it will not affect STA usage, I have no way to test the 
change. Could you please do so?

Thanks,

Larry



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Ivan Ivanich July 5, 2012, 8:24 p.m. UTC | #1

On ???????, 05-???-2012 15:16:00 Larry Finger wrote:
> Ivan,
> 
> The following patch is suggested by the code-analysis tool cppcheck as the
> test is always false. As it will not affect STA usage, I have no way to
> test the change. Could you please do so?
> 
> Thanks,
> 
> Larry
> 
> 
> Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> ===================================================================
> --- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> +++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> @@ -1097,7 +1097,7 @@ static int _rtl92ce_set_media_status(str
> 
>   	rtl_write_byte(rtlpriv, (MSR), bt_msr);
>   	rtlpriv->cfg->ops->led_control(hw, ledaction);
> -	if ((bt_msr & 0xfc) == MSR_AP)
> +	if ((bt_msr & 0x03) == MSR_AP)
>   		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
>   	else
>   		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);

Yes, compiling now, for some reason it doesn't apply cleanyl so I manualy 
changed this line.
And what exactly I should test?
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Larry Finger July 5, 2012, 8:29 p.m. UTC | #2

On 07/05/2012 03:24 PM, Ivan Ivanich wrote:
> On ???????, 05-???-2012 15:16:00 Larry Finger wrote:
>> Ivan,
>>
>> The following patch is suggested by the code-analysis tool cppcheck as the
>> test is always false. As it will not affect STA usage, I have no way to
>> test the change. Could you please do so?
>>
>> Thanks,
>>
>> Larry
>>
>>
>> Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> ===================================================================
>> --- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> +++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
>> @@ -1097,7 +1097,7 @@ static int _rtl92ce_set_media_status(str
>>
>>    	rtl_write_byte(rtlpriv, (MSR), bt_msr);
>>    	rtlpriv->cfg->ops->led_control(hw, ledaction);
>> -	if ((bt_msr & 0xfc) == MSR_AP)
>> +	if ((bt_msr & 0x03) == MSR_AP)
>>    		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
>>    	else
>>    		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
>
> Yes, compiling now, for some reason it doesn't apply cleanyl so I manualy
> changed this line.
> And what exactly I should test?

Does it affect operation in AP mode? Before this change, the code always wrote 
0x66 to the register. Now it seems that it will write 0 if in AP mode. As I have 
no idea what that register does, I do not know what effect the change will have.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Ivan Ivanich July 5, 2012, 8:48 p.m. UTC | #3

On ???????, 05-???-2012 15:29:45 Larry Finger wrote:
> On 07/05/2012 03:24 PM, Ivan Ivanich wrote:
> > On ???????, 05-???-2012 15:16:00 Larry Finger wrote:
> >> Ivan,
> >> 
> >> The following patch is suggested by the code-analysis tool cppcheck as
> >> the
> >> test is always false. As it will not affect STA usage, I have no way to
> >> test the change. Could you please do so?
> >> 
> >> Thanks,
> >> 
> >> Larry
> >> 
> >> 
> >> Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> >> ===================================================================
> >> --- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> >> +++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
> >> @@ -1097,7 +1097,7 @@ static int _rtl92ce_set_media_status(str
> >> 
> >>    	rtl_write_byte(rtlpriv, (MSR), bt_msr);
> >>    	rtlpriv->cfg->ops->led_control(hw, ledaction);
> >> 
> >> -	if ((bt_msr & 0xfc) == MSR_AP)
> >> +	if ((bt_msr & 0x03) == MSR_AP)
> >> 
> >>    		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
> >>    	
> >>    	else
> >>    	
> >>    		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);
> > 
> > Yes, compiling now, for some reason it doesn't apply cleanyl so I manualy
> > changed this line.
> > And what exactly I should test?
> 
> Does it affect operation in AP mode? Before this change, the code always
> wrote 0x66 to the register. Now it seems that it will write 0 if in AP
> mode. As I have no idea what that register does, I do not know what effect
> the change will have.
> 
> Larry
At the first look all works as before, I will test a few days and then report.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Larry Finger July 5, 2012, 9:10 p.m. UTC | #4

On 07/05/2012 03:48 PM, Ivan Ivanich wrote:

> At the first look all works as before, I will test a few days and then report.

Thanks,

Larry



--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Index: wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
+++ wireless-testing/drivers/net/wireless/rtlwifi/rtl8192ce/hw.c
@@ -1097,7 +1097,7 @@  static int _rtl92ce_set_media_status(str

  	rtl_write_byte(rtlpriv, (MSR), bt_msr);
  	rtlpriv->cfg->ops->led_control(hw, ledaction);
-	if ((bt_msr & 0xfc) == MSR_AP)
+	if ((bt_msr & 0x03) == MSR_AP)
  		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x00);
  	else
  		rtl_write_byte(rtlpriv, REG_BCNTCFG + 1, 0x66);

Trial change to rtl8192ce used as AP

Commit Message

Comments

Patch