diff mbox

[RFC] b43: Fix regression from Bug #14538

Message ID 4b0ae89a.w9I5fcNpeuH/GfsI%Larry.Finger@lwfinger.net (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Larry Finger Nov. 23, 2009, 7:55 p.m. UTC
None
diff mbox

Patch

Index: wireless-testing/drivers/net/wireless/b43/rfkill.c
===================================================================
--- wireless-testing.orig/drivers/net/wireless/b43/rfkill.c
+++ wireless-testing/drivers/net/wireless/b43/rfkill.c
@@ -33,9 +33,16 @@  bool b43_is_hw_radio_enabled(struct b43_
 		      & B43_MMIO_RADIO_HWENABLED_HI_MASK))
 			return 1;
 	} else {
-		if (b43_status(dev) >= B43_STAT_STARTED &&
-		    b43_read16(dev, B43_MMIO_RADIO_HWENABLED_LO)
-		    & B43_MMIO_RADIO_HWENABLED_LO_MASK)
+		/* To prevent CPU fault on PPC, do not read a register
+		 * unless the interface is started; however, on resume
+		 * for hibernation, this routine is entered early. When
+		 * that happens, unconditionally return TRUE.
+		 */
+		if (b43_status(dev) >= B43_STAT_STARTED) {
+			if (b43_read16(dev, B43_MMIO_RADIO_HWENABLED_LO)
+			    & B43_MMIO_RADIO_HWENABLED_LO_MASK)
+				return 1;
+		} else
 			return 1;
 	}
 	return 0;