diff mbox

nfc: pn544: mei: constify mei_cl_device_id

Message ID 4ba05401d57ab830769ef411420efdd62fa3f883.1503728344.git.arvind.yadav.cs@gmail.com (mailing list archive)
State Accepted
Delegated to: Samuel Ortiz
Headers show

Commit Message

Arvind Yadav Aug. 26, 2017, 6:26 a.m. UTC
mei_cl_device_id are not supposed to change at runtime.
mei driver is working with const 'id_table'. So mark
the non-const mei_cl_device_id structs as const.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
 drivers/nfc/pn544/mei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Winkler, Tomas Aug. 26, 2017, 9:34 a.m. UTC | #1
> 
> mei_cl_device_id are not supposed to change at runtime.
> mei driver is working with const 'id_table'. So mark the non-const
> mei_cl_device_id structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Ack

>  drivers/nfc/pn544/mei.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c index
> ad57a8e..a6c2e9c 100644
> --- a/drivers/nfc/pn544/mei.c
> +++ b/drivers/nfc/pn544/mei.c
> @@ -66,7 +66,7 @@ static int pn544_mei_remove(struct mei_cl_device
> *cldev)
>  	return 0;
>  }
> 
> -static struct mei_cl_device_id pn544_mei_tbl[] = {
> +static const struct mei_cl_device_id pn544_mei_tbl[] = {
>  	{ PN544_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
> 
>  	/* required last entry */
> --
> 2.7.4
diff mbox

Patch

diff --git a/drivers/nfc/pn544/mei.c b/drivers/nfc/pn544/mei.c
index ad57a8e..a6c2e9c 100644
--- a/drivers/nfc/pn544/mei.c
+++ b/drivers/nfc/pn544/mei.c
@@ -66,7 +66,7 @@  static int pn544_mei_remove(struct mei_cl_device *cldev)
 	return 0;
 }
 
-static struct mei_cl_device_id pn544_mei_tbl[] = {
+static const struct mei_cl_device_id pn544_mei_tbl[] = {
 	{ PN544_DRIVER_NAME, MEI_NFC_UUID, MEI_CL_VERSION_ANY},
 
 	/* required last entry */