| Message ID | 5092B4BE.4080803@infradead.org (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On 11/01/2012 06:43 PM, Randy Dunlap wrote: > From: Randy Dunlap <rdunlap@infradead.org> > > Fix printk format warning for ssid_len, which is a size_t: > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: brcm80211-dev-list@broadcom.com We actually have a patch ready for that with credit to people who reported it. We can add you to that list ;-) Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: > On 11/01/2012 06:43 PM, Randy Dunlap wrote: > > From: Randy Dunlap <rdunlap@infradead.org> > > > > Fix printk format warning for ssid_len, which is a size_t: > > > > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' > > > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > > Cc: brcm80211-dev-list@broadcom.com > > > We actually have a patch ready for that with credit to people who > reported it. We can add you to that list ;-) Which you've been sitting on for WAY too long already :) johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/01/2012 08:31 PM, Johannes Berg wrote: > On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> Fix printk format warning for ssid_len, which is a size_t: >>> >>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: brcm80211-dev-list@broadcom.com >> >> >> We actually have a patch ready for that with credit to people who >> reported it. We can add you to that list ;-) > > Which you've been sitting on for WAY too long already :) > > johannes > > True. I was actually going to make Hante fix it, but failed my management skills miserably. Fixed it myself in the end. There are quite a number of patches queued up. Another flush() not working :-) Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/01/2012 01:51 PM, Arend van Spriel wrote: > On 11/01/2012 08:31 PM, Johannes Berg wrote: >> On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >>> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap <rdunlap@infradead.org> >>>> >>>> Fix printk format warning for ssid_len, which is a size_t: >>>> >>>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>>> >>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>>> Cc: brcm80211-dev-list@broadcom.com >>> >>> >>> We actually have a patch ready for that with credit to people who >>> reported it. We can add you to that list ;-) >> >> Which you've been sitting on for WAY too long already :) >> >> johannes >> >> > > True. I was actually going to make Hante fix it, but failed my > management skills miserably. Fixed it myself in the end. There are quite > a number of patches queued up. Another flush() not working :-) Please get them into your linux-next tree so that we don't waste time fixing things that are already fixed. thanks,
On 11/01/2012 12:31 PM, Johannes Berg wrote: > On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>> From: Randy Dunlap <rdunlap@infradead.org> >>> >>> Fix printk format warning for ssid_len, which is a size_t: >>> >>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>> >>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>> Cc: brcm80211-dev-list@broadcom.com >> >> >> We actually have a patch ready for that with credit to people who >> reported it. We can add you to that list ;-) > > Which you've been sitting on for WAY too long already :) ping Arend. Please have your patch included in linux-next builds. thanks.
On 11/13/2012 04:55 PM, Randy Dunlap wrote: > On 11/01/2012 12:31 PM, Johannes Berg wrote: > >> On Thu, 2012-11-01 at 19:01 +0100, Arend van Spriel wrote: >>> On 11/01/2012 06:43 PM, Randy Dunlap wrote: >>>> From: Randy Dunlap <rdunlap@infradead.org> >>>> >>>> Fix printk format warning for ssid_len, which is a size_t: >>>> >>>> drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c:3941:2: warning: format '%d' expects type 'int', but argument 4 has type 'size_t' >>>> >>>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org> >>>> Cc: brcm80211-dev-list@broadcom.com >>> >>> >>> We actually have a patch ready for that with credit to people who >>> reported it. We can add you to that list ;-) >> >> Which you've been sitting on for WAY too long already :) > > ping Arend. > Please have your patch included in linux-next builds. thanks. > It has been posted to John on November 6th. The wireless summit in Barcelona probably gave some delay. It is on the wireless list named "[PATCH 19/24] brcmfmac: fix build regression". Gr. AvS -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
--- linux-next-20121101.orig/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c +++ linux-next-20121101/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c @@ -3938,7 +3938,7 @@ brcmf_cfg80211_start_ap(struct wiphy *wi WL_TRACE("channel_type=%d, beacon_interval=%d, dtim_period=%d,\n", settings->channel_type, settings->beacon_interval, settings->dtim_period); - WL_TRACE("ssid=%s(%d), auth_type=%d, inactivity_timeout=%d\n", + WL_TRACE("ssid=%s(%zu), auth_type=%d, inactivity_timeout=%d\n", settings->ssid, settings->ssid_len, settings->auth_type, settings->inactivity_timeout);