| Message ID | 50BF3DBB.90000@posedge.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Wed, 2012-12-05 at 17:57 +0530, Chaitanya wrote: > --- a/net/mac80211/agg-tx.c > +++ b/net/mac80211/agg-tx.c > @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, > > trace_api_start_tx_ba_session(pubsta, tid); > > - if (WARN_ON(!local->ops->ampdu_action)) > + if (WARN_ON_ONCE(!local->ops->ampdu_action)) > return -EINVAL; Hm, no tabs it seems, so this doesn't apply either. I'd just fix it myself for this simple a thing, but you'll probably eventually want to submit more complicated patches ... johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hmm..yes true i need to fix my environment. But i just tested this patch manually and it worked. Let me check this once again, will fix this and send it again. Sorry for the trouble caused. On Wednesday 05 December 2012 06:00 PM, Johannes Berg wrote: > Hm, no tabs it seems, so this doesn't apply either. > > I'd just fix it myself for this simple a thing, but you'll probably > eventually want to submit more complicated patches ... -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index 4152ed1..eb9df22 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, trace_api_start_tx_ba_session(pubsta, tid); - if (WARN_ON(!local->ops->ampdu_action)) + if (WARN_ON_ONCE(!local->ops->ampdu_action)) return -EINVAL; if ((tid >= IEEE80211_NUM_TIDS) ||
Warn once should suffice. Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log. Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail. Signed-off-by: T Krushna Chaitanya <chaitanyatk@posedge.com> --- net/mac80211/agg-tx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html