| Message ID | 50C0545B.8060805@posedge.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Thu, Dec 06, 2012 at 01:46:27PM +0530, Chaitanya wrote: > Changed the mail client to thunder bird to avoid whitespace issues. > Changed the subject and also the signing off to use offical mail. > Changed the setting for tabs (width=8, noexpandtab) and whitespaces. Don't need to mess up the change log with that. > Signed-off-by: T Krishna Chaitanya <chaitanyatk@posedge.com> > --- > net/mac80211/agg-tx.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c > index 4152ed1..eb9df22 100644 > --- a/net/mac80211/agg-tx.c > +++ b/net/mac80211/agg-tx.c > @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, > > trace_api_start_tx_ba_session(pubsta, tid); > > - if (WARN_ON(!local->ops->ampdu_action)) ^^^^^^^ Patch is still malformed (spaces instead of one tab). Before next posting to mailing list, post patch to yourself and try to apply it. Once that success, continue with mailing list posting. Thanks Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I have tested the patch by applying it myself and it worked fine. and also in My local editor (gedit) it shows tabs. Need to check the issue and revert. On Thursday 06 December 2012 02:21 PM, Stanislaw Gruszka wrote: > On Thu, Dec 06, 2012 at 01:46:27PM +0530, Chaitanya wrote: >> Changed the mail client to thunder bird to avoid whitespace issues. >> Changed the subject and also the signing off to use offical mail. >> Changed the setting for tabs (width=8, noexpandtab) and whitespaces. > Don't need to mess up the change log with that. > >> Signed-off-by: T Krishna Chaitanya <chaitanyatk@posedge.com> >> --- >> net/mac80211/agg-tx.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c >> index 4152ed1..eb9df22 100644 >> --- a/net/mac80211/agg-tx.c >> +++ b/net/mac80211/agg-tx.c >> @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, >> >> trace_api_start_tx_ba_session(pubsta, tid); >> >> - if (WARN_ON(!local->ops->ampdu_action)) > ^^^^^^^ > Patch is still malformed (spaces instead of one tab). Before next > posting to mailing list, post patch to yourself and try to apply > it. Once that success, continue with mailing list posting. > > Thanks > Stanislaw -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2012-12-06 at 15:07 +0530, Chaitanya wrote: > I have tested the patch by applying it myself and it worked fine. > and also in My local editor (gedit) it shows tabs. > > Need to check the issue and revert. Try after it made it to you from the list -- still broken here as well. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c index 4152ed1..eb9df22 100644 --- a/net/mac80211/agg-tx.c +++ b/net/mac80211/agg-tx.c @@ -445,7 +445,7 @@ int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid, trace_api_start_tx_ba_session(pubsta, tid); - if (WARN_ON(!local->ops->ampdu_action)) + if (WARN_ON_ONCE(!local->ops->ampdu_action)) return -EINVAL; if ((tid >= IEEE80211_NUM_TIDS) ||
Warn once should suffice. Eg: our driver doesn't support the ampdu_action yet, so seeing a lot of warnings, hence the check for any new drivers to avoid messing the kernel log. Changed the mail client to thunder bird to avoid whitespace issues. Changed the subject and also the signing off to use offical mail. Changed the setting for tabs (width=8, noexpandtab) and whitespaces. Signed-off-by: T Krishna Chaitanya <chaitanyatk@posedge.com> --- net/mac80211/agg-tx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html