diff mbox

mac80211: fix the multiple warnings for budding chipsets without ampdu_action defined

Message ID 50C1917E.2010407@posedge.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Chaitanya Dec. 7, 2012, 6:49 a.m. UTC
Warn once should suffice.

Eg: our driver doesn't support the ampdu_action yet, so
seeing a lot of warnings, hence the check for any
new drivers to avoid messing the kernel log.


Signed-off-by: T Krushna Chaitanya <chaitanyatk@posedge.com>
--- 
net/mac80211/agg-tx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

Johannes Berg Dec. 7, 2012, 8:14 a.m. UTC | #1
On Fri, 2012-12-07 at 12:19 +0530, Chaitanya wrote:
> 
> Warn once should suffice.
> 
> Eg: our driver doesn't support the ampdu_action yet, so
> seeing a lot of warnings, hence the check for any

Yay, this worked. Applied with a changed commit log.

johannes

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Chaitanya Dec. 7, 2012, 9:29 a.m. UTC | #2
Great to hear that johannes.
Finally after exhausting all options used the sendmail and it worked :-)

On Friday 07 December 2012 01:44 PM, Johannes Berg wrote:
> On Fri, 2012-12-07 at 12:19 +0530, Chaitanya wrote:
>> Warn once should suffice.
>>
>> Eg: our driver doesn't support the ampdu_action yet, so
>> seeing a lot of warnings, hence the check for any
> Yay, this worked. Applied with a changed commit log.
>
> johannes
>

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/mac80211/agg-tx.c b/net/mac80211/agg-tx.c
index 4152ed1..eb9df22 100644
--- a/net/mac80211/agg-tx.c
+++ b/net/mac80211/agg-tx.c
@@ -445,7 +445,7 @@  int ieee80211_start_tx_ba_session(struct ieee80211_sta *pubsta, u16 tid,
 
 	trace_api_start_tx_ba_session(pubsta, tid);
 
-	if (WARN_ON(!local->ops->ampdu_action))
+	if (WARN_ON_ONCE(!local->ops->ampdu_action))
 		return -EINVAL;
 
 	if ((tid >= IEEE80211_NUM_TIDS) ||