| Message ID | 5208BB2D.2000705@broadcom.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
Hi Arend, On 08/12/2013 12:38 PM, Arend van Spriel wrote: > On 08/11/2013 06:21 PM, Daniel Wagner wrote: >> I just updated my laptop (MacBook Air 2012) from 3.11-rc3+ to 3.11-rc4+ >> and since then brcsmac crashes short after enabling it. Unfortunately, I >> did also change some config flags in the area of cpufreq (enabling >> p-state driver) so the configuration is not exactly the same. Before I >> try to figure out what I have changed, I am posting the picture of the >> crash. Maybe it is something obvious. >> >> v3.11-rc4-197-gd92581f >> http://www.monom.org/misc/brcmsmac/v3.11-rc4.config >> http://www.monom.org/misc/brcmsmac/IMAG0064.jpg > > Thanks, Daniel > > I was looking at this issue two weeks ago and just got back from my > vacation. Can you apply the patch and send me a kernel log? Sure, the patch does the trick, the panic is gone. > Sharing pictures, huh. What about this one :-p No no, that isn't me, that is someone else! :P cheers, daniel
On 08/12/2013 10:11 PM, Daniel Wagner wrote: > Hi Arend, > > On 08/12/2013 12:38 PM, Arend van Spriel wrote: >> On 08/11/2013 06:21 PM, Daniel Wagner wrote: >>> I just updated my laptop (MacBook Air 2012) from 3.11-rc3+ to 3.11-rc4+ >>> and since then brcsmac crashes short after enabling it. Unfortunately, I >>> did also change some config flags in the area of cpufreq (enabling >>> p-state driver) so the configuration is not exactly the same. Before I >>> try to figure out what I have changed, I am posting the picture of the >>> crash. Maybe it is something obvious. >>> >>> v3.11-rc4-197-gd92581f >>> http://www.monom.org/misc/brcmsmac/v3.11-rc4.config >>> http://www.monom.org/misc/brcmsmac/IMAG0064.jpg >> >> Thanks, Daniel >> >> I was looking at this issue two weeks ago and just got back from my >> vacation. Can you apply the patch and send me a kernel log? > > Sure, the patch does the trick, the panic is gone. Unfortunately, it results in a lot of error print and phy tx errors that has been reported by others. I think the two are related, but I have not root caused it yet. Your laptop may be usable now, but wireless performance is probably bad. Too bad I can not reproduce the issue over here. Are you willing to test some patches when I got a better grasp on the issue? Regards, Arend >> Sharing pictures, huh. What about this one :-p > > No no, that isn't me, that is someone else! :P > > cheers, > daniel > > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/13/2013 03:41 PM, Arend van Spriel wrote: > On 08/12/2013 10:11 PM, Daniel Wagner wrote: >> On 08/12/2013 12:38 PM, Arend van Spriel wrote: >>> On 08/11/2013 06:21 PM, Daniel Wagner wrote: >>>> I just updated my laptop (MacBook Air 2012) from 3.11-rc3+ to 3.11-rc4+ >>>> and since then brcsmac crashes short after enabling it. >>>> Unfortunately, I >>>> did also change some config flags in the area of cpufreq (enabling >>>> p-state driver) so the configuration is not exactly the same. Before I >>>> try to figure out what I have changed, I am posting the picture of the >>>> crash. Maybe it is something obvious. >>>> >>>> v3.11-rc4-197-gd92581f >>>> http://www.monom.org/misc/brcmsmac/v3.11-rc4.config >>>> http://www.monom.org/misc/brcmsmac/IMAG0064.jpg >>> >>> Thanks, Daniel >>> >>> I was looking at this issue two weeks ago and just got back from my >>> vacation. Can you apply the patch and send me a kernel log? >> >> Sure, the patch does the trick, the panic is gone. > > Unfortunately, it results in a lot of error print and phy tx errors that > has been reported by others. I think the two are related, but I have not > root caused it yet. Your laptop may be usable now, but wireless > performance is probably bad. > > Too bad I can not reproduce the issue over here. Are you willing to test > some patches when I got a better grasp on the issue? Sure, let there be patches. :) cheers, daniel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmsmac/main.c b/drivers/net/wireless/brcm80211/brcmsmac/main.c index 9fd6f2f..ea92ea2 100644 --- a/drivers/net/wireless/brcm80211/brcmsmac/main.c +++ b/drivers/net/wireless/brcm80211/brcmsmac/main.c @@ -630,10 +630,21 @@ static uint brcms_c_calc_frame_time(struct brcms_c_info *wlc, u32 ratespec, dur = PREN_PREAMBLE + (tot_streams * PREN_PREAMBLE_EXT); if (preamble_type == BRCMS_MM_PREAMBLE) dur += PREN_MM_EXT; + + if (mcs > BRCMS_MAXMCS) { + brcms_err(wlc->hw->d11core, "wl%d: invalid mcs: %u\n", + wlc->pub->unit, mcs); + mcs = 0; + } /* 1000Ndbps = kbps * 4 */ kNdps = mcs_2_rate(mcs, rspec_is40mhz(ratespec), rspec_issgi(ratespec)) * 4; + if (kNdps == 0) { + brcms_err(wlc->hw->d11core, "wl%d: invalid zero rate: rspec=0x%x\n", + wlc->pub->unit, ratespec); + kNdps = 6500 * 4; + } if (rspec_stc(ratespec) == 0) nsyms = CEIL((APHY_SERVICE_NBITS + 8 * mac_len +