diff mbox

iwlwifi: Reason 7 periodic disconnect

Message ID 5449621C.3070400@gmail.com (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Emmanuel Grumbach Oct. 23, 2014, 8:16 p.m. UTC
> https://bpaste.net/show/5cc48256d952
> 
> On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
>> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
>> wrote:
>>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
>>
>> ok - let me re-add the logs...
>>
>>

This makes no sense to me.
We do talk to the AP since we get frames Acked...

Can you please apply this on top of what you have?



Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Lauren?iu Nicola Oct. 23, 2014, 8:27 p.m. UTC | #1
https://bpaste.net/show/8a0e5c68762f

On Thu, Oct 23, 2014, at 23:16, Emmanuel Grumbach wrote:
> > https://bpaste.net/show/5cc48256d952
> > 
> > On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
> >> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
> >> wrote:
> >>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
> >>
> >> ok - let me re-add the logs...
> >>
> >>
> 
> This makes no sense to me.
> We do talk to the AP since we get frames Acked...
> 
> Can you please apply this on top of what you have?
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 2de8870..f3b1e62 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -1991,15 +1991,16 @@ void ieee80211_sta_tx_notify(struct
> ieee80211_sub_if_data *sdata,
>         if (ieee80211_is_nullfunc(hdr->frame_control) &&
>             sdata->u.mgd.probe_send_count > 0) {
>                 if (ack)
> -                       ieee80211_sta_reset_conn_monitor(sdata);
> +               //      ieee80211_sta_reset_conn_monitor(sdata);
> +               ;
>                 else
>                         sdata->u.mgd.nullfunc_failed = true;
>                 ieee80211_queue_work(&sdata->local->hw, &sdata->work);
>                 return;
>         }
>  
> -       if (ack)
> -               ieee80211_sta_reset_conn_monitor(sdata);
> +//     if (ack)
> +//             ieee80211_sta_reset_conn_monitor(sdata);
>  }
>  
>  static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data
>  *sdata)
> 
> 
> Thanks.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach Oct. 23, 2014, 8:33 p.m. UTC | #2
On Thu, Oct 23, 2014 at 11:27 PM, Lauren?iu Nicola <lnicola@dend.ro> wrote:
> https://bpaste.net/show/8a0e5c68762f
>
> On Thu, Oct 23, 2014, at 23:16, Emmanuel Grumbach wrote:
>> > https://bpaste.net/show/5cc48256d952
>> >
>> > On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
>> >> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
>> >> wrote:
>> >>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
>> >>
>> >> ok - let me re-add the logs...
>> >>
>> >>
>>
>> This makes no sense to me.
>> We do talk to the AP since we get frames Acked...

This again makes no sense to me.
Time to go to bed I guess.

>>
>> Can you please apply this on top of what you have?
>>
>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> index 2de8870..f3b1e62 100644
>> --- a/net/mac80211/mlme.c
>> +++ b/net/mac80211/mlme.c
>> @@ -1991,15 +1991,16 @@ void ieee80211_sta_tx_notify(struct
>> ieee80211_sub_if_data *sdata,
>>         if (ieee80211_is_nullfunc(hdr->frame_control) &&
>>             sdata->u.mgd.probe_send_count > 0) {
>>                 if (ack)
>> -                       ieee80211_sta_reset_conn_monitor(sdata);
>> +               //      ieee80211_sta_reset_conn_monitor(sdata);
>> +               ;
>>                 else
>>                         sdata->u.mgd.nullfunc_failed = true;
>>                 ieee80211_queue_work(&sdata->local->hw, &sdata->work);
>>                 return;
>>         }
>>
>> -       if (ack)
>> -               ieee80211_sta_reset_conn_monitor(sdata);
>> +//     if (ack)
>> +//             ieee80211_sta_reset_conn_monitor(sdata);
>>  }
>>
>>  static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data
>>  *sdata)
>>
>>
>> Thanks.
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach Oct. 24, 2014, 5:32 a.m. UTC | #3
On Thu, Oct 23, 2014 at 11:33 PM, Emmanuel Grumbach <egrumbach@gmail.com> wrote:
> On Thu, Oct 23, 2014 at 11:27 PM, Lauren?iu Nicola <lnicola@dend.ro> wrote:
>> https://bpaste.net/show/8a0e5c68762f
>>
>> On Thu, Oct 23, 2014, at 23:16, Emmanuel Grumbach wrote:
>>> > https://bpaste.net/show/5cc48256d952
>>> >
>>> > On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
>>> >> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
>>> >> wrote:
>>> >>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
>>> >>
>>> >> ok - let me re-add the logs...
>>> >>
>>> >>
>>>
>>> This makes no sense to me.
>>> We do talk to the AP since we get frames Acked...
>
> This again makes no sense to me.
> Time to go to bed I guess.

Can you please open a bug on bugzilla.kernel.org?
Make sure to CC ilw@linux.intel.com

This will make it more trackable.
Thanks.

>
>>>
>>> Can you please apply this on top of what you have?
>>>
>>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>>> index 2de8870..f3b1e62 100644
>>> --- a/net/mac80211/mlme.c
>>> +++ b/net/mac80211/mlme.c
>>> @@ -1991,15 +1991,16 @@ void ieee80211_sta_tx_notify(struct
>>> ieee80211_sub_if_data *sdata,
>>>         if (ieee80211_is_nullfunc(hdr->frame_control) &&
>>>             sdata->u.mgd.probe_send_count > 0) {
>>>                 if (ack)
>>> -                       ieee80211_sta_reset_conn_monitor(sdata);
>>> +               //      ieee80211_sta_reset_conn_monitor(sdata);
>>> +               ;
>>>                 else
>>>                         sdata->u.mgd.nullfunc_failed = true;
>>>                 ieee80211_queue_work(&sdata->local->hw, &sdata->work);
>>>                 return;
>>>         }
>>>
>>> -       if (ack)
>>> -               ieee80211_sta_reset_conn_monitor(sdata);
>>> +//     if (ack)
>>> +//             ieee80211_sta_reset_conn_monitor(sdata);
>>>  }
>>>
>>>  static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data
>>>  *sdata)
>>>
>>>
>>> Thanks.
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
>>> in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Lauren?iu Nicola Oct. 24, 2014, 8:34 a.m. UTC | #4
Okay, I've filed a bug [1].

At some point you mentioned about using another device to monitor
traffic. I don't have another laptop running Linux (would Android
count?), but DD-WRT has a "wl monitor" command [2] that sounds useful.
Should I try to install tcpdump on my router?

Laurentiu

[1] https://bugzilla.kernel.org/show_bug.cgi?id=86801
[2] http://www.dd-wrt.com/wiki/index.php/Wl#monitor

On Fri, Oct 24, 2014, at 08:32, Emmanuel Grumbach wrote:
> On Thu, Oct 23, 2014 at 11:33 PM, Emmanuel Grumbach <egrumbach@gmail.com>
> wrote:
> > On Thu, Oct 23, 2014 at 11:27 PM, Lauren?iu Nicola <lnicola@dend.ro> wrote:
> >> https://bpaste.net/show/8a0e5c68762f
> >>
> >> On Thu, Oct 23, 2014, at 23:16, Emmanuel Grumbach wrote:
> >>> > https://bpaste.net/show/5cc48256d952
> >>> >
> >>> > On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
> >>> >> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
> >>> >> wrote:
> >>> >>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
> >>> >>
> >>> >> ok - let me re-add the logs...
> >>> >>
> >>> >>
> >>>
> >>> This makes no sense to me.
> >>> We do talk to the AP since we get frames Acked...
> >
> > This again makes no sense to me.
> > Time to go to bed I guess.
> 
> Can you please open a bug on bugzilla.kernel.org?
> Make sure to CC ilw@linux.intel.com
> 
> This will make it more trackable.
> Thanks.
> 
> >
> >>>
> >>> Can you please apply this on top of what you have?
> >>>
> >>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> >>> index 2de8870..f3b1e62 100644
> >>> --- a/net/mac80211/mlme.c
> >>> +++ b/net/mac80211/mlme.c
> >>> @@ -1991,15 +1991,16 @@ void ieee80211_sta_tx_notify(struct
> >>> ieee80211_sub_if_data *sdata,
> >>>         if (ieee80211_is_nullfunc(hdr->frame_control) &&
> >>>             sdata->u.mgd.probe_send_count > 0) {
> >>>                 if (ack)
> >>> -                       ieee80211_sta_reset_conn_monitor(sdata);
> >>> +               //      ieee80211_sta_reset_conn_monitor(sdata);
> >>> +               ;
> >>>                 else
> >>>                         sdata->u.mgd.nullfunc_failed = true;
> >>>                 ieee80211_queue_work(&sdata->local->hw, &sdata->work);
> >>>                 return;
> >>>         }
> >>>
> >>> -       if (ack)
> >>> -               ieee80211_sta_reset_conn_monitor(sdata);
> >>> +//     if (ack)
> >>> +//             ieee80211_sta_reset_conn_monitor(sdata);
> >>>  }
> >>>
> >>>  static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data
> >>>  *sdata)
> >>>
> >>>
> >>> Thanks.
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
> >>> in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Emmanuel Grumbach Oct. 24, 2014, 10:26 a.m. UTC | #5
On Fri, Oct 24, 2014 at 11:34 AM, Lauren?iu Nicola <lnicola@dend.ro> wrote:
> Okay, I've filed a bug [1].
>
> At some point you mentioned about using another device to monitor
> traffic. I don't have another laptop running Linux (would Android
> count?), but DD-WRT has a "wl monitor" command [2] that sounds useful.
> Should I try to install tcpdump on my router?

You can try - but I think that tracing might help and is easier to get.
I put the instructions in the bug.

>
> Laurentiu
>
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=86801
> [2] http://www.dd-wrt.com/wiki/index.php/Wl#monitor
>
> On Fri, Oct 24, 2014, at 08:32, Emmanuel Grumbach wrote:
>> On Thu, Oct 23, 2014 at 11:33 PM, Emmanuel Grumbach <egrumbach@gmail.com>
>> wrote:
>> > On Thu, Oct 23, 2014 at 11:27 PM, Lauren?iu Nicola <lnicola@dend.ro> wrote:
>> >> https://bpaste.net/show/8a0e5c68762f
>> >>
>> >> On Thu, Oct 23, 2014, at 23:16, Emmanuel Grumbach wrote:
>> >>> > https://bpaste.net/show/5cc48256d952
>> >>> >
>> >>> > On Thu, Oct 23, 2014, at 22:55, Emmanuel Grumbach wrote:
>> >>> >> On Thu, Oct 23, 2014 at 10:42 PM, Lauren?iu Nicola <lnicola@dend.ro>
>> >>> >> wrote:
>> >>> >>> Doesn't seem to help https://bpaste.net/show/68e1a6b33689.
>> >>> >>
>> >>> >> ok - let me re-add the logs...
>> >>> >>
>> >>> >>
>> >>>
>> >>> This makes no sense to me.
>> >>> We do talk to the AP since we get frames Acked...
>> >
>> > This again makes no sense to me.
>> > Time to go to bed I guess.
>>
>> Can you please open a bug on bugzilla.kernel.org?
>> Make sure to CC ilw@linux.intel.com
>>
>> This will make it more trackable.
>> Thanks.
>>
>> >
>> >>>
>> >>> Can you please apply this on top of what you have?
>> >>>
>> >>> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
>> >>> index 2de8870..f3b1e62 100644
>> >>> --- a/net/mac80211/mlme.c
>> >>> +++ b/net/mac80211/mlme.c
>> >>> @@ -1991,15 +1991,16 @@ void ieee80211_sta_tx_notify(struct
>> >>> ieee80211_sub_if_data *sdata,
>> >>>         if (ieee80211_is_nullfunc(hdr->frame_control) &&
>> >>>             sdata->u.mgd.probe_send_count > 0) {
>> >>>                 if (ack)
>> >>> -                       ieee80211_sta_reset_conn_monitor(sdata);
>> >>> +               //      ieee80211_sta_reset_conn_monitor(sdata);
>> >>> +               ;
>> >>>                 else
>> >>>                         sdata->u.mgd.nullfunc_failed = true;
>> >>>                 ieee80211_queue_work(&sdata->local->hw, &sdata->work);
>> >>>                 return;
>> >>>         }
>> >>>
>> >>> -       if (ack)
>> >>> -               ieee80211_sta_reset_conn_monitor(sdata);
>> >>> +//     if (ack)
>> >>> +//             ieee80211_sta_reset_conn_monitor(sdata);
>> >>>  }
>> >>>
>> >>>  static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data
>> >>>  *sdata)
>> >>>
>> >>>
>> >>> Thanks.
>> >>> --
>> >>> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
>> >>> in
>> >>> the body of a message to majordomo@vger.kernel.org
>> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-wireless"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 2de8870..f3b1e62 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -1991,15 +1991,16 @@  void ieee80211_sta_tx_notify(struct ieee80211_sub_if_data *sdata,
        if (ieee80211_is_nullfunc(hdr->frame_control) &&
            sdata->u.mgd.probe_send_count > 0) {
                if (ack)
-                       ieee80211_sta_reset_conn_monitor(sdata);
+               //      ieee80211_sta_reset_conn_monitor(sdata);
+               ;
                else
                        sdata->u.mgd.nullfunc_failed = true;
                ieee80211_queue_work(&sdata->local->hw, &sdata->work);
                return;
        }
 
-       if (ack)
-               ieee80211_sta_reset_conn_monitor(sdata);
+//     if (ack)
+//             ieee80211_sta_reset_conn_monitor(sdata);
 }
 
 static void ieee80211_mgd_probe_ap_send(struct ieee80211_sub_if_data *sdata)