| Message ID | 55894C40.1070108@broadcom.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi Arend, On Di, 2015-06-23 at 14:08 +0200, Arend van Spriel wrote: > On 06/23/15 13:31, Jörg Krause wrote: > > Hi Arend, > > > > On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote: > > > > > > My bad. The patch removes p2pdev from interface modes, but it is > > > still > > > listed in the interface combinations and cfg80211 will complain > > > about > > > it. Have to extend the patch. I better do that after a good > > > nights > > > sleep. > > > > Never mind! Did you had a good night sleep already :-) ? > > Several ;-) Did not get to this earlier. Thanks for the reminder. > > Had a closer look at wiphy_verify_combinations() and I am hopeful the > > attached patch will fix the wiphy_register() failure. > Sorry for late reply! I was busy on another topic... I've applied your patch, but p2p interface is still not working. I attached the debug log from wpa_supplicant. I tested with Linux Kernel 4.0.7 and wpa_supplicant 2.4. This is my p2p_supplicant.conf: ctrl_interface=/var/run/p2p_supplicant update_config=1 device_name=HBM10 device_type=1-0050F204-1 p2p_go_ht40=1 Test with the p2p_find command: # wpa_cli -p /var/run/p2p_supplicant p2p_find Selected interface 'p2p0' 1928.165036: p2p0: Control interface command 'P2P_FIND' FAIL Best regards Jörg Krause
Hi all, On Di, 2015-07-07 at 09:47 +0200, Jörg Krause wrote: > Hi Arend, > > On Di, 2015-06-23 at 14:08 +0200, Arend van Spriel wrote: > > On 06/23/15 13:31, Jörg Krause wrote: > > > Hi Arend, > > > > > > On So, 2015-06-21 at 23:18 +0200, Arend van Spriel wrote: > > > > > > > > My bad. The patch removes p2pdev from interface modes, but it > > > > is > > > > still > > > > listed in the interface combinations and cfg80211 will complain > > > > > > > > about > > > > it. Have to extend the patch. I better do that after a good > > > > nights > > > > sleep. > > > > > > Never mind! Did you had a good night sleep already :-) ? > > > > Several ;-) Did not get to this earlier. Thanks for the reminder. > > > > Had a closer look at wiphy_verify_combinations() and I am hopeful > > the > > > > attached patch will fix the wiphy_register() failure. > > > > Sorry for late reply! I was busy on another topic... > > I've applied your patch, but p2p interface is still not working. I > attached the debug log from wpa_supplicant. > > I tested with Linux Kernel 4.0.7 and wpa_supplicant 2.4. > > This is my p2p_supplicant.conf: > ctrl_interface=/var/run/p2p_supplicant > update_config=1 > > device_name=HBM10 > device_type=1-0050F204-1 > > p2p_go_ht40=1 > > Test with the p2p_find command: > # wpa_cli -p /var/run/p2p_supplicant p2p_find > Selected interface 'p2p0' > 1928.165036: p2p0: Control interface command 'P2P_FIND' > FAIL > ping :-) Any news on this? Best regards Jörg Krause -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c index 10eaabf..ffa9aca 100644 --- a/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c +++ b/drivers/net/wireless/brcm80211/brcmfmac/cfg80211.c @@ -5802,6 +5802,10 @@ static int brcmf_setup_wiphy(struct wiphy *wiphy, struct brcmf_if *ifp) ifc_combo.n_limits = ARRAY_SIZE(brcmf_iface_limits_mbss), ifc_combo.limits = brcmf_iface_limits_mbss; } + /* don't give p2pdev limit when p2pon is set */ + if (ifp->drvr->iflist[1]) + ifc_combo.limits--; + wiphy->iface_combinations = kmemdup(&ifc_combo, sizeof(ifc_combo), GFP_KERNEL);