| Message ID | 5686D2E0.2010309@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
On 01/01/2016 08:26 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 1 Jan 2016 20:20:15 +0100 I think it has been said over and over, but please use driver name only as prefix. I don't see value to prepend it with 'net-'. > Omit explicit initialisation at the beginning for one local variable > that is redefined before its first use. > That being said here is my.... Acked-by: Arend van Spriel <arend@broadcom.com> > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > index ceb2a75..c21eeb1 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c > @@ -3260,7 +3260,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus, > const struct firmware *fw, > void *nvram, u32 nvlen) > { > - int bcmerror = -EFAULT; > + int bcmerror; > u32 rstvec; > > sdio_claim_host(bus->sdiodev->func[1]); > -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Arend van Spriel <arend@broadcom.com> writes: > On 01/01/2016 08:26 PM, SF Markus Elfring wrote: >> From: Markus Elfring <elfring@users.sourceforge.net> >> Date: Fri, 1 Jan 2016 20:20:15 +0100 > > I think it has been said over and over, but please use driver name > only as prefix. I don't see value to prepend it with 'net-'. Yes, please use existing naming schemes. This time I can fix it before I commit the patch, but in the future please use correct prefixes. It's easy to check what has been used previously: $ git log --oneline --no-merges --follow drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | head -10 63ce3d5db093 brcmfmac: use msecs_to_jiffies() in macro definitions 4011fc499690 brcmfmac: change brcmf_sdio_wd_timer() prototype a7decc44a002 brcmfmac: fix waitqueue_active without memory barrier in brcmfmac driver 46d703a77539 brcmfmac: Unify methods to define and map firmware files. 64d66c30c37e brcmfmac: no retries on rxglom superframe errors 6866a64a0f9b brcmfmac: constify brcmf_bus_ops structures 05491d2ccf20 brcm80211: move under broadcom vendor directory ff4445a8502c brcmfmac: expose device memory to devcoredump subsystem a32be0177252 brcmfmac: include linux/atomic.h 9d6c1dc4f913 brcmfmac: add dedicated debug level for firmware console logging $
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c index ceb2a75..c21eeb1 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c @@ -3260,7 +3260,7 @@ static int brcmf_sdio_download_firmware(struct brcmf_sdio *bus, const struct firmware *fw, void *nvram, u32 nvlen) { - int bcmerror = -EFAULT; + int bcmerror; u32 rstvec; sdio_claim_host(bus->sdiodev->func[1]);