| Message ID | 593fec4f-fc0c-4610-b144-35760ee92102@MAIL1.uni-rostock.de (mailing list archive) |
|---|---|
| State | RFC |
| Delegated to: | Johannes Berg |
| Headers | show |
On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote: > The ops field is zero initialized, therefore parallel ops is already > false. Therefore this patch is completely pointless? johannes
Am 8. September 2017 16:19:20 MESZ schrieb Johannes Berg <johannes@sipsolutions.net>: >On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote: >> The ops field is zero initialized, therefore parallel ops is already >> false. > >Therefore this patch is completely pointless? Sorry my first message was missing regarding this. My question is, whether this is intentionally, and if it is parallel, whether we need extensive locking here. > >johannes
On Fri, 2017-09-08 at 17:07 +0200, Benjamin Beichler wrote: > > Am 8. September 2017 16:19:20 MESZ schrieb Johannes Berg <johannes@si > psolutions.net>: > > On Fri, 2017-09-08 at 16:11 +0200, Benjamin Beichler wrote: > > > The ops field is zero initialized, therefore parallel ops is > > > already > > > false. > > > > Therefore this patch is completely pointless? > > Sorry my first message was missing regarding this. My question is, > whether this is intentionally, and if it is parallel, whether we need > extensive locking here. It's basically intentional - not sure parallel_ops even existed when this was first written, but we can probably use parallel_ops if we want to. johannes
diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index 62c5a00a76c3..5dd4be2a8487 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -3499,6 +3499,7 @@ static struct genl_family hwsim_genl_family __ro_after_init = { .n_ops = ARRAY_SIZE(hwsim_ops), .mcgrps = hwsim_mcgrps, .n_mcgrps = ARRAY_SIZE(hwsim_mcgrps), + .parallel_ops = false }; static void destroy_radio(struct work_struct *work)
The ops field is zero initialized, therefore parallel ops is already false. This implicates that the netlink callbacks are not processed in parallel. Maybe this could be utilized to reduce locking overhead or maybe also parallel ops could be implemented. Signed-off-by: Benjamin Beichler <benjamin.beichler@uni-rostock.de> --- drivers/net/wireless/mac80211_hwsim.c | 1 + 1 file changed, 1 insertion(+)