| Message ID | 6d10f829-5a0c-405a-b39a-d7266f3a1a0b@I-love.SAKURA.ne.jp (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | nfc: nci: Fix kcov check in nci_rx_work() | expand |
On 05/05/2024 12:36, Tetsuo Handa wrote: > Commit 7e8cdc97148c ("nfc: Add KCOV annotations") added > kcov_remote_start_common()/kcov_remote_stop() pair into nci_rx_work(), > with an assumption that kcov_remote_stop() is called upon continue of > the for loop. But commit d24b03535e5e ("nfc: nci: Fix uninit-value in > nci_dev_up and nci_ntf_packet") forgot to call kcov_remote_stop() before > break of the for loop. > > Reported-by: syzbot <syzbot+0438378d6f157baae1a2@syzkaller.appspotmail.com> > Closes: https://syzkaller.appspot.com/bug?extid=0438378d6f157baae1a2 > Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") > Debugged-by: Andrey Konovalov <andreyknvl@gmail.com> > Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Sun, 5 May 2024 19:36:49 +0900 you wrote: > Commit 7e8cdc97148c ("nfc: Add KCOV annotations") added > kcov_remote_start_common()/kcov_remote_stop() pair into nci_rx_work(), > with an assumption that kcov_remote_stop() is called upon continue of > the for loop. But commit d24b03535e5e ("nfc: nci: Fix uninit-value in > nci_dev_up and nci_ntf_packet") forgot to call kcov_remote_stop() before > break of the for loop. > > [...] Here is the summary with links: - nfc: nci: Fix kcov check in nci_rx_work() https://git.kernel.org/netdev/net/c/19e35f24750d You are awesome, thank you!
diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c index 0d26c8ec9993..b133dc55304c 100644 --- a/net/nfc/nci/core.c +++ b/net/nfc/nci/core.c @@ -1518,6 +1518,7 @@ static void nci_rx_work(struct work_struct *work) if (!nci_plen(skb->data)) { kfree_skb(skb); + kcov_remote_stop(); break; }
Commit 7e8cdc97148c ("nfc: Add KCOV annotations") added kcov_remote_start_common()/kcov_remote_stop() pair into nci_rx_work(), with an assumption that kcov_remote_stop() is called upon continue of the for loop. But commit d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") forgot to call kcov_remote_stop() before break of the for loop. Reported-by: syzbot <syzbot+0438378d6f157baae1a2@syzkaller.appspotmail.com> Closes: https://syzkaller.appspot.com/bug?extid=0438378d6f157baae1a2 Fixes: d24b03535e5e ("nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet") Debugged-by: Andrey Konovalov <andreyknvl@gmail.com> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> --- net/nfc/nci/core.c | 1 + 1 file changed, 1 insertion(+)