| Message ID | 78810e3ebb74ddbd3a4538f182bf1143b89baba7.1731332414.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | wlcore: testmode: Constify strutc nla_policy | expand |
On 11/11/2024 5:40 AM, Christophe JAILLET wrote: > 'struct nla_policy' is not modified in this driver. > > Constifying this structure moves some data to a read-only section, so > increase overall security, especially when the structure holds some > function pointers. > > On a x86_64, with allmodconfig: > Before: > ====== > text data bss dec hex filename > 5062 528 0 5590 15d6 drivers/net/wireless/ti/wlcore/testmode.o > > After: > ===== > text data bss dec hex filename > 5178 404 0 5582 15ce drivers/net/wireless/ti/wlcore/testmode.o > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > Compile tested only > --- > drivers/net/wireless/ti/wlcore/testmode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ti/wlcore/testmode.c b/drivers/net/wireless/ti/wlcore/testmode.c > index 3f338b8096c7..fc8ea58bc165 100644 > --- a/drivers/net/wireless/ti/wlcore/testmode.c > +++ b/drivers/net/wireless/ti/wlcore/testmode.c > @@ -45,7 +45,7 @@ enum wl1271_tm_attrs { > }; > #define WL1271_TM_ATTR_MAX (__WL1271_TM_ATTR_AFTER_LAST - 1) > > -static struct nla_policy wl1271_tm_policy[WL1271_TM_ATTR_MAX + 1] = { > +static const struct nla_policy wl1271_tm_policy[WL1271_TM_ATTR_MAX + 1] = { > [WL1271_TM_ATTR_CMD_ID] = { .type = NLA_U32 }, > [WL1271_TM_ATTR_ANSWER] = { .type = NLA_U8 }, > [WL1271_TM_ATTR_DATA] = { .type = NLA_BINARY,
diff --git a/drivers/net/wireless/ti/wlcore/testmode.c b/drivers/net/wireless/ti/wlcore/testmode.c index 3f338b8096c7..fc8ea58bc165 100644 --- a/drivers/net/wireless/ti/wlcore/testmode.c +++ b/drivers/net/wireless/ti/wlcore/testmode.c @@ -45,7 +45,7 @@ enum wl1271_tm_attrs { }; #define WL1271_TM_ATTR_MAX (__WL1271_TM_ATTR_AFTER_LAST - 1) -static struct nla_policy wl1271_tm_policy[WL1271_TM_ATTR_MAX + 1] = { +static const struct nla_policy wl1271_tm_policy[WL1271_TM_ATTR_MAX + 1] = { [WL1271_TM_ATTR_CMD_ID] = { .type = NLA_U32 }, [WL1271_TM_ATTR_ANSWER] = { .type = NLA_U8 }, [WL1271_TM_ATTR_DATA] = { .type = NLA_BINARY,
'struct nla_policy' is not modified in this driver. Constifying this structure moves some data to a read-only section, so increase overall security, especially when the structure holds some function pointers. On a x86_64, with allmodconfig: Before: ====== text data bss dec hex filename 5062 528 0 5590 15d6 drivers/net/wireless/ti/wlcore/testmode.o After: ===== text data bss dec hex filename 5178 404 0 5582 15ce drivers/net/wireless/ti/wlcore/testmode.o Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile tested only --- drivers/net/wireless/ti/wlcore/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)