| Message ID | 7ad826a7-7651-48e7-9589-7d2dc17417c2@stanley.mountain (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | [next] wifi: mac80211: fix memory leak in ieee80211_mgd_assoc_ml_reconf() | expand |
diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c index 0d3f64eb573e..f8d52b3b0d0e 100644 --- a/net/mac80211/mlme.c +++ b/net/mac80211/mlme.c @@ -10273,8 +10273,10 @@ int ieee80211_mgd_assoc_ml_reconf(struct ieee80211_sub_if_data *sdata, * on which the request was received. */ skb = ieee80211_build_ml_reconf_req(sdata, data, rem_links); - if (!skb) - return -ENOMEM; + if (!skb) { + err = -ENOMEM; + goto err_free; + } if (rem_links) { u16 new_dormant_links = sdata->vif.dormant_links & ~rem_links;
Free the "data" allocation before returning on this error path. Fixes: 36e05b0b8390 ("wifi: mac80211: Support dynamic link addition and removal") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> --- net/mac80211/mlme.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)