| Message ID | 7f3dbe604102f7d765149fffef8a4e6b9fa15552.1541238842.git-series.plaes@plaes.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | Use common cordic algorithm for b43 | expand |
Priit Laes <plaes@plaes.org> writes: > Now that we use library macros, we can drop internal copies > > Signed-off-by: Priit Laes <plaes@plaes.org> > --- > drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +------- Also here this is about brcmsmac. > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h > @@ -220,13 +220,6 @@ enum phy_cal_mode { > #define BB_MULT_MASK 0x0000ffff > #define BB_MULT_VALID_MASK 0x80000000 > > -#define CORDIC_AG 39797 > -#define CORDIC_NI 18 > -#define FIXED(X) ((s32)((X) << 16)) > - > -#define FLOAT(X) \ > - (((X) >= 0) ? ((((X) >> 15) + 1) >> 1) : -((((-(X)) >> 15) + 1) >> 1)) > - Ah, now I see the benefit from patch 2. IMHO you could just fold patch 3 into patch 2, no need to split them.
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h index 4960f7d..e9e8337 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h @@ -220,13 +220,6 @@ enum phy_cal_mode { #define BB_MULT_MASK 0x0000ffff #define BB_MULT_VALID_MASK 0x80000000 -#define CORDIC_AG 39797 -#define CORDIC_NI 18 -#define FIXED(X) ((s32)((X) << 16)) - -#define FLOAT(X) \ - (((X) >= 0) ? ((((X) >> 15) + 1) >> 1) : -((((-(X)) >> 15) + 1) >> 1)) - #define PHY_CHAIN_TX_DISABLE_TEMP 115 #define PHY_HYSTERESIS_DELTATEMP 5
Now that we use library macros, we can drop internal copies Signed-off-by: Priit Laes <plaes@plaes.org> --- drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_int.h | 7 +------- 1 file changed, 7 deletions(-)