| Message ID | 8ef50a4e96014949bbfde956edd07108@208suo.com (mailing list archive) |
|---|---|
| State | Rejected |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | rtlwifi: rtl8192de: phy: "foo * bar" should be "foo *bar" | expand |
On 7/19/23 04:54, hanyu001@208suo.com wrote: > > This patch fixes the checkpatch.pl error: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" > should be "foo *bar" > > Signed-off-by: Yu Han <hanyu001@208suo.com> > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > index d18c092..27b029b 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c > @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct > ieee80211_hw *hw, u8 channel) > } > > static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw, > - u32 *targetchnl, u32 * curvecount_val, > + u32 *targetchnl, u32 *curvecount_val, > bool is5g, u32 *curveindex) > { > struct rtl_priv *rtlpriv = rtl_priv(hw); The preferred subject would be "wifi: rtlwifi: rtl8192de: ...." That can probably be fixed at merge time. I will let Kalle decide that part. Reviewed-by: Larry Finger<Larry.Finger@lwfinger.net> Thanks, Larry
hanyu001@208suo.com writes: > This patch fixes the checkpatch.pl error: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: > "foo * bar" should be "foo *bar" > > Signed-off-by: Yu Han <hanyu001@208suo.com> Please don't submit checkpatch fixes to wireless, they are too much work with very little gain.
diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c index d18c092..27b029b 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c @@ -2431,7 +2431,7 @@ static bool _rtl92d_is_legal_5g_channel(struct ieee80211_hw *hw, u8 channel) } static void _rtl92d_phy_calc_curvindex(struct ieee80211_hw *hw, - u32 *targetchnl, u32 * curvecount_val, + u32 *targetchnl, u32 *curvecount_val, bool is5g, u32 *curveindex) {
This patch fixes the checkpatch.pl error: ./drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c:2434: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Yu Han <hanyu001@208suo.com> --- drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) struct rtl_priv *rtlpriv = rtl_priv(hw);