diff mbox

iwlwifi: remove unused parameter from iwl_hcmd_queue_reclaim

Message ID 9506853D-331A-4900-BAA3-61C3CB280AAD@cs.washington.edu (mailing list archive)
State Not Applicable, archived
Headers show

Commit Message

Daniel Halperin May 17, 2011, 4:46 a.m. UTC
cmd_index is never used.

Signed-off-by: Daniel Halperin <dhalperi@cs.washington.edu>
---
 drivers/net/wireless/iwlwifi/iwl-tx.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Comments

Guy, Wey-Yi W May 17, 2011, 2:24 p.m. UTC | #1
On Mon, 2011-05-16 at 21:46 -0700, Daniel Halperin wrote:
> cmd_index is never used.
> 
> Signed-off-by: Daniel Halperin <dhalperi@cs.washington.edu>
> ---
>  drivers/net/wireless/iwlwifi/iwl-tx.c |    5 ++---
>  1 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
> index 54a935f..686e176 100644
> --- a/drivers/net/wireless/iwlwifi/iwl-tx.c
> +++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
> @@ -746,8 +746,7 @@ int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
>   * need to be reclaimed. As result, some free space forms.  If there is
>   * enough free space (> low mark), wake the stack that feeds us.
>   */
> -static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
> -				   int idx, int cmd_idx)
> +static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id, int idx)
>  {
>  	struct iwl_tx_queue *txq = &priv->txq[txq_id];
>  	struct iwl_queue *q = &txq->q;
> @@ -819,7 +818,7 @@ void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
>  
>  	spin_lock_irqsave(&priv->hcmd_lock, flags);
>  
> -	iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
> +	iwl_hcmd_queue_reclaim(priv, txq_id, index);
>  
>  	if (!(meta->flags & CMD_ASYNC)) {
>  		clear_bit(STATUS_HCMD_ACTIVE, &priv->status);
Thanks
Wey

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/wireless/iwlwifi/iwl-tx.c b/drivers/net/wireless/iwlwifi/iwl-tx.c
index 54a935f..686e176 100644
--- a/drivers/net/wireless/iwlwifi/iwl-tx.c
+++ b/drivers/net/wireless/iwlwifi/iwl-tx.c
@@ -746,8 +746,7 @@  int iwl_enqueue_hcmd(struct iwl_priv *priv, struct iwl_host_cmd *cmd)
  * need to be reclaimed. As result, some free space forms.  If there is
  * enough free space (> low mark), wake the stack that feeds us.
  */
-static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id,
-				   int idx, int cmd_idx)
+static void iwl_hcmd_queue_reclaim(struct iwl_priv *priv, int txq_id, int idx)
 {
 	struct iwl_tx_queue *txq = &priv->txq[txq_id];
 	struct iwl_queue *q = &txq->q;
@@ -819,7 +818,7 @@  void iwl_tx_cmd_complete(struct iwl_priv *priv, struct iwl_rx_mem_buffer *rxb)
 
 	spin_lock_irqsave(&priv->hcmd_lock, flags);
 
-	iwl_hcmd_queue_reclaim(priv, txq_id, index, cmd_index);
+	iwl_hcmd_queue_reclaim(priv, txq_id, index);
 
 	if (!(meta->flags & CMD_ASYNC)) {
 		clear_bit(STATUS_HCMD_ACTIVE, &priv->status);