| Message ID | CABtq2xReyqg1wJM7W1d=KWRNTNN0Q6HCgJMWcQ6DH=SmKcxQRg@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | staging: rtl8723bs: Add 024c:0627 to the list of SDIO device-ids | expand |
Hi, On 10/29/20 2:52 PM, Brian O'Keefe wrote: > Add 024c:0627 to the list of SDIO device-ids, based on hardware found in > the wild. This hardware exists on at least some Acer SW1-011 tablets. > > Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> Patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 5b1392deb0a7..7256d55fcc1b 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = > { SDIO_DEVICE(0x024c, 0x0525), }, > { SDIO_DEVICE(0x024c, 0x0623), }, > { SDIO_DEVICE(0x024c, 0x0626), }, > + { SDIO_DEVICE(0x024c, 0x0627), }, > { SDIO_DEVICE(0x024c, 0xb723), }, > { /* end: all zeroes */ }, > }; > -- > 2.25.1 >
On 10/29/2020 2:52 PM, Brian O'Keefe wrote: > Add 024c:0627 to the list of SDIO device-ids, based on hardware found in > the wild. This hardware exists on at least some Acer SW1-011 tablets. > > Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 5b1392deb0a7..7256d55fcc1b 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = > { SDIO_DEVICE(0x024c, 0x0525), }, > { SDIO_DEVICE(0x024c, 0x0623), }, > { SDIO_DEVICE(0x024c, 0x0626), }, > + { SDIO_DEVICE(0x024c, 0x0627), }, > { SDIO_DEVICE(0x024c, 0xb723), }, shouldn't these be listed in include/linux/mmc/sdio_ids.h ? Regards, Arend
On Fri, Oct 30, 2020 at 10:25 AM Arend Van Spriel <arend.vanspriel@broadcom.com> wrote: > > On 10/29/2020 2:52 PM, Brian O'Keefe wrote: > > Add 024c:0627 to the list of SDIO device-ids, based on hardware found in > > the wild. This hardware exists on at least some Acer SW1-011 tablets. > > > > Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> > > --- > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > index 5b1392deb0a7..7256d55fcc1b 100644 > > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = > > { SDIO_DEVICE(0x024c, 0x0525), }, > > { SDIO_DEVICE(0x024c, 0x0623), }, > > { SDIO_DEVICE(0x024c, 0x0626), }, > > + { SDIO_DEVICE(0x024c, 0x0627), }, > > { SDIO_DEVICE(0x024c, 0xb723), }, > > shouldn't these be listed in include/linux/mmc/sdio_ids.h ? It certainly looks that way; this was the only place that used hex values in the SDIO_DEVICE macro directly. I'm happy to submit a follow-up patch to create constants in sdio_ids.h and use those instead. > > Regards, > Arend
On Thu, Oct 29, 2020 at 09:52:16AM -0400, Brian O'Keefe wrote: > Add 024c:0627 to the list of SDIO device-ids, based on hardware found in > the wild. This hardware exists on at least some Acer SW1-011 tablets. > > Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > --- > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > index 5b1392deb0a7..7256d55fcc1b 100644 > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = > { SDIO_DEVICE(0x024c, 0x0525), }, > { SDIO_DEVICE(0x024c, 0x0623), }, > { SDIO_DEVICE(0x024c, 0x0626), }, > + { SDIO_DEVICE(0x024c, 0x0627), }, > { SDIO_DEVICE(0x024c, 0xb723), }, > { /* end: all zeroes */ }, > }; > -- > 2.25.1 All of the tabs are gone in your email and it's only spaces, making this patch impossible to apply :( Can you fix up your email client and resend this and keep Hans's Reviewed-by on it? thanks, greg k-h
On Fri, Nov 6, 2020 at 5:11 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Thu, Oct 29, 2020 at 09:52:16AM -0400, Brian O'Keefe wrote: > > Add 024c:0627 to the list of SDIO device-ids, based on hardware found in > > the wild. This hardware exists on at least some Acer SW1-011 tablets. > > > > Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> > > Reviewed-by: Hans de Goede <hdegoede@redhat.com> > > --- > > drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > index 5b1392deb0a7..7256d55fcc1b 100644 > > --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c > > @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = > > { SDIO_DEVICE(0x024c, 0x0525), }, > > { SDIO_DEVICE(0x024c, 0x0623), }, > > { SDIO_DEVICE(0x024c, 0x0626), }, > > + { SDIO_DEVICE(0x024c, 0x0627), }, > > { SDIO_DEVICE(0x024c, 0xb723), }, > > { /* end: all zeroes */ }, > > }; > > -- > > 2.25.1 > > All of the tabs are gone in your email and it's only spaces, making this > patch impossible to apply :( > > Can you fix up your email client and resend this and keep Hans's > Reviewed-by on it? > > thanks, > > greg k-h Sure thing. Sorry about that; I figured out how to get it to send properly this time. A corrected patch is on its way.
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index 5b1392deb0a7..7256d55fcc1b 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -21,6 +21,7 @@ static const struct sdio_device_id sdio_ids[] = { SDIO_DEVICE(0x024c, 0x0525), }, { SDIO_DEVICE(0x024c, 0x0623), }, { SDIO_DEVICE(0x024c, 0x0626), }, + { SDIO_DEVICE(0x024c, 0x0627), }, { SDIO_DEVICE(0x024c, 0xb723), }, { /* end: all zeroes */ }, };
Add 024c:0627 to the list of SDIO device-ids, based on hardware found in the wild. This hardware exists on at least some Acer SW1-011 tablets. Signed-off-by: Brian O'Keefe <bokeefe@alum.wpi.edu> --- drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1