| Message ID | CAFXWsS8TnyA=PnLLL-QJzn00RDLfKwUZ_6XpsYPhd6eRSSKnnw@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Kalle Valo |
| Headers | show |
Hi, On 28-04-17 00:50, Ian W MORRISON wrote: > This patch is to remove the re-positioned call to kfree() in > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise > results in segmentation fault. > > Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au> Patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@redhat.com> Regards, Hans > --- > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > index f17f4fb..2ee9df5 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, > struct device *dev) > pwdev_priv->power_mgmt = true; > else > pwdev_priv->power_mgmt = false; > - kfree((u8 *)wdev); > > return ret; >
On Fri, Apr 28, 2017 at 08:50:05AM +1000, Ian W MORRISON wrote: > This patch is to remove the re-positioned call to kfree() in > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise > results in segmentation fault. > > Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au> > --- > drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > index f17f4fb..2ee9df5 100644 > --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c > @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, > struct device *dev) > pwdev_priv->power_mgmt = true; > else > pwdev_priv->power_mgmt = false; > - kfree((u8 *)wdev); > > return ret; > Patch has whitespace all turned into spaces :( Please fix up. thanks, greg k-h
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c index f17f4fb..2ee9df5 100644 --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -3527,7 +3527,6 @@ int rtw_wdev_alloc(struct adapter *padapter, struct device *dev) pwdev_priv->power_mgmt = true; else pwdev_priv->power_mgmt = false; - kfree((u8 *)wdev); return ret;
This patch is to remove the re-positioned call to kfree() in drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c which otherwise results in segmentation fault. Signed-off-by: Ian W Morrison <linuxium@linuxium.com.au> --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 1 - 1 file changed, 1 deletion(-)