| Message ID | CANUX_P0fLsNx+c7VnVggbZSGvnarF3inP7M115p-up3DfXyuuA@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sun, Apr 13, 2014 at 11:23 AM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: > On Sat, Apr 12, 2014 at 6:11 PM, Alexander Monakov <amonakov@gmail.com> wrote: >> Hello, >> >> On a laptop with Wireless-N 135 card and 3.14.0 kernel I'm getting a >> kernel oops on cold boot ans wireless seems unusable, but suprisingly >> everything works fine after a reboot: > > Wow - interesting - you are getting an interrupt before we even enable them. > > Does this help you? Yes, it did help. Thanks. (regarding interrupts, after installing an mSATA SSD that goes into the mini-PCIe slot next to the wireless card, I've noticed that "events" (mostly interrupts I guess) shown by PowerTop for the wireless card and the SATA controller seem correlated, even though the disk should be idle; I wonder what that means) Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Emmanuel, I'm curious about the plans w.r.t this fix; is it going to iwlwifi-next.git? Thanks again. On Sun, Apr 13, 2014 at 12:49 PM, Alexander Monakov <amonakov@gmail.com> wrote: > On Sun, Apr 13, 2014 at 11:23 AM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: >> On Sat, Apr 12, 2014 at 6:11 PM, Alexander Monakov <amonakov@gmail.com> wrote: >>> Hello, >>> >>> On a laptop with Wireless-N 135 card and 3.14.0 kernel I'm getting a >>> kernel oops on cold boot ans wireless seems unusable, but suprisingly >>> everything works fine after a reboot: >> >> Wow - interesting - you are getting an interrupt before we even enable them. >> >> Does this help you? > > Yes, it did help. Thanks. > > (regarding interrupts, after installing an mSATA SSD that goes into > the mini-PCIe slot next to the wireless card, I've noticed that > "events" (mostly interrupts I guess) shown by PowerTop for the > wireless card and the SATA controller seem correlated, even though the > disk should be idle; I wonder what that means) > > Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 04/17/2014 11:56 PM, Alexander Monakov wrote: > Emmanuel, > > I'm curious about the plans w.r.t this fix; is it going to > iwlwifi-next.git? Thanks again. > It will go to iwlwifi-fixes. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/18/2014 08:08 AM, Emmanuel Grumbach wrote: > Hi, > > On 04/17/2014 11:56 PM, Alexander Monakov wrote: >> Emmanuel, >> >> I'm curious about the plans w.r.t this fix; is it going to >> iwlwifi-next.git? Thanks again. >> > > It will go to iwlwifi-fixes. > I have to say that this is really strange - I must miss something. It looks like the ISR is called even before it is requested... So I definitely want to understand what is happening here before applying the fix. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 18, 2014 at 5:47 PM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: > > > On 04/18/2014 08:08 AM, Emmanuel Grumbach wrote: >> Hi, >> >> On 04/17/2014 11:56 PM, Alexander Monakov wrote: >>> Emmanuel, >>> >>> I'm curious about the plans w.r.t this fix; is it going to >>> iwlwifi-next.git? Thanks again. >>> >> >> It will go to iwlwifi-fixes. >> > > I have to say that this is really strange - I must miss something. It looks like the ISR is called even before it is requested... > So I definitely want to understand what is happening here before applying the fix. Sure, I can help with further investigation. Would it help if I bisected? Alexander -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 04/18/2014 05:34 PM, Alexander Monakov wrote: > On Fri, Apr 18, 2014 at 5:47 PM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: >> >> >> On 04/18/2014 08:08 AM, Emmanuel Grumbach wrote: >>> Hi, >>> >>> On 04/17/2014 11:56 PM, Alexander Monakov wrote: >>>> Emmanuel, >>>> >>>> I'm curious about the plans w.r.t this fix; is it going to >>>> iwlwifi-next.git? Thanks again. >>>> >>> >>> It will go to iwlwifi-fixes. >>> >> >> I have to say that this is really strange - I must miss something. It looks like the ISR is called even before it is requested... >> So I definitely want to understand what is happening here before applying the fix. > > Sure, I can help with further investigation. Would it help if I bisected? > I can't decline such an offer:) Note that the "bad" commit might be in pci too. As a first try, I'd try 3.13. I've made quite a few changes in the ISR for 3.14. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 18, 2014 at 6:50 PM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: >>> I have to say that this is really strange - I must miss something. It looks like the ISR is called even before it is requested... >>> So I definitely want to understand what is happening here before applying the fix. >> >> Sure, I can help with further investigation. Would it help if I bisected? >> > > I can't decline such an offer:) > > Note that the "bad" commit might be in pci too. > As a first try, I'd try 3.13. > I've made quite a few changes in the ISR for 3.14. It bisects to commit 2dbc368d7fded35ed221a3751405b15e06eb8925 Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Date: Mon Dec 9 11:09:47 2013 +0200 iwlwifi: pcie: track interrupt mask in SW -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, On 04/18/2014 11:33 PM, Alexander Monakov wrote: > On Fri, Apr 18, 2014 at 6:50 PM, Emmanuel Grumbach <egrumbach@gmail.com> wrote: >>>> I have to say that this is really strange - I must miss something. It looks like the ISR is called even before it is requested... >>>> So I definitely want to understand what is happening here before applying the fix. >>> >>> Sure, I can help with further investigation. Would it help if I bisected? >>> >> >> I can't decline such an offer:) >> >> Note that the "bad" commit might be in pci too. >> As a first try, I'd try 3.13. >> I've made quite a few changes in the ISR for 3.14. > > It bisects to > > commit 2dbc368d7fded35ed221a3751405b15e06eb8925 > Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > Date: Mon Dec 9 11:09:47 2013 +0200 > > iwlwifi: pcie: track interrupt mask in SW > Yeah - ok. Thank you for this information. I'll check again later. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlwifi/pcie/trans.c b/drivers/net/wireless/iwlwifi/pcie/trans.c index 37f7acc..bebab4e 100644 --- a/drivers/net/wireless/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/iwlwifi/pcie/trans.c @@ -1803,6 +1803,10 @@ struct iwl_trans *iwl_trans_pcie_alloc(struct pci_dev *pdev, * PCI Tx retries from interfering with C3 CPU state */ pci_write_config_byte(pdev, PCI_CFG_RETRY_TIMEOUT, 0x00); + trans->dev = &pdev->dev; + trans_pcie->pci_dev = pdev; + iwl_disable_interrupts(trans); + err = pci_enable_msi(pdev); if (err) {