| Message ID | CANUX_P2MSK_rUMyN2xa8A9dZwuPSKh+eiOr10KG6PocCQdVhvA@mail.gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Mon, May 19, 2014 at 01:40:34PM +0300, Emmanuel Grumbach wrote: > Hi, > > I need to disable a feature on 3.13 and 3.14. But I don't have any > patch upstream that I can point to as the patch that needs to be > backported. > We have a feature that is buggy in 3.13 and 3.14. We refactored (and > fixed) this feature in 3.15 but the refactor is really not stable > material, so basically, I can't backport the fix to 3.13 / 3.14. A > user reported that disabling the feature solved (part of) his issues: > https://bugzilla.kernel.org/show_bug.cgi?id=72601. > OTOH, I don't have any patch in linux.git that could be backported to > do what I want in 3.13 / 3.14 - i.e. disable the feature. > What is the right process here? I understand that this isn't covered > by the "stable rules". So what should I do here? Get the maintainer's approval to apply this patch and I can queue it up. > > FYI: this is the patch: > > commit 31e56634bea6ab23817faa069663af3103da0609 > Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > Date: Sun May 18 19:05:23 2014 +0300 > > iwlwifi: mvm: disable beacon filtering > > This feature has been causing trouble - disable it for now. > Fixes are available, but they are too big to be backported. > > https://bugzilla.kernel.org/show_bug.cgi?id=72601 > > Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Also, sending it in a format that I can apply it in would be nice :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/19/2014 10:41 PM, Greg KH wrote: > On Mon, May 19, 2014 at 01:40:34PM +0300, Emmanuel Grumbach wrote: >> Hi, >> >> I need to disable a feature on 3.13 and 3.14. But I don't have any >> patch upstream that I can point to as the patch that needs to be >> backported. >> We have a feature that is buggy in 3.13 and 3.14. We refactored (and >> fixed) this feature in 3.15 but the refactor is really not stable >> material, so basically, I can't backport the fix to 3.13 / 3.14. A >> user reported that disabling the feature solved (part of) his issues: >> https://bugzilla.kernel.org/show_bug.cgi?id=72601. >> OTOH, I don't have any patch in linux.git that could be backported to >> do what I want in 3.13 / 3.14 - i.e. disable the feature. >> What is the right process here? I understand that this isn't covered >> by the "stable rules". So what should I do here? > > Get the maintainer's approval to apply this patch and I can queue it up. Ok - thanks. It might be worthwhile to add this "exception path" in the Documentation :) > >> >> FYI: this is the patch: >> >> commit 31e56634bea6ab23817faa069663af3103da0609 >> Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> >> Date: Sun May 18 19:05:23 2014 +0300 >> >> iwlwifi: mvm: disable beacon filtering >> >> This feature has been causing trouble - disable it for now. >> Fixes are available, but they are too big to be backported. >> >> https://bugzilla.kernel.org/show_bug.cgi?id=72601 >> >> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> > > Also, sending it in a format that I can apply it in would be nice :) > :) Done. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, May 19, 2014 at 12:41:56PM -0700, Greg KH wrote: > On Mon, May 19, 2014 at 01:40:34PM +0300, Emmanuel Grumbach wrote: > > Hi, > > > > I need to disable a feature on 3.13 and 3.14. But I don't have any > > patch upstream that I can point to as the patch that needs to be > > backported. > > We have a feature that is buggy in 3.13 and 3.14. We refactored (and > > fixed) this feature in 3.15 but the refactor is really not stable > > material, so basically, I can't backport the fix to 3.13 / 3.14. A > > user reported that disabling the feature solved (part of) his issues: > > https://bugzilla.kernel.org/show_bug.cgi?id=72601. > > OTOH, I don't have any patch in linux.git that could be backported to > > do what I want in 3.13 / 3.14 - i.e. disable the feature. > > What is the right process here? I understand that this isn't covered > > by the "stable rules". So what should I do here? > > Get the maintainer's approval to apply this patch and I can queue it up. Seems ok to me.
On Mon, May 19, 2014 at 11:23:58PM +0300, Emmanuel Grumbach wrote: > > > On 05/19/2014 10:41 PM, Greg KH wrote: > > On Mon, May 19, 2014 at 01:40:34PM +0300, Emmanuel Grumbach wrote: > >> Hi, > >> > >> I need to disable a feature on 3.13 and 3.14. But I don't have any > >> patch upstream that I can point to as the patch that needs to be > >> backported. > >> We have a feature that is buggy in 3.13 and 3.14. We refactored (and > >> fixed) this feature in 3.15 but the refactor is really not stable > >> material, so basically, I can't backport the fix to 3.13 / 3.14. A > >> user reported that disabling the feature solved (part of) his issues: > >> https://bugzilla.kernel.org/show_bug.cgi?id=72601. > >> OTOH, I don't have any patch in linux.git that could be backported to > >> do what I want in 3.13 / 3.14 - i.e. disable the feature. > >> What is the right process here? I understand that this isn't covered > >> by the "stable rules". So what should I do here? > > > > Get the maintainer's approval to apply this patch and I can queue it up. > > Ok - thanks. It might be worthwhile to add this "exception path" in the Documentation :) No, it's such a rare exception, I don't want to "encourage" anyone to ever do it by documenting it. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/wireless/iwlwifi/mvm/mac80211.c b/drivers/net/wireless/iwlwifi/mvm/mac80211.c index cd6ea2e..17c097d 100644 --- a/drivers/net/wireless/iwlwifi/mvm/mac80211.c +++ b/drivers/net/wireless/iwlwifi/mvm/mac80211.c @@ -619,7 +619,7 @@ static int iwl_mvm_mac_add_interface(struct ieee80211_hw *hw, if (ret) goto out_remove_mac; - if (!mvm->bf_allowed_vif && + if (!mvm->bf_allowed_vif && false && vif->type == NL80211_IFTYPE_STATION && !vif->p2p && mvm->fw->ucode_capa.flags & IWL_UCODE_TLV_FLAGS_BF_UPDATED){
Hi, I need to disable a feature on 3.13 and 3.14. But I don't have any patch upstream that I can point to as the patch that needs to be backported. We have a feature that is buggy in 3.13 and 3.14. We refactored (and fixed) this feature in 3.15 but the refactor is really not stable material, so basically, I can't backport the fix to 3.13 / 3.14. A user reported that disabling the feature solved (part of) his issues: https://bugzilla.kernel.org/show_bug.cgi?id=72601. OTOH, I don't have any patch in linux.git that could be backported to do what I want in 3.13 / 3.14 - i.e. disable the feature. What is the right process here? I understand that this isn't covered by the "stable rules". So what should I do here? FYI: this is the patch: commit 31e56634bea6ab23817faa069663af3103da0609 Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> Date: Sun May 18 19:05:23 2014 +0300 iwlwifi: mvm: disable beacon filtering This feature has been causing trouble - disable it for now. Fixes are available, but they are too big to be backported. https://bugzilla.kernel.org/show_bug.cgi?id=72601 Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com> mvm->bf_allowed_vif = mvmvif; Emmanuel Grumbach egrumbach@gmail.com -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html