| Message ID | Pine.LNX.4.64.0909271708210.8927@sister.anvils (mailing list archive) |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Sun, 27 Sep 2009 17:14:04 +0100 (BST) Hugh Dickins <hugh.dickins@tiscali.co.uk> wrote: > On Sun, 27 Sep 2009, Arjan van de Ven wrote: > > > > With todays git my laptop fails to associate with my access point. > > Bisection points to the commit below, and reverting this one commit > > on the HEAD of tree also fixes the issue, so I'm pretty confident > > that this commit is to blame. > > > > I have a 4965 wifi card in my laptop, and the network I'm trying to > > connect to has no encryption. I'm running Fedora 11 as OS. > > > > I would like to kindly request for this commit to be reverted until > > a more permanent solution is found (I'm happy to test any patches).. > > > > 94f85853324e02c3a32bc3101f090dc9a3f512b4 is first bad commit > > commit 94f85853324e02c3a32bc3101f090dc9a3f512b4 > > Author: Johannes Berg <johannes@sipsolutions.net> > > Date: Thu Sep 17 17:15:31 2009 -0700 > > > > cfg80211: don't overwrite privacy setting > > > > When cfg80211 is instructed to connect, it always > > uses the default WEP key for the privacy setting, > > which clearly is wrong when using wpa_supplicant. > > Don't overwrite the setting, and rely on it being > > false when wpa_supplicant is not running, instead > > set it to true when we have keys. > > > > Signed-off-by: Johannes Berg <johannes@sipsolutions.net> > > Signed-off-by: John W. Linville <linville@tuxdriver.com> > > > > :040000 040000 27fb46273e88eefee373699eb7e3f2923ac0886b > > 9518ee3e52c8320613cc5eee5ac54aabf082432f M net > > I've a different problem with wireless that Johannes is investigating > for me on linux-wireless; but here's a patch that he pointed me to > along the way, didn't help my issue but I expect it will help yours... > > > Subject: cfg80211: don't set privacy w/o key > > When wpa_supplicant is used to connect to open networks, > it causes the wdev->wext.keys to point to key memory, but > that key memory is all empty. Only use privacy when there > is a default key to be used. indeed it does can we get this into mainline soon ? -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, 2009-09-27 at 20:45 +0200, Arjan van de Ven wrote: > > Subject: cfg80211: don't set privacy w/o key > > > > When wpa_supplicant is used to connect to open networks, > > it causes the wdev->wext.keys to point to key memory, but > > that key memory is all empty. Only use privacy when there > > is a default key to be used. > > > indeed it does > > can we get this into mainline soon ? John's on his way home I suppose. johannes
On Sun, Sep 27, 2009 at 08:46:39PM +0200, Johannes Berg wrote: > On Sun, 2009-09-27 at 20:45 +0200, Arjan van de Ven wrote: > > > > Subject: cfg80211: don't set privacy w/o key > > > > > > When wpa_supplicant is used to connect to open networks, > > > it causes the wdev->wext.keys to point to key memory, but > > > that key memory is all empty. Only use privacy when there > > > is a default key to be used. > > > > > > indeed it does > > > > can we get this into mainline soon ? > > John's on his way home I suppose. Yes, I'll get to it today -- sorry for the delays related to my travel! John
--- wireless-testing.orig/net/wireless/wext-sme.c 2009-09-24 08:51:14.000000000 +0200 +++ wireless-testing/net/wireless/wext-sme.c 2009-09-24 08:57:01.000000000 +0200 @@ -30,7 +30,8 @@ int cfg80211_mgd_wext_connect(struct cfg if (wdev->wext.keys) { wdev->wext.keys->def = wdev->wext.default_key; wdev->wext.keys->defmgmt = wdev->wext.default_mgmt_key; - wdev->wext.connect.privacy = true; + if (wdev->wext.default_key != -1) + wdev->wext.connect.privacy = true; } if (!wdev->wext.connect.ssid_len)