diff mbox series

wifi: mwifiex: fix loop iterator in mwifiex_update_ampdu_txwinsize()

Message ID Y+ERnaDaZD7RtLvX@kili (mailing list archive)
State Accepted
Commit 3cfb7df24cee0f5fdc4cc5d3176cab9aadfcb430
Delegated to: Kalle Valo
Headers show
Series wifi: mwifiex: fix loop iterator in mwifiex_update_ampdu_txwinsize() | expand

Commit Message

Dan Carpenter Feb. 6, 2023, 2:41 p.m. UTC
This code re-uses "i" to be the iterator for both the inside and outside
loops.  It means the outside loop will exit earlier than intended.

Fixes: d219b7eb3792 ("mwifiex: handle BT coex event to adjust Rx BA window size")
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
 drivers/net/wireless/marvell/mwifiex/11n.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Kalle Valo Feb. 13, 2023, 4:54 p.m. UTC | #1
Dan Carpenter <error27@gmail.com> wrote:

> This code re-uses "i" to be the iterator for both the inside and outside
> loops.  It means the outside loop will exit earlier than intended.
> 
> Fixes: d219b7eb3792 ("mwifiex: handle BT coex event to adjust Rx BA window size")
> Signed-off-by: Dan Carpenter <error27@gmail.com>

Patch applied to wireless-next.git, thanks.

3cfb7df24cee wifi: mwifiex: fix loop iterator in mwifiex_update_ampdu_txwinsize()
diff mbox series

Patch

diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c
index 4af57e6d4393..90e401100898 100644
--- a/drivers/net/wireless/marvell/mwifiex/11n.c
+++ b/drivers/net/wireless/marvell/mwifiex/11n.c
@@ -878,7 +878,7 @@  mwifiex_send_delba_txbastream_tbl(struct mwifiex_private *priv, u8 tid)
  */
 void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
 {
-	u8 i;
+	u8 i, j;
 	u32 tx_win_size;
 	struct mwifiex_private *priv;
 
@@ -909,8 +909,8 @@  void mwifiex_update_ampdu_txwinsize(struct mwifiex_adapter *adapter)
 		if (tx_win_size != priv->add_ba_param.tx_win_size) {
 			if (!priv->media_connected)
 				continue;
-			for (i = 0; i < MAX_NUM_TID; i++)
-				mwifiex_send_delba_txbastream_tbl(priv, i);
+			for (j = 0; j < MAX_NUM_TID; j++)
+				mwifiex_send_delba_txbastream_tbl(priv, j);
 		}
 	}
 }