diff mbox series

wifi: mac80211: potential NULL dereference in ieee80211_tx_control_port()

Message ID YuKcTAyO94YOy0Bu@kili (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series wifi: mac80211: potential NULL dereference in ieee80211_tx_control_port() | expand

Commit Message

Dan Carpenter July 28, 2022, 2:25 p.m. UTC 
The ieee80211_lookup_ra_sta() function will sometimes set "sta" to NULL
so add this NULL check to prevent an Oops.

Fixes: 9dd1953846c7 ("wifi: nl80211/mac80211: clarify link ID in control port TX")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
 net/mac80211/tx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 45df9932d0ba..fd7e7dd66efc 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -5899,7 +5899,7 @@  int ieee80211_tx_control_port(struct wiphy *wiphy, struct net_device *dev,
 		 * for MLO STA, the SA should be the AP MLD address, but
 		 * the link ID has been selected already
 		 */
-		if (sta->sta.mlo)
+		if (sta && sta->sta.mlo)
 			memcpy(ehdr->h_source, sdata->vif.addr, ETH_ALEN);
 	}
 	rcu_read_unlock();