diff mbox series

dt-bindings: leds: Document Bluetooth and WLAN triggers

Message ID a85c256af01f64389a078c2b37c3b72a27d97536.1668005062.git.geert+renesas@glider.be (mailing list archive)
State Not Applicable
Delegated to: Johannes Berg
Headers show
Series dt-bindings: leds: Document Bluetooth and WLAN triggers | expand

Commit Message

Geert Uytterhoeven Nov. 9, 2022, 2:46 p.m. UTC
Add the missing trigger patterns for Bluetooth and WLAN activity, which
are already in active use.

While at it, move the mmc pattern comment where it belongs, and restore
alphabetical sort order.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'hci0-power' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
	'phy0tx' does not match '^mmc[0-9]+$'
	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
---
 Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Krzysztof Kozlowski Jan. 20, 2023, 4:39 p.m. UTC | #1
On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> Add the missing trigger patterns for Bluetooth and WLAN activity, which
> are already in active use.
> 
> While at it, move the mmc pattern comment where it belongs, and restore
> alphabetical sort order.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'hci0-power' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> 	'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> 	'phy0tx' does not match '^mmc[0-9]+$'
> 	From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml

This patch got lost... Rob, Lee or Pavel, can you pick it up?

It's with Rob's approval:
https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/

> ---
>  Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> index f5c57a580078ea23..d34bb58c00371402 100644
> --- a/Documentation/devicetree/bindings/leds/common.yaml
> +++ b/Documentation/devicetree/bindings/leds/common.yaml
> @@ -98,9 +98,13 @@ properties:
>              # LED alters the brightness for the specified duration with one software
>              # timer (requires "led-pattern" property)
>            - pattern
> -        # LED is triggered by SD/MMC activity
> -      - pattern: "^mmc[0-9]+$"
>        - pattern: "^cpu[0-9]*$"
> +      - pattern: "^hci[0-9]+-power$"
> +        # LED is triggered by Bluetooth activity
> +      - pattern: "^mmc[0-9]+$"
> +        # LED is triggered by SD/MMC activity
> +      - pattern: "^phy[0-9]+tx$"
> +        # LED is triggered by WLAN activity
>  
>    led-pattern:
>      description: |

Best regards,
Krzysztof
Luiz Augusto von Dentz Jan. 20, 2023, 9:28 p.m. UTC | #2
Hi Krzysztof,

On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > are already in active use.
> >
> > While at it, move the mmc pattern comment where it belongs, and restore
> > alphabetical sort order.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> >       'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> >       'hci0-power' does not match '^mmc[0-9]+$'
> >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> >       'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> >       'phy0tx' does not match '^mmc[0-9]+$'
> >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
>
> This patch got lost... Rob, Lee or Pavel, can you pick it up?
>
> It's with Rob's approval:
> https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/

If it is going to be applied via bluetooth-next make sure to resend it
since last time our CI was not able to apply it thus why we didn't
apply it in the first place.

>
> > ---
> >  Documentation/devicetree/bindings/leds/common.yaml | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
> > index f5c57a580078ea23..d34bb58c00371402 100644
> > --- a/Documentation/devicetree/bindings/leds/common.yaml
> > +++ b/Documentation/devicetree/bindings/leds/common.yaml
> > @@ -98,9 +98,13 @@ properties:
> >              # LED alters the brightness for the specified duration with one software
> >              # timer (requires "led-pattern" property)
> >            - pattern
> > -        # LED is triggered by SD/MMC activity
> > -      - pattern: "^mmc[0-9]+$"
> >        - pattern: "^cpu[0-9]*$"
> > +      - pattern: "^hci[0-9]+-power$"
> > +        # LED is triggered by Bluetooth activity
> > +      - pattern: "^mmc[0-9]+$"
> > +        # LED is triggered by SD/MMC activity
> > +      - pattern: "^phy[0-9]+tx$"
> > +        # LED is triggered by WLAN activity
> >
> >    led-pattern:
> >      description: |
>
> Best regards,
> Krzysztof
>
Geert Uytterhoeven Jan. 22, 2023, 10:48 a.m. UTC | #3
On Fri, Jan 20, 2023 at 10:42 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
> >
> > On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > are already in active use.
> > >
> > > While at it, move the mmc pattern comment where it belongs, and restore
> > > alphabetical sort order.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > >       'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > >       'hci0-power' does not match '^mmc[0-9]+$'
> > >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > >       'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > >       'phy0tx' does not match '^mmc[0-9]+$'
> > >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> >
> > This patch got lost... Rob, Lee or Pavel, can you pick it up?
> >
> > It's with Rob's approval:
> > https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
>
> If it is going to be applied via bluetooth-next make sure to resend it
> since last time our CI was not able to apply it thus why we didn't
> apply it in the first place.

Resent as v2, https://lore.kernel.org/r/0d0de1bc949d24e08174205c13c0b59bd73c1ea8.1674384302.git.geert+renesas@glider.be

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Geert Uytterhoeven Jan. 22, 2023, 11:32 a.m. UTC | #4
Hi Luiz,

On Sun, Jan 22, 2023 at 11:48 AM Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Jan 20, 2023 at 10:42 PM Luiz Augusto von Dentz
> <luiz.dentz@gmail.com> wrote:
> > On Fri, Jan 20, 2023 at 8:42 AM Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> > > On 09/11/2022 15:46, Geert Uytterhoeven wrote:
> > > > Add the missing trigger patterns for Bluetooth and WLAN activity, which
> > > > are already in active use.
> > > >
> > > > While at it, move the mmc pattern comment where it belongs, and restore
> > > > alphabetical sort order.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: bt_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > >       'hci0-power' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > >       'hci0-power' does not match '^mmc[0-9]+$'
> > > >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > > > arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-rev2.dtb: leds: wlan_active_led:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
> > > >       'phy0tx' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'ide-disk', 'timer', 'pattern']
> > > >       'phy0tx' does not match '^mmc[0-9]+$'
> > > >       From schema: Documentation/devicetree/bindings/leds/leds-gpio.yaml
> > >
> > > This patch got lost... Rob, Lee or Pavel, can you pick it up?
> > >
> > > It's with Rob's approval:
> > > https://lore.kernel.org/all/166861772609.231295.14812410099261417331.robh@kernel.org/
> >
> > If it is going to be applied via bluetooth-next make sure to resend it
> > since last time our CI was not able to apply it thus why we didn't
> > apply it in the first place.
>
> Resent as v2, https://lore.kernel.org/r/0d0de1bc949d24e08174205c13c0b59bd73c1ea8.1674384302.git.geert+renesas@glider.be

According to your CI, it still does not apply.
However, there are no changes to
Documentation/devicetree/bindings/leds/leds-gpio.yaml
between v6.2-rc1 and next-20230120.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/leds/common.yaml b/Documentation/devicetree/bindings/leds/common.yaml
index f5c57a580078ea23..d34bb58c00371402 100644
--- a/Documentation/devicetree/bindings/leds/common.yaml
+++ b/Documentation/devicetree/bindings/leds/common.yaml
@@ -98,9 +98,13 @@  properties:
             # LED alters the brightness for the specified duration with one software
             # timer (requires "led-pattern" property)
           - pattern
-        # LED is triggered by SD/MMC activity
-      - pattern: "^mmc[0-9]+$"
       - pattern: "^cpu[0-9]*$"
+      - pattern: "^hci[0-9]+-power$"
+        # LED is triggered by Bluetooth activity
+      - pattern: "^mmc[0-9]+$"
+        # LED is triggered by SD/MMC activity
+      - pattern: "^phy[0-9]+tx$"
+        # LED is triggered by WLAN activity
 
   led-pattern:
     description: |