diff mbox series

[1/2] wifi: rtl8xxxu: Print the ROM version too

Message ID add46396-95af-1164-2033-7d4eb4d0b554@gmail.com (mailing list archive)
State Accepted
Commit aa1a49268951753837923eeb869269b08b8025d2
Delegated to: Kalle Valo
Headers show
Series [1/2] wifi: rtl8xxxu: Print the ROM version too | expand

Commit Message

Bitterblue Smith Jan. 10, 2023, 3:41 p.m. UTC
Make rtl8xxxu_print_chipinfo() print the ROM version. This is relevant
at least for the RTL8723AU and possibly relevant for the RTL8710BU.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Ping-Ke Shih Jan. 11, 2023, 1:09 a.m. UTC | #1
> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Tuesday, January 10, 2023 11:42 PM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>; Ping-Ke Shih <pkshih@realtek.com>
> Subject: [PATCH 1/2] wifi: rtl8xxxu: Print the ROM version too
> 
> Make rtl8xxxu_print_chipinfo() print the ROM version. This is relevant
> at least for the RTL8723AU and possibly relevant for the RTL8710BU.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> index fd97c040948a..d521435e1c07 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
> @@ -1582,10 +1582,11 @@ static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
>  		cut = 'A' + priv->chip_cut;
> 
>  	dev_info(dev,
> -		 "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
> -		 priv->chip_name, cut, priv->chip_vendor, priv->tx_paths,
> -		 priv->rx_paths, priv->ep_tx_count, priv->has_wifi,
> -		 priv->has_bluetooth, priv->has_gps, priv->hi_pa);
> +		 "RTL%s rev %c (%s) romver %d, %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
> +		 priv->chip_name, cut, priv->chip_vendor, priv->rom_rev,
> +		 priv->tx_paths, priv->rx_paths, priv->ep_tx_count,
> +		 priv->has_wifi, priv->has_bluetooth, priv->has_gps,
> +		 priv->hi_pa);
> 
>  	dev_info(dev, "RTL%s MAC: %pM\n", priv->chip_name, priv->mac_addr);
>  }
> --
> 2.38.0
> 
> ------Please consider the environment before printing this e-mail.
Kalle Valo Jan. 16, 2023, 4:28 p.m. UTC | #2
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

> Make rtl8xxxu_print_chipinfo() print the ROM version. This is relevant
> at least for the RTL8723AU and possibly relevant for the RTL8710BU.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

2 patches applied to wireless-next.git, thanks.

aa1a49268951 wifi: rtl8xxxu: Print the ROM version too
de7d0ff301fc wifi: rtl8xxxu: Dump the efuse only for untested devices
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
index fd97c040948a..d521435e1c07 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
@@ -1582,10 +1582,11 @@  static void rtl8xxxu_print_chipinfo(struct rtl8xxxu_priv *priv)
 		cut = 'A' + priv->chip_cut;
 
 	dev_info(dev,
-		 "RTL%s rev %c (%s) %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
-		 priv->chip_name, cut, priv->chip_vendor, priv->tx_paths,
-		 priv->rx_paths, priv->ep_tx_count, priv->has_wifi,
-		 priv->has_bluetooth, priv->has_gps, priv->hi_pa);
+		 "RTL%s rev %c (%s) romver %d, %iT%iR, TX queues %i, WiFi=%i, BT=%i, GPS=%i, HI PA=%i\n",
+		 priv->chip_name, cut, priv->chip_vendor, priv->rom_rev,
+		 priv->tx_paths, priv->rx_paths, priv->ep_tx_count,
+		 priv->has_wifi, priv->has_bluetooth, priv->has_gps,
+		 priv->hi_pa);
 
 	dev_info(dev, "RTL%s MAC: %pM\n", priv->chip_name, priv->mac_addr);
 }