diff mbox series

[v2,3/3] wifi: rtl8xxxu: Rename rtl8xxxu_8188f_channel_to_group

Message ID ba8e3ea2-74f5-e1db-296e-4ae5f03084dc@gmail.com (mailing list archive)
State Accepted
Commit e948023d5fc8e4a5e79e5ded53c2a1d1d7041ee6
Delegated to: Kalle Valo
Headers show
Series [v2,1/3] wifi: rtl8xxxu: Move burst init to a function | expand

Commit Message

Bitterblue Smith Nov. 5, 2022, 10:54 p.m. UTC
This name is an anomaly. Change it to rtl8188f_channel_to_group to
follow the same pattern as the other functions.

Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
---
v2:
 - No change.
---
 drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Ping-Ke Shih Nov. 7, 2022, 6:52 a.m. UTC | #1
> -----Original Message-----
> From: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> Sent: Sunday, November 6, 2022 6:55 AM
> To: linux-wireless@vger.kernel.org
> Cc: Jes Sorensen <Jes.Sorensen@gmail.com>
> Subject: [PATCH v2 3/3] wifi: rtl8xxxu: Rename rtl8xxxu_8188f_channel_to_group
> 
> This name is an anomaly. Change it to rtl8188f_channel_to_group to
> follow the same pattern as the other functions.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>

Reviewed-by: Ping-Ke Shih <pkshih@realtek.com>

> ---
> v2:
>  - No change.
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> index 4d044a8baa30..0f77312dd0ca 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> @@ -352,7 +352,7 @@ static int rtl8188fu_identify_chip(struct rtl8xxxu_priv *priv)
>  	return ret;
>  }
> 
> -static void rtl8xxxu_8188f_channel_to_group(int channel, int *group, int *cck_group)
> +static void rtl8188f_channel_to_group(int channel, int *group, int *cck_group)
>  {
>  	if (channel < 3)
>  		*group = 0;
> @@ -378,7 +378,7 @@ rtl8188f_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40)
>  	u8 cck, ofdmbase, mcsbase;
>  	int group, cck_group;
> 
> -	rtl8xxxu_8188f_channel_to_group(channel, &group, &cck_group);
> +	rtl8188f_channel_to_group(channel, &group, &cck_group);
> 
>  	cck = priv->cck_tx_power_index_A[cck_group];
> 
> --
> 2.38.0
> 
> ------Please consider the environment before printing this e-mail.
Jes Sorensen Nov. 8, 2022, 1:55 p.m. UTC | #2
On 11/5/22 18:54, Bitterblue Smith wrote:
> This name is an anomaly. Change it to rtl8188f_channel_to_group to
> follow the same pattern as the other functions.
> 
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> v2:
>  - No change.
> ---
>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Jes Sorensen <jes@trained-monkey.org>

> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> index 4d044a8baa30..0f77312dd0ca 100644
> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
> @@ -352,7 +352,7 @@ static int rtl8188fu_identify_chip(struct rtl8xxxu_priv *priv)
>  	return ret;
>  }
>  
> -static void rtl8xxxu_8188f_channel_to_group(int channel, int *group, int *cck_group)
> +static void rtl8188f_channel_to_group(int channel, int *group, int *cck_group)
>  {
>  	if (channel < 3)
>  		*group = 0;
> @@ -378,7 +378,7 @@ rtl8188f_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40)
>  	u8 cck, ofdmbase, mcsbase;
>  	int group, cck_group;
>  
> -	rtl8xxxu_8188f_channel_to_group(channel, &group, &cck_group);
> +	rtl8188f_channel_to_group(channel, &group, &cck_group);
>  
>  	cck = priv->cck_tx_power_index_A[cck_group];
>
diff mbox series

Patch

diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
index 4d044a8baa30..0f77312dd0ca 100644
--- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
+++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8188f.c
@@ -352,7 +352,7 @@  static int rtl8188fu_identify_chip(struct rtl8xxxu_priv *priv)
 	return ret;
 }
 
-static void rtl8xxxu_8188f_channel_to_group(int channel, int *group, int *cck_group)
+static void rtl8188f_channel_to_group(int channel, int *group, int *cck_group)
 {
 	if (channel < 3)
 		*group = 0;
@@ -378,7 +378,7 @@  rtl8188f_set_tx_power(struct rtl8xxxu_priv *priv, int channel, bool ht40)
 	u8 cck, ofdmbase, mcsbase;
 	int group, cck_group;
 
-	rtl8xxxu_8188f_channel_to_group(channel, &group, &cck_group);
+	rtl8188f_channel_to_group(channel, &group, &cck_group);
 
 	cck = priv->cck_tx_power_index_A[cck_group];