| Message ID | cd2735a40da7f4fcc5323e3fca3775e7b5402ece.camel@freebox.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75a7062e533e309a9ca0812c69f3ac3cefadb8b1 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | ath10k: fix misreported tx bandwidth for 160Mhz | expand |
Maxime Bizon <mbizon@freebox.fr> writes: > Because of this missing switch case, 160Mhz transmit was reported as > 20Mhz, leading to wrong airtime calculation and AQL limiting max > throughput. > > Signed-off-by: Maxime Bizon <mbizon@freebox.fr> On what ath10k hardware and afirmware version did you test this? I can add that to the commit log.
On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote: Hello Kalle, > On what ath10k hardware and afirmware version did you test this? I > can add that to the commit log. > QCA9984 10.4-3.10-00047
Maxime Bizon <mbizon@freebox.fr> writes: > On Mon, 2022-05-16 at 19:11 +0300, Kalle Valo wrote: > >> On what ath10k hardware and afirmware version did you test this? I >> can add that to the commit log. >> > > QCA9984 > 10.4-3.10-00047 Thanks, I added that in the pending branch.
Maxime Bizon <mbizon@freebox.fr> wrote: > Because of this missing switch case, 160Mhz transmit was reported as > 20Mhz, leading to wrong airtime calculation and AQL limiting max > throughput. > > Tested-on: QCA9984 hw2.0 PCI 10.4-3.10-00047 > > Signed-off-by: Maxime Bizon <mbizon@freebox.fr> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com> Patch applied to ath-next branch of ath.git, thanks. 75a7062e533e ath10k: fix misreported tx bandwidth for 160Mhz
diff --git a/drivers/net/wireless/ath/ath10k/htt_rx.c b/drivers/net/wireless/ath/ath10k/htt_rx.c index 771252dd6d4e..e8727c0b0171 100644 --- a/drivers/net/wireless/ath/ath10k/htt_rx.c +++ b/drivers/net/wireless/ath/ath10k/htt_rx.c @@ -3884,6 +3884,10 @@ ath10k_update_per_peer_tx_stats(struct ath10k *ar, arsta->tx_info.status.rates[0].flags |= IEEE80211_TX_RC_80_MHZ_WIDTH; break; + case RATE_INFO_BW_160: + arsta->tx_info.status.rates[0].flags |= + IEEE80211_TX_RC_160_MHZ_WIDTH; + break; } if (peer_stats->succ_pkts) {
Because of this missing switch case, 160Mhz transmit was reported as 20Mhz, leading to wrong airtime calculation and AQL limiting max throughput. Signed-off-by: Maxime Bizon <mbizon@freebox.fr> --- drivers/net/wireless/ath/ath10k/htt_rx.c | 4 ++++ 1 file changed, 4 insertions(+)