diff mbox series

wifi: plfxlc: check for allocation failure in plfxlc_usb_wreq_async()

Message ID e8d4a19a-f251-4101-a89b-607345e938cb@moroto.mountain (mailing list archive)
State Accepted
Commit 40018a8fa9aa63ca5b26e803502138158fb0ff96
Delegated to: Kalle Valo
Headers show
Series wifi: plfxlc: check for allocation failure in plfxlc_usb_wreq_async() | expand

Commit Message

Dan Carpenter Oct. 30, 2023, 9:03 a.m. UTC
Check for if the usb_alloc_urb() failed.

Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
 drivers/net/wireless/purelifi/plfxlc/usb.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Kalle Valo Nov. 8, 2023, 6:06 p.m. UTC | #1
Dan Carpenter <dan.carpenter@linaro.org> wrote:

> Check for if the usb_alloc_urb() failed.
> 
> Fixes: 68d57a07bfe5 ("wireless: add plfxlc driver for pureLiFi X, XL, XC devices")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Patch applied to wireless-next.git, thanks.

40018a8fa9aa wifi: plfxlc: check for allocation failure in plfxlc_usb_wreq_async()
diff mbox series

Patch

diff --git a/drivers/net/wireless/purelifi/plfxlc/usb.c b/drivers/net/wireless/purelifi/plfxlc/usb.c
index 76d0a778636a..311676c1ece0 100644
--- a/drivers/net/wireless/purelifi/plfxlc/usb.c
+++ b/drivers/net/wireless/purelifi/plfxlc/usb.c
@@ -493,9 +493,12 @@  int plfxlc_usb_wreq_async(struct plfxlc_usb *usb, const u8 *buffer,
 			  void *context)
 {
 	struct usb_device *udev = interface_to_usbdev(usb->ez_usb);
-	struct urb *urb = usb_alloc_urb(0, GFP_ATOMIC);
+	struct urb *urb;
 	int r;
 
+	urb = usb_alloc_urb(0, GFP_ATOMIC);
+	if (!urb)
+		return -ENOMEM;
 	usb_fill_bulk_urb(urb, udev, usb_sndbulkpipe(udev, EP_DATA_OUT),
 			  (void *)buffer, buffer_len, complete_fn, context);