diff mbox series

[1/8] iwlwifi: mvm: reduce the print severity of failing getting NIC temp

Message ID iwlwifi.20210210172142.dfd423b2b2ef.Icd576dc3e2e7174d3ed9c1c32f48ea0013699e72@changeid (mailing list archive)
State Accepted
Commit c61734a69caf5df8cc51d1742aa55b63b1f1e957
Delegated to: Luca Coelho
Headers show
Series iwlwifi: updates intended for v5.12 2021-02-10 part 2 | expand

Commit Message

Luca Coelho Feb. 10, 2021, 3:23 p.m. UTC 
From: Golan Ben Ami <golan.ben.ami@intel.com>

Currently, for all devices and families, failing getting the temp
from the fw is indicated in the log as ERR.
This is too severe for two reasons:
1. The driver has a fall back - and schedules the next temp
read immediately after failing to read temp from the fw.
2. The temp read implementation in the fw is different between
HWs, and on older devices the flow is a-sync and may timeout.

Reducing the print severity from ERR to WARN will allow to
track the issue if it will appear many times, but not frighten users
if it appears once.

Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luca Coelho Feb. 10, 2021, 11:57 p.m. UTC | #1 
Luca Coelho <luca@coelho.fi> wrote:

> From: Golan Ben Ami <golan.ben.ami@intel.com>
> 
> Currently, for all devices and families, failing getting the temp
> from the fw is indicated in the log as ERR.
> This is too severe for two reasons:
> 1. The driver has a fall back - and schedules the next temp
> read immediately after failing to read temp from the fw.
> 2. The temp read implementation in the fw is different between
> HWs, and on older devices the flow is a-sync and may timeout.
> 
> Reducing the print severity from ERR to WARN will allow to
> track the issue if it will appear many times, but not frighten users
> if it appears once.
> 
> Signed-off-by: Golan Ben Ami <golan.ben.ami@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>

6 patches applied to iwlwifi-next.git, thanks.

c61734a69caf iwlwifi: mvm: reduce the print severity of failing getting NIC temp
11dd729afa48 iwlwifi: mvm: global PM mode does not reset after FW crash
4a81598f0f39 iwlwifi: pnvm: set the PNVM again if it was already loaded
25df65ae8a92 iwlwifi: pcie: define FW_RESET_TIMEOUT for clarity
ff11a8ee2d2d iwlwifi: pnvm: increment the pointer before checking the TLV
cdda18fbbefa iwlwifi: pnvm: move file loading code to a separate function
diff mbox series

Patch

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
index 790bc68a515a..2a7339b12b13 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
@@ -261,7 +261,7 @@  int iwl_mvm_get_temp(struct iwl_mvm *mvm, s32 *temp)
 	ret = iwl_wait_notification(&mvm->notif_wait, &wait_temp_notif,
 				    IWL_MVM_TEMP_NOTIF_WAIT_TIMEOUT);
 	if (ret)
-		IWL_ERR(mvm, "Getting the temperature timed out\n");
+		IWL_WARN(mvm, "Getting the temperature timed out\n");
 
 	return ret;
 }