diff mbox series

[09/14] mac80211: mlme: add documentation from spec to code

Message ID iwlwifi.20220202104617.f1bafd0861b7.I566612d99bca5245dc06cbcc70369b94a525389c@changeid (mailing list archive)
State Accepted
Delegated to: Johannes Berg
Headers show
Series cfg80211/mac80211 patches from our internal tree 2022-02-02 | expand

Commit Message

Luca Coelho Feb. 2, 2022, 8:49 a.m. UTC 
From: Mordechay Goodstein <mordechay.goodstein@intel.com>

Reference the spec why we decline HE support in
case STA don't support all HE basic rates recurred by AP.

Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 net/mac80211/mlme.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Jeff Johnson Feb. 8, 2022, 10:45 p.m. UTC | #1 
On 2/2/2022 12:49 AM, Luca Coelho wrote:
> From: Mordechay Goodstein <mordechay.goodstein@intel.com>
> 
> Reference the spec why we decline HE support in
> case STA don't support all HE basic rates recurred by AP.
> 
> Signed-off-by: Mordechay Goodstein <mordechay.goodstein@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
> ---
>   net/mac80211/mlme.c | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
> index 291226a1599d..bf777943cacd 100644
> --- a/net/mac80211/mlme.c
> +++ b/net/mac80211/mlme.c
> @@ -5052,7 +5052,15 @@ ieee80211_verify_sta_he_mcs_support(struct ieee80211_sub_if_data *sdata,
>   
>   			/*
>   			 * Make sure the HE AP doesn't require MCSs that aren't
> -			 * supported by the client
> +			 * supported by the client as required by spec
> +			 *
> +			 * P802.11-REVme/D0.3

curious why you reference a draft spec instead of referencing the 
approved IEEE Std 802.11ax™-2021

> +			 * 26.17.1 Basic HE BSS operation
> +			 *
> +			 * An HE STA shall not attempt to join * (MLME-JOIN.request primitive)
> +			 * a BSS, unless it supports (i.e., is able to both transmit and
> +			 * receive using) all of the <HE-MCS, NSS> tuples in the basic
> +			 * HE-MCS and NSS set.
>   			 */
>   			if (sta_rx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||
>   			    sta_tx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||
diff mbox series

Patch

diff --git a/net/mac80211/mlme.c b/net/mac80211/mlme.c
index 291226a1599d..bf777943cacd 100644
--- a/net/mac80211/mlme.c
+++ b/net/mac80211/mlme.c
@@ -5052,7 +5052,15 @@  ieee80211_verify_sta_he_mcs_support(struct ieee80211_sub_if_data *sdata,
 
 			/*
 			 * Make sure the HE AP doesn't require MCSs that aren't
-			 * supported by the client
+			 * supported by the client as required by spec
+			 *
+			 * P802.11-REVme/D0.3
+			 * 26.17.1 Basic HE BSS operation
+			 *
+			 * An HE STA shall not attempt to join * (MLME-JOIN.request primitive)
+			 * a BSS, unless it supports (i.e., is able to both transmit and
+			 * receive using) all of the <HE-MCS, NSS> tuples in the basic
+			 * HE-MCS and NSS set.
 			 */
 			if (sta_rx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||
 			    sta_tx_val == IEEE80211_HE_MCS_NOT_SUPPORTED ||