[v2,0/3] can: ctucanfd: hardware rx timestamps reporting

Message

Matej Vasilevski Aug. 1, 2022, 6:46 p.m. UTC

Hello,

this is the v2 patch for CTU CAN FD hardware timestamps reporting.

This patch series is based on the latest net-next, as I need the patch
- 9e7c9b8eb719 can: ctucanfd: Update CTU CAN FD IP core registers to match version 3.x.
and the patch below to avoid git conflict (both this and my patch
introduce ethtool_ops)
- 409c188c57cd can: tree-wide: advertise software timestamping capabilities

Changes in v2: (compared to the RFC I've sent in May)
- Removed kconfig option to enable/disable timestamps.
- Removed dt parameters ts-frequency and ts-used-bits. Now the user
  only needs to add the timestamping clock phandle to clocks, and even
  that is optional.
- Added SIOCSHWTSTAMP ioctl to enable/disable timestamps.
- Adressed comments from the RFC review.

Matej Vasilevski (3):
  can: ctucanfd: add HW timestamps to RX and error CAN frames
  dt-bindings: can: ctucanfd: add another clock for HW timestamping
  doc: ctucanfd: RX frames timestamping for platform devices

 .../bindings/net/can/ctu,ctucanfd.yaml        |  23 +-
 .../can/ctu/ctucanfd-driver.rst               |  13 +-
 drivers/net/can/ctucanfd/Makefile             |   2 +-
 drivers/net/can/ctucanfd/ctucanfd.h           |  20 ++
 drivers/net/can/ctucanfd/ctucanfd_base.c      | 214 +++++++++++++++++-
 drivers/net/can/ctucanfd/ctucanfd_timestamp.c |  87 +++++++
 6 files changed, 345 insertions(+), 14 deletions(-)
 create mode 100644 drivers/net/can/ctucanfd/ctucanfd_timestamp.c


base-commit: 0a324c3263f1e456f54dd8dc8ce58575aea776bc

Comments

Marc Kleine-Budde Aug. 2, 2022, 7:06 a.m. UTC | #1

On 01.08.2022 20:46:53, Matej Vasilevski wrote:
> Hello,
> 
> this is the v2 patch for CTU CAN FD hardware timestamps reporting.
> 
> This patch series is based on the latest net-next, as I need the patch
> - 9e7c9b8eb719 can: ctucanfd: Update CTU CAN FD IP core registers to match version 3.x.
> and the patch below to avoid git conflict (both this and my patch
> introduce ethtool_ops)
> - 409c188c57cd can: tree-wide: advertise software timestamping capabilities
> 
> Changes in v2: (compared to the RFC I've sent in May)

Please add a link to the RFC here:
https://lore.kernel.org/all/[e-mail]

> - Removed kconfig option to enable/disable timestamps.
> - Removed dt parameters ts-frequency and ts-used-bits. Now the user
>   only needs to add the timestamping clock phandle to clocks, and even
>   that is optional.
> - Added SIOCSHWTSTAMP ioctl to enable/disable timestamps.
> - Adressed comments from the RFC review.
> 
> Matej Vasilevski (3):
>   can: ctucanfd: add HW timestamps to RX and error CAN frames
>   dt-bindings: can: ctucanfd: add another clock for HW timestamping
>   doc: ctucanfd: RX frames timestamping for platform devices

Please reorder your patches so that the dt-bindings update comes first.

regards,
Marc