| Message ID | 20220921140524.3831101-8-yangyingliang@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 3525ecc127d893f99671df041764aa4185c79e0b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: dsa: remove unnecessary set_drvdata() | expand |
On Wed, 2022-09-21 at 22:05 +0800, Yang Yingliang wrote: > Remove unnecessary set_drvdata(NULL) function in ->remove(), > the driver_data will be set to NULL in device_unbind_cleanup() > after calling ->remove(). Do we need to remove i2c_set_clientdata(i2c, NULL) in ksz9477_i2c.c or is it applicable only spi and mdio bus. > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> > --- > drivers/net/dsa/microchip/ksz8863_smi.c | 2 -- > drivers/net/dsa/microchip/ksz_spi.c | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/dsa/microchip/ksz8863_smi.c > b/drivers/net/dsa/microchip/ksz8863_smi.c > index 5247fdfb964d..ddb40838181e 100644 > --- a/drivers/net/dsa/microchip/ksz8863_smi.c > +++ b/drivers/net/dsa/microchip/ksz8863_smi.c > @@ -180,8 +180,6 @@ static void ksz8863_smi_remove(struct mdio_device > *mdiodev) > > if (dev) > ksz_switch_remove(dev); > - > - dev_set_drvdata(&mdiodev->dev, NULL); > } > > static void ksz8863_smi_shutdown(struct mdio_device *mdiodev) > diff --git a/drivers/net/dsa/microchip/ksz_spi.c > b/drivers/net/dsa/microchip/ksz_spi.c > index 82e2352f55fa..1b6ab891b986 100644 > --- a/drivers/net/dsa/microchip/ksz_spi.c > +++ b/drivers/net/dsa/microchip/ksz_spi.c > @@ -107,8 +107,6 @@ static void ksz_spi_remove(struct spi_device > *spi) > > if (dev) > ksz_switch_remove(dev); > - > - spi_set_drvdata(spi, NULL); > } > > static void ksz_spi_shutdown(struct spi_device *spi) >
Hi, On 2022/9/22 22:12, Arun.Ramadoss@microchip.com wrote: > On Wed, 2022-09-21 at 22:05 +0800, Yang Yingliang wrote: >> Remove unnecessary set_drvdata(NULL) function in ->remove(), >> the driver_data will be set to NULL in device_unbind_cleanup() >> after calling ->remove(). > Do we need to remove i2c_set_clientdata(i2c, NULL) in ksz9477_i2c.c or > is it applicable only spi and mdio bus. Yes, it calls the dev_set_drvdata(), I think it should be remove too. Thanks, Yang
diff --git a/drivers/net/dsa/microchip/ksz8863_smi.c b/drivers/net/dsa/microchip/ksz8863_smi.c index 5247fdfb964d..ddb40838181e 100644 --- a/drivers/net/dsa/microchip/ksz8863_smi.c +++ b/drivers/net/dsa/microchip/ksz8863_smi.c @@ -180,8 +180,6 @@ static void ksz8863_smi_remove(struct mdio_device *mdiodev) if (dev) ksz_switch_remove(dev); - - dev_set_drvdata(&mdiodev->dev, NULL); } static void ksz8863_smi_shutdown(struct mdio_device *mdiodev) diff --git a/drivers/net/dsa/microchip/ksz_spi.c b/drivers/net/dsa/microchip/ksz_spi.c index 82e2352f55fa..1b6ab891b986 100644 --- a/drivers/net/dsa/microchip/ksz_spi.c +++ b/drivers/net/dsa/microchip/ksz_spi.c @@ -107,8 +107,6 @@ static void ksz_spi_remove(struct spi_device *spi) if (dev) ksz_switch_remove(dev); - - spi_set_drvdata(spi, NULL); } static void ksz_spi_shutdown(struct spi_device *spi)
Remove unnecessary set_drvdata(NULL) function in ->remove(), the driver_data will be set to NULL in device_unbind_cleanup() after calling ->remove(). Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> --- drivers/net/dsa/microchip/ksz8863_smi.c | 2 -- drivers/net/dsa/microchip/ksz_spi.c | 2 -- 2 files changed, 4 deletions(-)