Message ID | 20230421143648.87889-3-arinc.unal@arinc9.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | Netdev Maintainers |
Headers | show |
Series | net: dsa: MT7530, MT7531, and MT7988 improvements | expand |
Context | Check | Description |
---|---|---|
netdev/series_format | fail | Series longer than 15 patches (and no cover letter) |
netdev/tree_selection | success | Clearly marked for net-next |
netdev/fixes_present | success | Fixes tag not required for -next series |
netdev/header_inline | success | No static functions without inline keyword in header files |
netdev/build_32bit | success | Errors and warnings before: 8 this patch: 8 |
netdev/cc_maintainers | success | CCed 16 of 16 maintainers |
netdev/build_clang | success | Errors and warnings before: 8 this patch: 8 |
netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
netdev/deprecated_api | success | None detected |
netdev/check_selftest | success | No net selftest shell script |
netdev/verify_fixes | success | No Fixes tag |
netdev/build_allmodconfig_warn | success | Errors and warnings before: 8 this patch: 8 |
netdev/checkpatch | warning | WARNING: do not add new typedefs |
netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
netdev/source_inline | success | Was 0 now: 0 |
On Fri, Apr 21, 2023 at 05:36:28PM +0300, arinc9.unal@gmail.com wrote: > From: Arınç ÜNAL <arinc.unal@arinc9.com> > > Use the p5_interface_select enumeration as the data type for the > p5_intf_sel field. This ensures p5_intf_sel can only take the values > defined in the p5_interface_select enumeration. > > Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> > --- > drivers/net/dsa/mt7530.h | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h > index 845f5dd16d83..703f8a528317 100644 > --- a/drivers/net/dsa/mt7530.h > +++ b/drivers/net/dsa/mt7530.h > @@ -674,13 +674,13 @@ struct mt7530_port { > }; > > /* Port 5 interface select definitions */ > -enum p5_interface_select { > - P5_DISABLED = 0, > +typedef enum { We usually avoid adding typedef in kernel code. If the purpose is just to be more verbose in the struct definition, you can as well also just use 'enum p5_interface_select as type in the struct. > + P5_DISABLED, > P5_INTF_SEL_PHY_P0, > P5_INTF_SEL_PHY_P4, > P5_INTF_SEL_GMAC5, > P5_INTF_SEL_GMAC5_SGMII, > -}; > +} p5_interface_select; > > struct mt7530_priv; > > @@ -768,7 +768,7 @@ struct mt7530_priv { > bool mcm; > phy_interface_t p6_interface; > phy_interface_t p5_interface; > - unsigned int p5_intf_sel; > + p5_interface_select p5_intf_sel; enum p5_interface_select p5_intf_sel; > u8 mirror_rx; > u8 mirror_tx; > struct mt7530_port ports[MT7530_NUM_PORTS]; > -- > 2.37.2 >
On 21.04.2023 19:23, Daniel Golle wrote: > On Fri, Apr 21, 2023 at 05:36:28PM +0300, arinc9.unal@gmail.com wrote: >> From: Arınç ÜNAL <arinc.unal@arinc9.com> >> >> Use the p5_interface_select enumeration as the data type for the >> p5_intf_sel field. This ensures p5_intf_sel can only take the values >> defined in the p5_interface_select enumeration. >> >> Signed-off-by: Arınç ÜNAL <arinc.unal@arinc9.com> >> --- >> drivers/net/dsa/mt7530.h | 8 ++++---- >> 1 file changed, 4 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h >> index 845f5dd16d83..703f8a528317 100644 >> --- a/drivers/net/dsa/mt7530.h >> +++ b/drivers/net/dsa/mt7530.h >> @@ -674,13 +674,13 @@ struct mt7530_port { >> }; >> >> /* Port 5 interface select definitions */ >> -enum p5_interface_select { >> - P5_DISABLED = 0, >> +typedef enum { > > We usually avoid adding typedef in kernel code. If the purpose is > just to be more verbose in the struct definition, you can as well > also just use 'enum p5_interface_select as type in the struct. > >> + P5_DISABLED, >> P5_INTF_SEL_PHY_P0, >> P5_INTF_SEL_PHY_P4, >> P5_INTF_SEL_GMAC5, >> P5_INTF_SEL_GMAC5_SGMII, >> -}; >> +} p5_interface_select; >> >> struct mt7530_priv; >> >> @@ -768,7 +768,7 @@ struct mt7530_priv { >> bool mcm; >> phy_interface_t p6_interface; >> phy_interface_t p5_interface; >> - unsigned int p5_intf_sel; >> + p5_interface_select p5_intf_sel; > > enum p5_interface_select p5_intf_sel; Will do, thanks. Arınç
diff --git a/drivers/net/dsa/mt7530.h b/drivers/net/dsa/mt7530.h index 845f5dd16d83..703f8a528317 100644 --- a/drivers/net/dsa/mt7530.h +++ b/drivers/net/dsa/mt7530.h @@ -674,13 +674,13 @@ struct mt7530_port { }; /* Port 5 interface select definitions */ -enum p5_interface_select { - P5_DISABLED = 0, +typedef enum { + P5_DISABLED, P5_INTF_SEL_PHY_P0, P5_INTF_SEL_PHY_P4, P5_INTF_SEL_GMAC5, P5_INTF_SEL_GMAC5_SGMII, -}; +} p5_interface_select; struct mt7530_priv; @@ -768,7 +768,7 @@ struct mt7530_priv { bool mcm; phy_interface_t p6_interface; phy_interface_t p5_interface; - unsigned int p5_intf_sel; + p5_interface_select p5_intf_sel; u8 mirror_rx; u8 mirror_tx; struct mt7530_port ports[MT7530_NUM_PORTS];