| Message ID | 20231120121239.54504-1-jtornosm@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d2689b6a86b9d23574bd4b654bf770b6034e2c7e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v2,1/2] net: usb: ax88179_178a: fix failed operations during ax88179_reset | expand |
diff --git a/drivers/net/usb/ax88179_178a.c b/drivers/net/usb/ax88179_178a.c index 4ea0e155bb0d..8d835fbc4316 100644 --- a/drivers/net/usb/ax88179_178a.c +++ b/drivers/net/usb/ax88179_178a.c @@ -1298,8 +1298,6 @@ static int ax88179_bind(struct usbnet *dev, struct usb_interface *intf) netif_set_tso_max_size(dev->net, 16384); - ax88179_reset(dev); - return 0; }
The device is always reset two consecutive times (ax88179_reset is called twice), one from usbnet_probe during the device binding and the other from usbnet_open. Remove the non-necessary reset during the device binding and let the reset operation from open to keep the normal behavior (tested with generic ASIX Electronics Corp. AX88179 Gigabit Ethernet device). Fixes: e2ca90c276e1f ("ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver") Reported-by: Herb Wei <weihao.bj@ieisystem.com> Tested-by: Herb Wei <weihao.bj@ieisystem.com> Signed-off-by: Jose Ignacio Tornos Martinez <jtornosm@redhat.com> --- V1 -> V2: - Add Fixes tag. - Follow Paolo Abeni's suggestion and remove the binding reset, not the reset operation to keep the normal behavior. drivers/net/usb/ax88179_178a.c | 2 -- 1 file changed, 2 deletions(-)