[v2,0/2] delay monitor iothread creation

Message

Wolfgang Bumiller Sept. 28, 2018, 7:58 a.m. UTC

The early monitor iothread creation conflicts with the -daemonize option
causing crashes at shutdown of a daemonized qemu instance.
These patches will delay the creation to when a monitor using it is
actually spawned.

While the second patch depends on the first one, the first is a
consistency cleanup on its own, therefore split out.

v2:
This version incorporates Markus Armbruster's requested change to
protect mon_iothread initialization by monitor_lock (and moves the
variable declaration to reflect this), and adds a comments about
monitor_init() expecting to be run in the main thread.

Wolfgang Bumiller (2):
  monitor: guard iothread access by mon->use_io_thread
  monitor: delay monitor iothread creation

 monitor.c | 51 +++++++++++++++++++++++++++++++--------------------
 1 file changed, 31 insertions(+), 20 deletions(-)

Comments

Peter Xu Oct. 11, 2018, 12:09 a.m. UTC | #1

On Fri, Sep 28, 2018 at 09:58:30AM +0200, Wolfgang Bumiller wrote:
> The early monitor iothread creation conflicts with the -daemonize option
> causing crashes at shutdown of a daemonized qemu instance.
> These patches will delay the creation to when a monitor using it is
> actually spawned.
> 
> While the second patch depends on the first one, the first is a
> consistency cleanup on its own, therefore split out.
> 
> v2:
> This version incorporates Markus Armbruster's requested change to
> protect mon_iothread initialization by monitor_lock (and moves the
> variable declaration to reflect this), and adds a comments about
> monitor_init() expecting to be run in the main thread.
> 
> Wolfgang Bumiller (2):
>   monitor: guard iothread access by mon->use_io_thread
>   monitor: delay monitor iothread creation

Hi, Wolfgang,

Do you have plan to repost this series?

Regards,