diff mbox series

[v2,1/2] monitor: guard iothread access by mon->use_io_thread

Message ID 20180928075832.18586-2-w.bumiller@proxmox.com (mailing list archive)
State New, archived
Headers show
Series delay monitor iothread creation | expand

Commit Message

Wolfgang Bumiller Sept. 28, 2018, 7:58 a.m. UTC 
monitor_resume() and monitor_suspend() both want to
"kick" the I/O thread if it is there, but in
monitor_suspend() lacked the use_io_thread flag condition.
This is required when we later only spawn the thread on
first use.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
No changes in this patch.

 monitor.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/monitor.c b/monitor.c
index c4677b502b..d47e4259fd 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4285,7 +4285,7 @@  int monitor_suspend(Monitor *mon)
 
     atomic_inc(&mon->suspend_cnt);
 
-    if (monitor_is_qmp(mon)) {
+    if (monitor_is_qmp(mon) && mon->use_io_thread) {
         /*
          * Kick I/O thread to make sure this takes effect.  It'll be
          * evaluated again in prepare() of the watch object.