| Message ID | 20191108101655.10611-1-vsementsov@virtuozzo.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Deprecate implicit filters | expand |
Patchew URL: https://patchew.org/QEMU/20191108101655.10611-1-vsementsov@virtuozzo.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#! /bin/bash
export ARCH=x86_64
make docker-image-fedora V=1 NETWORK=1
time make docker-test-mingw@fedora J=14 NETWORK=1
=== TEST SCRIPT END ===
SIGN pc-bios/optionrom/pvh.bin
GEN docs/interop/qemu-ga-ref.7
/tmp/qemu-test/src/qemu-deprecated.texi:210: @option expected braces
make: *** [Makefile:994: qemu-doc.txt] Error 1
make: *** Waiting for unfinished jobs....
/tmp/qemu-test/src/qemu-deprecated.texi:210: @option expected braces
make: *** [Makefile:987: qemu-doc.html] Error 1
Traceback (most recent call last):
File "./tests/docker/docker.py", line 662, in <module>
sys.exit(main())
---
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=3d404482279f4fe68fcb2c9971f2480a', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-mlpokwtg/src/docker-src.2019-11-08-06.56.33.23805:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=3d404482279f4fe68fcb2c9971f2480a
make[1]: *** [docker-run] Error 1
make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-mlpokwtg/src'
make: *** [docker-run-test-mingw@fedora] Error 2
real 4m11.170s
user 0m4.404s
The full log is available at
http://patchew.org/logs/20191108101655.10611-1-vsementsov@virtuozzo.com/testing.docker-mingw@fedora/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Something strange, I don't think it related to patchset. 08.11.2019 15:00, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20191108101655.10611-1-vsementsov@virtuozzo.com/ > > > > Hi, > > This series failed the docker-mingw@fedora build test. Please find the testing commands and > their output below. If you have Docker installed, you can probably reproduce it > locally. > > === TEST SCRIPT BEGIN === > #! /bin/bash > export ARCH=x86_64 > make docker-image-fedora V=1 NETWORK=1 > time make docker-test-mingw@fedora J=14 NETWORK=1 > === TEST SCRIPT END === > > SIGN pc-bios/optionrom/pvh.bin > GEN docs/interop/qemu-ga-ref.7 > /tmp/qemu-test/src/qemu-deprecated.texi:210: @option expected braces > make: *** [Makefile:994: qemu-doc.txt] Error 1 > make: *** Waiting for unfinished jobs.... > /tmp/qemu-test/src/qemu-deprecated.texi:210: @option expected braces > make: *** [Makefile:987: qemu-doc.html] Error 1 > Traceback (most recent call last): > File "./tests/docker/docker.py", line 662, in <module> > sys.exit(main()) > --- > raise CalledProcessError(retcode, cmd) > subprocess.CalledProcessError: Command '['sudo', '-n', 'docker', 'run', '--label', 'com.qemu.instance.uuid=3d404482279f4fe68fcb2c9971f2480a', '-u', '1001', '--security-opt', 'seccomp=unconfined', '--rm', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=14', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/patchew/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-mlpokwtg/src/docker-src.2019-11-08-06.56.33.23805:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 2. > filter=--filter=label=com.qemu.instance.uuid=3d404482279f4fe68fcb2c9971f2480a > make[1]: *** [docker-run] Error 1 > make[1]: Leaving directory `/var/tmp/patchew-tester-tmp-mlpokwtg/src' > make: *** [docker-run-test-mingw@fedora] Error 2 > > real 4m11.170s > user 0m4.404s > > > The full log is available at > http://patchew.org/logs/20191108101655.10611-1-vsementsov@virtuozzo.com/testing.docker-mingw@fedora/?type=message. > --- > Email generated automatically by Patchew [https://patchew.org/]. > Please send your feedback to patchew-devel@redhat.com >
On Fri, 2019-11-08 at 13:16 +0300, Vladimir Sementsov-Ogievskiy wrote: > v2: > Don't deprecate drive-backup, it is unrelated thing and will be resent > in separate. > Don't deprecate drive-mirror. Instead add filter-node-name to > drive-mirror to behave like blockdev-mirror > Fix all broken iotests. I did a quick overview of these patches (I don't know the area well to do a full review) and it looks fine to me, other than that FIXME you added, which (at least looking at the explanation) I think should be investigated, as it might point to a deeper problem somewhere. Also *I think* that I would merge these two patches together, but this is only my personal taste. Best regards, Maxim Levitsky > > Vladimir Sementsov-Ogievskiy (2): > qapi: add filter-node-name option to drive-mirror > qapi: deprecate implicit filters > > qemu-deprecated.texi | 6 ++++++ > qapi/block-core.json | 14 ++++++++++++-- > include/block/block_int.h | 10 +++++++++- > blockdev.c | 12 +++++++++++- > tests/qemu-iotests/094 | 1 + > tests/qemu-iotests/095 | 6 ++++-- > tests/qemu-iotests/109 | 1 + > tests/qemu-iotests/127 | 1 + > tests/qemu-iotests/141 | 5 ++++- > tests/qemu-iotests/144 | 3 ++- > tests/qemu-iotests/156 | 1 + > tests/qemu-iotests/161 | 7 +++++++ > tests/qemu-iotests/161.out | 1 + > tests/qemu-iotests/185 | 3 +++ > tests/qemu-iotests/191 | 2 ++ > tests/qemu-iotests/229 | 1 + > tests/qemu-iotests/247 | 8 +++++--- > tests/qemu-iotests/249 | 5 +++-- > tests/qemu-iotests/249.out | 2 +- > 19 files changed, 75 insertions(+), 14 deletions(-) >