[0/6] hw/arm/raspi: Dynamically create machines based on the board revision

Message

Philippe Mathieu-Daudé Feb. 3, 2020, 8:26 a.m. UTC

Hi,

These patches simplify adding the raspi0/raspi1/raspi4 boards.

I still need some time to figure out what is the best way to
organize the SoC code because since these socs use different
ARM cores, the interrupt controller are different too.

Igor has been working in his "refactor main RAM allocation to use
hostmem backend" series, and now v4 [1] is almost reviewed.
His raspi patch [2] clashes with my work, Since it is easier for
him to apply his on top of mine, I am sending these patches first.

Please review,

Phil.

[1] https://www.mail-archive.com/[e-mail]/msg675738.html
[2] https://www.mail-archive.com/[e-mail]/msg675752.html

Philippe Mathieu-Daudé (6):
  hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels
  hw/arm/raspi: Get board version from board revision code
  hw/arm/raspi: Get the SoC type name from the revision code
  hw/arm/raspi: Get board RAM size from board revision code
  hw/arm/raspi: Dynamically create machines based on the board revision
  hw/arm/raspi: Get the CPU core count from the revision code

 hw/arm/raspi.c | 178 +++++++++++++++++++++++++++++++++++++------------
 1 file changed, 135 insertions(+), 43 deletions(-)

Comments

[e-mail] Feb. 3, 2020, 4:48 p.m. UTC | #1

Patchew URL: https://patchew.org/QEMU/[e-mail]/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [PATCH 0/6] hw/arm/raspi: Dynamically create machines based on the board revision
Message-id: [e-mail]
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
ba9fce5 hw/arm/raspi: Get the CPU core count from the revision code
dd68e6d hw/arm/raspi: Dynamically create machines based on the board revision
d471baa hw/arm/raspi: Get board RAM size from board revision code
97ae39f hw/arm/raspi: Get the SoC type name from the revision code
cb64a6d hw/arm/raspi: Get board version from board revision code
a4b6fc3 hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels

=== OUTPUT BEGIN ===
1/6 Checking commit a4b6fc3d4ca9 (hw/arm/raspi: Use BCM2708 machine type with pre Device Tree kernels)
2/6 Checking commit cb64a6de4571 (hw/arm/raspi: Get board version from board revision code)
ERROR: that open brace { should be on the previous line
#36: FILE: hw/arm/raspi.c:51:
+    [BOARD_PI2] =
+    {

ERROR: that open brace { should be on the previous line
#41: FILE: hw/arm/raspi.c:56:
+    [BOARD_PI3] =
+    {

total: 2 errors, 0 warnings, 77 lines checked

Patch 2/6 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/6 Checking commit 97ae39f1b2a1 (hw/arm/raspi: Get the SoC type name from the revision code)
4/6 Checking commit d471baa88380 (hw/arm/raspi: Get board RAM size from board revision code)
5/6 Checking commit dd68e6dcaa11 (hw/arm/raspi: Dynamically create machines based on the board revision)
6/6 Checking commit ba9fce566944 (hw/arm/raspi: Get the CPU core count from the revision code)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/[e-mail]/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to [e-mail]