| Message ID | 20200529134523.8477-1-armbru@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | qdev: Rework how we plug into the parent bus | expand |
Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-armbru@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20200529134523.8477-1-armbru@redhat.com -> patchew/20200529134523.8477-1-armbru@redhat.com Switched to a new branch 'test' 7589916 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well 6994d03 qdev: qdev_init_nofail() is now unused, drop 28e5350 qdev: Convert bus-less devices to qdev_realize() with Coccinelle 24d6e87 qdev: Use qdev_realize() in qdev_device_add() 69431f7 qdev: Make qdev_realize() support bus-less devices eacf47b s390x/event-facility: Simplify creation of SCLP event devices aa49280 microbit: Eliminate two local variables in microbit_init() f0de8f0 sysbus: sysbus_init_child_obj() is now unused, drop 66f9bee sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 1331f49 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 5fa2c01 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 0ccb25e sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 961ce94 qdev: Drop qdev_realize() support for null bus d78366f sysbus: Convert to sysbus_realize() etc. with Coccinelle 898a7ab sysbus: New sysbus_realize(), sysbus_realize_and_unref() 0fbbe51 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 860c6ca hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() 162f9dc sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 b99d804 microbit: Tidy up sysbus_init_child_obj() @child argument ff62f9e sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls e53941f macio: Eliminate macio_init_child_obj() 2510ca8 macio: Convert use of qdev_set_parent_bus() 953f19f qom: Less verbose object_initialize_child() 8778bdb qom: Tidy up a few object_initialize_child() calls abb885b auxbus: Eliminate aux_create_slave() 5083fdd auxbus: Convert a use of qdev_set_parent_bus() e8a1b07 auxbus: New aux_bus_realize(), pairing with aux_bus_init() c1752eb auxbus: Rename aux_init_bus() to aux_bus_init() c1dadd3 qdev: qdev_create(), qdev_try_create() are now unused, drop 39bd923 usb: Eliminate usb_try_create_simple() 37db777 usb: usb_create() is now unused, drop e5fc764 usb: Convert uses of usb_create() edb4e6f usb: New usb_new(), usb_realize_and_unref() c201e80 ssi: ssi_create_slave_no_init() is now unused, drop 153b1f5 ssi: Convert last use of ssi_create_slave_no_init() manually 27662fe ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle fda3da1 ssi: ssi_auto_connect_slaves() never does anything, drop 1bf6c3d isa: isa_create(), isa_try_create() are now unused, drop f318e5e isa: Convert uses of isa_create(), isa_try_create() manually 0895b2f isa: Convert uses of isa_create() with Coccinelle f974cfd isa: New isa_new(), isa_realize_and_unref() etc. 606ba5d pci: pci_create(), pci_create_multifunction() are now unused, drop a5c13fa pci: Convert uses of pci_create() etc. manually c35c770 pci: Convert uses of pci_create() etc. with Coccinelle 5464c8e hw/ppc: Eliminate two superfluous QOM casts 5d67e72 pci: New pci_new(), pci_realize_and_unref() etc. cc45810 qdev: Convert uses of qdev_set_parent_bus() manually 46e1328 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle 67f0f5e qdev: Convert uses of qdev_create() manually 0a1d4ce qdev: Convert uses of qdev_create() with Coccinelle 27f7460 qdev: Convert to qdev_unrealize() manually 2498182 qdev: Convert to qdev_unrealize() with Coccinelle ad3110b qdev: Convert to qbus_realize(), qbus_unrealize() 25b4418 qdev: Put qdev_new() to use with Coccinelle ed7f4e6 qdev: New qdev_new(), qdev_realize(), etc. 6f19dca Revert "hw/versatile: realize the PCI root bus as part of the versatile init" c59bc88 Revert "hw/prep: realize the PCI root bus as part of the prep init" ebbe306 qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit ebbe306db75f (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit c59bc8873b47 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit 6f19dca18669 (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit ed7f4e69bb18 (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit 25b4418f5f7a (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit ad3110b90bac (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit 2498182f99c4 (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit 27f74605f6cd (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 0a1d4ce8a9e8 (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit 67f0f5e99ac1 (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit 46e13283fb42 (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit cc4581055d6a (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit 5d67e7231d7a (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 5464c8e9092a (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit c35c7705d264 (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit a5c13fae7b97 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit 606ba5dd2307 (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit f974cfde8a96 (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 0895b2f7bdef (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit f318e5e73fec (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit 1bf6c3dff63d (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit fda3da1972d0 (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit 27662fe7b4ea (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit 153b1f5ffd90 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit c201e80d6131 (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit edb4e6f9e243 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit e5fc7646c036 (usb: Convert uses of usb_create()) 28/58 Checking commit 37db777adfa9 (usb: usb_create() is now unused, drop) 29/58 Checking commit 39bd92331d31 (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit c1dadd39f82f (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit c1752ebd01d4 (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit e8a1b07a0960 (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit 5083fdd2e26f (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit abb885b7ec3a (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 8778bdb31982 (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit 953f19fdd985 (qom: Less verbose object_initialize_child()) 37/58 Checking commit 2510ca882185 (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit e53941fbcd33 (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit ff62f9e7764d (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit b99d804dd0f8 (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit 162f9dc4176c (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit 860c6caf648f (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 0fbbe51261c9 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 898a7ab1aee0 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit d78366f9a62c (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit 961ce942b6d4 (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit 0ccb25e7eb0d (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 5fa2c01d63f8 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit 1331f492e7b5 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit 66f9bee437db (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit f0de8f06c917 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit aa492801367a (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit eacf47bc6f85 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 69431f780e1e (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit 24d6e876b29a (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit 28e53504bf09 (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit 6994d038b2b4 (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 7589916c0ae5 (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-armbru@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 35d2186 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well b5abcc7 qdev: qdev_init_nofail() is now unused, drop f8fd657 qdev: Convert bus-less devices to qdev_realize() with Coccinelle 7cbb4a0 qdev: Use qdev_realize() in qdev_device_add() 90508ef qdev: Make qdev_realize() support bus-less devices ac2c79d s390x/event-facility: Simplify creation of SCLP event devices c9df786 microbit: Eliminate two local variables in microbit_init() 7de4365 sysbus: sysbus_init_child_obj() is now unused, drop 6deeaef sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 166f451 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 817d04d sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 35ed426 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 efb76a5 qdev: Drop qdev_realize() support for null bus e52c78b sysbus: Convert to sysbus_realize() etc. with Coccinelle b165b5e sysbus: New sysbus_realize(), sysbus_realize_and_unref() c4fa2dd sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 a65d26d hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() c02d099 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 874a6e0 microbit: Tidy up sysbus_init_child_obj() @child argument 1c1983c sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls d3da8f6 macio: Eliminate macio_init_child_obj() a6fbb72 macio: Convert use of qdev_set_parent_bus() cd787ca qom: Less verbose object_initialize_child() 5fc1ec3 qom: Tidy up a few object_initialize_child() calls b70e5d6 auxbus: Eliminate aux_create_slave() a553d10 auxbus: Convert a use of qdev_set_parent_bus() 332ba93 auxbus: New aux_bus_realize(), pairing with aux_bus_init() 760bbfe auxbus: Rename aux_init_bus() to aux_bus_init() 8849af5 qdev: qdev_create(), qdev_try_create() are now unused, drop 7bf4596 usb: Eliminate usb_try_create_simple() 7879a1b usb: usb_create() is now unused, drop 4ad74fb usb: Convert uses of usb_create() bdabeda usb: New usb_new(), usb_realize_and_unref() 66d155d ssi: ssi_create_slave_no_init() is now unused, drop eccc542 ssi: Convert last use of ssi_create_slave_no_init() manually abe5193 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle a0d9945 ssi: ssi_auto_connect_slaves() never does anything, drop ed8709f isa: isa_create(), isa_try_create() are now unused, drop 8325fc1 isa: Convert uses of isa_create(), isa_try_create() manually e33f3fd isa: Convert uses of isa_create() with Coccinelle 37f2e28 isa: New isa_new(), isa_realize_and_unref() etc. 76bd83a pci: pci_create(), pci_create_multifunction() are now unused, drop e8ce95a pci: Convert uses of pci_create() etc. manually b876876 pci: Convert uses of pci_create() etc. with Coccinelle 7161985 hw/ppc: Eliminate two superfluous QOM casts a9d8154 pci: New pci_new(), pci_realize_and_unref() etc. 5d6768f qdev: Convert uses of qdev_set_parent_bus() manually 60523d1 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle 01819c3 qdev: Convert uses of qdev_create() manually 4d94520c qdev: Convert uses of qdev_create() with Coccinelle d576e66 qdev: Convert to qdev_unrealize() manually d2e42f8 qdev: Convert to qdev_unrealize() with Coccinelle e8618d0 qdev: Convert to qbus_realize(), qbus_unrealize() 08ab272e qdev: Put qdev_new() to use with Coccinelle 22a047a qdev: New qdev_new(), qdev_realize(), etc. 4eabae2 Revert "hw/versatile: realize the PCI root bus as part of the versatile init" e75024d Revert "hw/prep: realize the PCI root bus as part of the prep init" 5ac175a qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit 5ac175a0ddb4 (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit e75024d0e9a7 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit 4eabae2c9ff8 (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit 22a047a6e8b6 (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit 08ab272e5d44 (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit e8618d00d5a1 (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit d2e42f8ae924 (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit d576e6651852 (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 4d94520c7fb5 (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit 01819c395ec3 (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit 60523d193f4b (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit 5d6768f54514 (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit a9d81542adb1 (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 7161985e36f7 (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit b8768760337e (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit e8ce95ae8070 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit 76bd83ae156f (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit 37f2e281b9dc (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit e33f3fd2e99d (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit 8325fc1d09cb (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit ed8709f374e2 (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit a0d9945a52c2 (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit abe5193ac773 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit eccc542bc734 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit 66d155dc5356 (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit bdabeda16b8b (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit 4ad74fb7b4dd (usb: Convert uses of usb_create()) 28/58 Checking commit 7879a1bf0f80 (usb: usb_create() is now unused, drop) 29/58 Checking commit 7bf459696e13 (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit 8849af5b26d7 (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit 760bbfe85529 (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit 332ba93642f1 (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit a553d109c610 (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit b70e5d6b08e0 (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 5fc1ec3c2182 (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit cd787ca34447 (qom: Less verbose object_initialize_child()) 37/58 Checking commit a6fbb724e7b6 (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit d3da8f631f47 (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit 1c1983c516db (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit 874a6e009b2c (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit c02d099b14d8 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit a65d26d31c58 (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit c4fa2dd20d7b (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit b165b5e5b293 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit e52c78bf229b (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit efb76a577cd4 (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit 35ed4267918e (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 817d04dac4b8 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit 166f451f2fd6 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit 6deeaef29eb1 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit 7de436543ef9 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit c9df7868a550 (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit ac2c79d66173 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 90508ef845f7 (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit 7cbb4a0cb686 (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit f8fd657efef4 (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit b5abcc75ae8b (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 35d2186328c9 (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-armbru@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Switched to a new branch 'test' 439fb47 MAINTAINERS: Make section QOM cover hw/core/*bus.c as well d92f0c7 qdev: qdev_init_nofail() is now unused, drop c0715ef qdev: Convert bus-less devices to qdev_realize() with Coccinelle 66e45b5 qdev: Use qdev_realize() in qdev_device_add() 432aa71 qdev: Make qdev_realize() support bus-less devices 7adde43 s390x/event-facility: Simplify creation of SCLP event devices 023393d microbit: Eliminate two local variables in microbit_init() d32d183 sysbus: sysbus_init_child_obj() is now unused, drop f887b4a sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 a48b36e sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 16d53b8 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 a0a8667 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 1cccb08 qdev: Drop qdev_realize() support for null bus 1f150da sysbus: Convert to sysbus_realize() etc. with Coccinelle 515e6be sysbus: New sysbus_realize(), sysbus_realize_and_unref() 0409a9e sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 2c443b6 hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() 2ed1734 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 9325ac9 microbit: Tidy up sysbus_init_child_obj() @child argument b7ac15d sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls 5dc614e macio: Eliminate macio_init_child_obj() bc90f43 macio: Convert use of qdev_set_parent_bus() 2196060 qom: Less verbose object_initialize_child() 96f3e31 qom: Tidy up a few object_initialize_child() calls 0820cdc auxbus: Eliminate aux_create_slave() 4a021fb auxbus: Convert a use of qdev_set_parent_bus() bbc4f64 auxbus: New aux_bus_realize(), pairing with aux_bus_init() 52256c6 auxbus: Rename aux_init_bus() to aux_bus_init() 76048e4 qdev: qdev_create(), qdev_try_create() are now unused, drop 6374c40 usb: Eliminate usb_try_create_simple() 7c5c5ab usb: usb_create() is now unused, drop a43f9f0 usb: Convert uses of usb_create() a4c114f usb: New usb_new(), usb_realize_and_unref() cb5a489 ssi: ssi_create_slave_no_init() is now unused, drop db5290e ssi: Convert last use of ssi_create_slave_no_init() manually c9a8764 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle 9545fd0 ssi: ssi_auto_connect_slaves() never does anything, drop 14e4080 isa: isa_create(), isa_try_create() are now unused, drop a54d8a1 isa: Convert uses of isa_create(), isa_try_create() manually 2631eed isa: Convert uses of isa_create() with Coccinelle 021d395 isa: New isa_new(), isa_realize_and_unref() etc. eb88940 pci: pci_create(), pci_create_multifunction() are now unused, drop 56f3abb pci: Convert uses of pci_create() etc. manually bd6368c pci: Convert uses of pci_create() etc. with Coccinelle 60ce491 hw/ppc: Eliminate two superfluous QOM casts a64f284 pci: New pci_new(), pci_realize_and_unref() etc. f88aed3 qdev: Convert uses of qdev_set_parent_bus() manually 7a73579 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle e793be8 qdev: Convert uses of qdev_create() manually 1e16c91 qdev: Convert uses of qdev_create() with Coccinelle 079098b qdev: Convert to qdev_unrealize() manually a68857c qdev: Convert to qdev_unrealize() with Coccinelle 1278ec6 qdev: Convert to qbus_realize(), qbus_unrealize() f7515ac qdev: Put qdev_new() to use with Coccinelle 30e7237 qdev: New qdev_new(), qdev_realize(), etc. ebddc9d Revert "hw/versatile: realize the PCI root bus as part of the versatile init" ae55003 Revert "hw/prep: realize the PCI root bus as part of the prep init" 1d4911c qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit 1d4911ccb8d0 (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit ae55003b5a47 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit ebddc9d7a53c (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit 30e7237d2b7e (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit f7515ac8f5b7 (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit 1278ec63328a (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit a68857c8ae4b (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit 079098b4361c (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 1e16c91bd20c (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit e793be88432b (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit 7a73579f06a8 (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit f88aed37101f (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit a64f284c5096 (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 60ce491ff2c9 (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit bd6368cea83a (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit 56f3abb79412 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit eb889403b14d (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit 021d3950d2cd (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 2631eed1a06d (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit a54d8a1d99f6 (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit 14e4080810d0 (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit 9545fd066aff (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit c9a87646ee76 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit db5290e971d1 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit cb5a489800c6 (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit a4c114f899d2 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit a43f9f03ebad (usb: Convert uses of usb_create()) 28/58 Checking commit 7c5c5abcf5df (usb: usb_create() is now unused, drop) 29/58 Checking commit 6374c40d97d6 (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit 76048e4a9462 (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit 52256c61e373 (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit bbc4f6453b6c (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit 4a021fb34d94 (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit 0820cdc01f86 (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 96f3e313c91e (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit 2196060b2590 (qom: Less verbose object_initialize_child()) 37/58 Checking commit bc90f43e93a9 (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit 5dc614ecab3d (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit b7ac15d209f7 (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit 9325ac93a7b1 (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit 2ed17344e8fc (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit 2c443b60ec07 (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 0409a9efa3a3 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 515e6bed1aa3 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit 1f150dabc41d (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit 1cccb0836d4c (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit a0a8667410c3 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 16d53b8bc144 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit a48b36e90d91 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit f887b4a113ed (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit d32d183e22e3 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit 023393df5a26 (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit 7adde438cbf4 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 432aa713c9ec (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit 66e45b562e1b (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit c0715ef52295 (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit d92f0c7b4477 (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 439fb47776fd (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-armbru@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu - [tag update] patchew/20200529134523.8477-1-armbru@redhat.com -> patchew/20200529134523.8477-1-armbru@redhat.com Switched to a new branch 'test' 6ab17ba MAINTAINERS: Make section QOM cover hw/core/*bus.c as well 2ff6640 qdev: qdev_init_nofail() is now unused, drop ef169cb qdev: Convert bus-less devices to qdev_realize() with Coccinelle c5fb207 qdev: Use qdev_realize() in qdev_device_add() 53c9eb7 qdev: Make qdev_realize() support bus-less devices a24f37d s390x/event-facility: Simplify creation of SCLP event devices e98ec98 microbit: Eliminate two local variables in microbit_init() de2d573 sysbus: sysbus_init_child_obj() is now unused, drop f4e9821 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 bb63878 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 284c740 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 8968c58 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 d5b3267 qdev: Drop qdev_realize() support for null bus 366dd6c sysbus: Convert to sysbus_realize() etc. with Coccinelle 5d8cf38 sysbus: New sysbus_realize(), sysbus_realize_and_unref() 2e4518c sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 cf3ac8b hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() a7d0014 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 20429c9 microbit: Tidy up sysbus_init_child_obj() @child argument 23d67a5 sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls 31aeda4 macio: Eliminate macio_init_child_obj() a4f9cab macio: Convert use of qdev_set_parent_bus() eee0ca9 qom: Less verbose object_initialize_child() f8dcb00 qom: Tidy up a few object_initialize_child() calls bd186c9 auxbus: Eliminate aux_create_slave() 404dc52 auxbus: Convert a use of qdev_set_parent_bus() de8ce5f auxbus: New aux_bus_realize(), pairing with aux_bus_init() 083ee04 auxbus: Rename aux_init_bus() to aux_bus_init() 4ac8676 qdev: qdev_create(), qdev_try_create() are now unused, drop e6cc739 usb: Eliminate usb_try_create_simple() 9f21e80 usb: usb_create() is now unused, drop 0177184 usb: Convert uses of usb_create() d4128a5 usb: New usb_new(), usb_realize_and_unref() 4e2dc9b ssi: ssi_create_slave_no_init() is now unused, drop 7e18650 ssi: Convert last use of ssi_create_slave_no_init() manually d5646b2 ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle 092d4f1 ssi: ssi_auto_connect_slaves() never does anything, drop bae4ea1 isa: isa_create(), isa_try_create() are now unused, drop e6e38d5 isa: Convert uses of isa_create(), isa_try_create() manually 0dde89d isa: Convert uses of isa_create() with Coccinelle d09e209 isa: New isa_new(), isa_realize_and_unref() etc. c36b876 pci: pci_create(), pci_create_multifunction() are now unused, drop 9464192 pci: Convert uses of pci_create() etc. manually dfb652b pci: Convert uses of pci_create() etc. with Coccinelle 2d210af hw/ppc: Eliminate two superfluous QOM casts b9af5c7 pci: New pci_new(), pci_realize_and_unref() etc. 20700a7 qdev: Convert uses of qdev_set_parent_bus() manually dd8ce29 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle cbeac45 qdev: Convert uses of qdev_create() manually a3830a0 qdev: Convert uses of qdev_create() with Coccinelle b3fc907 qdev: Convert to qdev_unrealize() manually 1e4b57b qdev: Convert to qdev_unrealize() with Coccinelle 20d2240 qdev: Convert to qbus_realize(), qbus_unrealize() af49a25 qdev: Put qdev_new() to use with Coccinelle a62e83f qdev: New qdev_new(), qdev_realize(), etc. 6766bcb Revert "hw/versatile: realize the PCI root bus as part of the versatile init" 35d8550 Revert "hw/prep: realize the PCI root bus as part of the prep init" 9cfc5ab qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit 9cfc5ab931a7 (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit 35d8550db6e2 (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit 6766bcb8b645 (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit a62e83f0ba1a (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit af49a25a9a73 (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit 20d2240056ba (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit 1e4b57ba4cf9 (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit b3fc907924a6 (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit a3830a03812e (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit cbeac45a59cb (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit dd8ce29abe63 (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit 20700a719958 (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit b9af5c7cdadb (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit 2d210af6278f (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit dfb652bc680d (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit 946419234024 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit c36b87606a08 (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit d09e209b86e0 (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 0dde89d7c13d (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit e6e38d544dba (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit bae4ea1feef9 (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit 092d4f1ac851 (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit d5646b2a7924 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit 7e1865019bd5 (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit 4e2dc9ba647b (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit d4128a503d17 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit 017718456f64 (usb: Convert uses of usb_create()) 28/58 Checking commit 9f21e803c95e (usb: usb_create() is now unused, drop) 29/58 Checking commit e6cc739dff4b (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit 4ac8676ab5ce (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit 083ee04a41ba (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit de8ce5f7a784 (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit 404dc52e0539 (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit bd186c9404f7 (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit f8dcb001d2c5 (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit eee0ca94ef31 (qom: Less verbose object_initialize_child()) 37/58 Checking commit a4f9cab09dcd (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit 31aeda4f96d3 (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit 23d67a51f803 (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit 20429c92daee (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit a7d0014faf41 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit cf3ac8bb20fc (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 2e4518c3efc6 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 5d8cf382708c (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit 366dd6c2ee62 (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit d5b3267d1d3d (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit 8968c58bc12f (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 284c740f202f (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit bb6387808750 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit f4e982128f29 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit de2d573cc85d (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit e98ec982bdb7 (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit a24f37d08052 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 53c9eb722a78 (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit c5fb207ea220 (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit ef169cb2094b (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit 2ff66406a79b (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit 6ab17bae2d34 (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20200529134523.8477-1-armbru@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20200529134523.8477-1-armbru@redhat.com Subject: [PATCH v2 00/58] qdev: Rework how we plug into the parent bus Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20200529134523.8477-1-armbru@redhat.com -> patchew/20200529134523.8477-1-armbru@redhat.com Switched to a new branch 'test' d7ba4cb MAINTAINERS: Make section QOM cover hw/core/*bus.c as well e12f9a9 qdev: qdev_init_nofail() is now unused, drop c587de1 qdev: Convert bus-less devices to qdev_realize() with Coccinelle e3ec37d qdev: Use qdev_realize() in qdev_device_add() 508be87 qdev: Make qdev_realize() support bus-less devices 2b3a896 s390x/event-facility: Simplify creation of SCLP event devices 35263dc microbit: Eliminate two local variables in microbit_init() bf24af3 sysbus: sysbus_init_child_obj() is now unused, drop 0f6c400 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 eaeff13 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 17b4e10 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 e2a4e40 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 452882c qdev: Drop qdev_realize() support for null bus 99093fa sysbus: Convert to sysbus_realize() etc. with Coccinelle 0a36513 sysbus: New sysbus_realize(), sysbus_realize_and_unref() 8004fce sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 e347c20 hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() 982e979 sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 50a9e3b microbit: Tidy up sysbus_init_child_obj() @child argument 23fad3c sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls d944eab macio: Eliminate macio_init_child_obj() 8bb71b7 macio: Convert use of qdev_set_parent_bus() 94f09a8 qom: Less verbose object_initialize_child() 248945e qom: Tidy up a few object_initialize_child() calls 71344e4 auxbus: Eliminate aux_create_slave() cfce609 auxbus: Convert a use of qdev_set_parent_bus() ffced2a auxbus: New aux_bus_realize(), pairing with aux_bus_init() ad1d6ea auxbus: Rename aux_init_bus() to aux_bus_init() 4302b25 qdev: qdev_create(), qdev_try_create() are now unused, drop b29fdb6 usb: Eliminate usb_try_create_simple() 044a4d6 usb: usb_create() is now unused, drop 2119f64 usb: Convert uses of usb_create() 0869d6b usb: New usb_new(), usb_realize_and_unref() 7a38216 ssi: ssi_create_slave_no_init() is now unused, drop 1de789b ssi: Convert last use of ssi_create_slave_no_init() manually f0966db ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle a44e783 ssi: ssi_auto_connect_slaves() never does anything, drop dd97b52 isa: isa_create(), isa_try_create() are now unused, drop facab3d isa: Convert uses of isa_create(), isa_try_create() manually 21c651e isa: Convert uses of isa_create() with Coccinelle 828f669 isa: New isa_new(), isa_realize_and_unref() etc. 7422b38 pci: pci_create(), pci_create_multifunction() are now unused, drop d66dd66 pci: Convert uses of pci_create() etc. manually 47e9e7f pci: Convert uses of pci_create() etc. with Coccinelle c2a7c32 hw/ppc: Eliminate two superfluous QOM casts 05dae68 pci: New pci_new(), pci_realize_and_unref() etc. 73a088d qdev: Convert uses of qdev_set_parent_bus() manually a6a5708 qdev: Convert uses of qdev_set_parent_bus() with Coccinelle 04167e9 qdev: Convert uses of qdev_create() manually 3ddff84 qdev: Convert uses of qdev_create() with Coccinelle 3a0df8e qdev: Convert to qdev_unrealize() manually b89c5d7 qdev: Convert to qdev_unrealize() with Coccinelle 5f39fa6 qdev: Convert to qbus_realize(), qbus_unrealize() c056c1e qdev: Put qdev_new() to use with Coccinelle 8d85516 qdev: New qdev_new(), qdev_realize(), etc. 77a952f Revert "hw/versatile: realize the PCI root bus as part of the versatile init" 3e66cdd Revert "hw/prep: realize the PCI root bus as part of the prep init" 232f042 qdev: Rename qbus_realize() to qbus_init() === OUTPUT BEGIN === 1/58 Checking commit 232f042d8722 (qdev: Rename qbus_realize() to qbus_init()) 2/58 Checking commit 3e66cdd1d73c (Revert "hw/prep: realize the PCI root bus as part of the prep init") 3/58 Checking commit 77a952ffe9ae (Revert "hw/versatile: realize the PCI root bus as part of the versatile init") 4/58 Checking commit 8d855167bb6e (qdev: New qdev_new(), qdev_realize(), etc.) 5/58 Checking commit c056c1e1f85e (qdev: Put qdev_new() to use with Coccinelle) 6/58 Checking commit 5f39fa696d96 (qdev: Convert to qbus_realize(), qbus_unrealize()) 7/58 Checking commit b89c5d7e3746 (qdev: Convert to qdev_unrealize() with Coccinelle) 8/58 Checking commit 3a0df8e4207e (qdev: Convert to qdev_unrealize() manually) 9/58 Checking commit 3ddff8499cd2 (qdev: Convert uses of qdev_create() with Coccinelle) 10/58 Checking commit 04167e9fc90b (qdev: Convert uses of qdev_create() manually) 11/58 Checking commit a6a57083d2bd (qdev: Convert uses of qdev_set_parent_bus() with Coccinelle) 12/58 Checking commit 73a088d875a8 (qdev: Convert uses of qdev_set_parent_bus() manually) 13/58 Checking commit 05dae681b4ba (pci: New pci_new(), pci_realize_and_unref() etc.) 14/58 Checking commit c2a7c3220d1c (hw/ppc: Eliminate two superfluous QOM casts) 15/58 Checking commit 47e9e7f0a084 (pci: Convert uses of pci_create() etc. with Coccinelle) 16/58 Checking commit d66dd66530c0 (pci: Convert uses of pci_create() etc. manually) 17/58 Checking commit 7422b38a58e9 (pci: pci_create(), pci_create_multifunction() are now unused, drop) 18/58 Checking commit 828f6693aeed (isa: New isa_new(), isa_realize_and_unref() etc.) 19/58 Checking commit 21c651efd456 (isa: Convert uses of isa_create() with Coccinelle) ERROR: do not use C99 // comments #384: FILE: hw/rtc/m48t59-isa.c:74: + ISADevice *isa_dev; // TODO move ERROR: do not use C99 // comments #420: FILE: hw/sparc64/sun4u.c:341: + ISADevice *isa_dev; // TODO move total: 2 errors, 0 warnings, 348 lines checked Patch 19/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 20/58 Checking commit facab3dfadfc (isa: Convert uses of isa_create(), isa_try_create() manually) 21/58 Checking commit dd97b525312d (isa: isa_create(), isa_try_create() are now unused, drop) 22/58 Checking commit a44e78379910 (ssi: ssi_auto_connect_slaves() never does anything, drop) 23/58 Checking commit f0966dbe62a4 (ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle) 24/58 Checking commit 1de789b60d8a (ssi: Convert last use of ssi_create_slave_no_init() manually) 25/58 Checking commit 7a38216fb33c (ssi: ssi_create_slave_no_init() is now unused, drop) 26/58 Checking commit 0869d6ba1a73 (usb: New usb_new(), usb_realize_and_unref()) 27/58 Checking commit 2119f64c2ca3 (usb: Convert uses of usb_create()) 28/58 Checking commit 044a4d6cba59 (usb: usb_create() is now unused, drop) 29/58 Checking commit b29fdb68432b (usb: Eliminate usb_try_create_simple()) 30/58 Checking commit 4302b25bd6b4 (qdev: qdev_create(), qdev_try_create() are now unused, drop) 31/58 Checking commit ad1d6ea181fc (auxbus: Rename aux_init_bus() to aux_bus_init()) 32/58 Checking commit ffced2a78cb6 (auxbus: New aux_bus_realize(), pairing with aux_bus_init()) 33/58 Checking commit cfce60963ab9 (auxbus: Convert a use of qdev_set_parent_bus()) 34/58 Checking commit 71344e4c5afe (auxbus: Eliminate aux_create_slave()) 35/58 Checking commit 248945e450af (qom: Tidy up a few object_initialize_child() calls) 36/58 Checking commit 94f09a87da15 (qom: Less verbose object_initialize_child()) 37/58 Checking commit 8bb71b7a9fcd (macio: Convert use of qdev_set_parent_bus()) 38/58 Checking commit d944eab8a07b (macio: Eliminate macio_init_child_obj()) 39/58 Checking commit 23fad3cc341b (sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls) WARNING: line over 80 characters #144: FILE: hw/arm/aspeed_ast2600.c:221: + &s->emmc.slots[0], sizeof(s->emmc.slots[0]), TYPE_SYSBUS_SDHCI); total: 0 errors, 1 warnings, 238 lines checked Patch 39/58 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/58 Checking commit 50a9e3b3366d (microbit: Tidy up sysbus_init_child_obj() @child argument) 41/58 Checking commit 982e9790fd59 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1) 42/58 Checking commit e347c204888d (hw/arm/armsse: Pass correct child size to sysbus_init_child_obj()) 43/58 Checking commit 8004fcea39f3 (sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2) 44/58 Checking commit 0a365131a1e3 (sysbus: New sysbus_realize(), sysbus_realize_and_unref()) 45/58 Checking commit 99093fa93c79 (sysbus: Convert to sysbus_realize() etc. with Coccinelle) 46/58 Checking commit 452882cdb7f1 (qdev: Drop qdev_realize() support for null bus) 47/58 Checking commit e2a4e40c0531 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1) 48/58 Checking commit 17b4e1066a39 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2) 49/58 Checking commit eaeff1393910 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3) 50/58 Checking commit 0f6c4002d974 (sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4) 51/58 Checking commit bf24af33dc68 (sysbus: sysbus_init_child_obj() is now unused, drop) 52/58 Checking commit 35263dc00779 (microbit: Eliminate two local variables in microbit_init()) 53/58 Checking commit 2b3a89646588 (s390x/event-facility: Simplify creation of SCLP event devices) 54/58 Checking commit 508be87c6a2a (qdev: Make qdev_realize() support bus-less devices) 55/58 Checking commit e3ec37da1165 (qdev: Use qdev_realize() in qdev_device_add()) 56/58 Checking commit c587de1554de (qdev: Convert bus-less devices to qdev_realize() with Coccinelle) 57/58 Checking commit e12f9a955afa (qdev: qdev_init_nofail() is now unused, drop) 58/58 Checking commit d7ba4cbc8d3d (MAINTAINERS: Make section QOM cover hw/core/*bus.c as well) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200529134523.8477-1-armbru@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Paolo recently suggested "to move the bus argument (and thus qdev_set_parent_bus) to qdev_init"[1], and that it "would be quite large but hopefully scriptable"[2]. Nerd sniped! The series is big, but at least the bigger patches are all mechanical. It is based on my "[PATCH 00/24] Fixes around device realization". I'm abstaining from cc'ing maintainers on mechanical conversions. I still cc: for patches I deem interesting, with related patches thrown in for context. Let me know if you think I should cc: more widely. PATCH 01-03 Preliminary cleanup PATCH 04 New qdev infrastructure Commit message explains why the current state is problematic, and how my work improves it. PATCH 05-12 Convert direct users of qdev PATCH 13-17 Convert PCI PATCH 18-21 Convert ISA PATCH 22-25 Convert SSI PATCH 26-29 Convert USB PATCH 30 Garbage collection PATCH 31-34 Convert aux-bus PATCH 35-42 Clean up around child device initialization PATCH 43-52 Convert sysbus PATCH 53 Stop pretending recursive realization is about to become real PATCH 54-56 Convert bus-less devices PATCH 57 Garbage collection PATCH 58 Maintain MAINTAINERS Enjoy! v2: * Rebased * PATCH 02+03: Old PATCH 02 is actually a revert, replace by propert reverts [Philippe] * PATCH 04: - Fix pasto [Alistair] - Rephrase qdev_realize_and_unref()'s contract [Paolo] - qdev_realize() passes on realize error unprefixed (because prefixes can pile up) * PATCH 08: Drop unwanted code motion [Paolo] * PATCH 09: - Make the Coccinelle script safer; output unchanged [Paolo] - Delete a Coccinelle rule that due to rebase applies just once; move its code changes (hw/char/serial.c, hw/display/ati.c, half of hw/display/sm501.c) to the next patch - Move changes to hw/arm/highbank.c to next patch, where they belong * PATCH 31: New [Philippe] * PATCH 32: Rename aux_realize_bus() to aux_bus_realize() [Philippe] * PATCH 47: &dev->parent_obj doesn't work after rebase, use SYS_BUS_DEVICE(dev) instead * PATCH 52: New [Philippe] * PATCH 53: Clean up on realize error [David] * PATCH 54: Don't restrict qdev_realize_and_unref() to non-null bus [Paolo] [1] Subject: Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse? Date: Mon, 4 May 2020 16:58:54 +0200 Message-ID: <6fc8633a-6d91-b83a-e6cd-5f714ccaf9ea@redhat.com> [2] Subject: Re: Infinite loop in bus_unparent(), qdev bug or qdev misuse? Date: Tue, 5 May 2020 18:26:57 +0200 Message-ID: <a4df3ba3-4759-56ac-68f8-f75eea93e27e@redhat.com> Cc: Paolo Bonzini <pbonzini@redhat.com> Cc: Daniel P. Berrange <berrange@redhat.com> Cc: Eduardo Habkost <ehabkost@redhat.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> Cc: Alistair Francis <alistair@alistair23.me> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk> Cc: David Gibson <david@gibson.dropbear.id.au> Markus Armbruster (58): qdev: Rename qbus_realize() to qbus_init() Revert "hw/prep: realize the PCI root bus as part of the prep init" Revert "hw/versatile: realize the PCI root bus as part of the versatile init" qdev: New qdev_new(), qdev_realize(), etc. qdev: Put qdev_new() to use with Coccinelle qdev: Convert to qbus_realize(), qbus_unrealize() qdev: Convert to qdev_unrealize() with Coccinelle qdev: Convert to qdev_unrealize() manually qdev: Convert uses of qdev_create() with Coccinelle qdev: Convert uses of qdev_create() manually qdev: Convert uses of qdev_set_parent_bus() with Coccinelle qdev: Convert uses of qdev_set_parent_bus() manually pci: New pci_new(), pci_realize_and_unref() etc. hw/ppc: Eliminate two superfluous QOM casts pci: Convert uses of pci_create() etc. with Coccinelle pci: Convert uses of pci_create() etc. manually pci: pci_create(), pci_create_multifunction() are now unused, drop isa: New isa_new(), isa_realize_and_unref() etc. isa: Convert uses of isa_create() with Coccinelle isa: Convert uses of isa_create(), isa_try_create() manually isa: isa_create(), isa_try_create() are now unused, drop ssi: ssi_auto_connect_slaves() never does anything, drop ssi: Convert uses of ssi_create_slave_no_init() with Coccinelle ssi: Convert last use of ssi_create_slave_no_init() manually ssi: ssi_create_slave_no_init() is now unused, drop usb: New usb_new(), usb_realize_and_unref() usb: Convert uses of usb_create() usb: usb_create() is now unused, drop usb: Eliminate usb_try_create_simple() qdev: qdev_create(), qdev_try_create() are now unused, drop auxbus: Rename aux_init_bus() to aux_bus_init() auxbus: New aux_bus_realize(), pairing with aux_bus_init() auxbus: Convert a use of qdev_set_parent_bus() auxbus: Eliminate aux_create_slave() qom: Tidy up a few object_initialize_child() calls qom: Less verbose object_initialize_child() macio: Convert use of qdev_set_parent_bus() macio: Eliminate macio_init_child_obj() sysbus: Drop useless OBJECT() in sysbus_init_child_obj() calls microbit: Tidy up sysbus_init_child_obj() @child argument sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 1 hw/arm/armsse: Pass correct child size to sysbus_init_child_obj() sysbus: Tidy up sysbus_init_child_obj()'s @childsize arg, part 2 sysbus: New sysbus_realize(), sysbus_realize_and_unref() sysbus: Convert to sysbus_realize() etc. with Coccinelle qdev: Drop qdev_realize() support for null bus sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 1 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 2 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 3 sysbus: Convert qdev_set_parent_bus() use with Coccinelle, part 4 sysbus: sysbus_init_child_obj() is now unused, drop microbit: Eliminate two local variables in microbit_init() s390x/event-facility: Simplify creation of SCLP event devices qdev: Make qdev_realize() support bus-less devices qdev: Use qdev_realize() in qdev_device_add() qdev: Convert bus-less devices to qdev_realize() with Coccinelle qdev: qdev_init_nofail() is now unused, drop MAINTAINERS: Make section QOM cover hw/core/*bus.c as well hw/lm32/lm32.h | 13 +- hw/lm32/milkymist-hw.h | 37 ++--- include/hw/audio/pcspk.h | 5 +- include/hw/char/cadence_uart.h | 5 +- include/hw/char/cmsdk-apb-uart.h | 4 +- include/hw/char/pl011.h | 9 +- include/hw/char/xilinx_uartlite.h | 4 +- include/hw/cris/etraxfs.h | 4 +- include/hw/isa/isa.h | 5 +- include/hw/misc/auxbus.h | 18 +-- include/hw/misc/unimp.h | 5 +- include/hw/net/ne2000-isa.h | 5 +- include/hw/pci/pci.h | 6 +- include/hw/qdev-core.h | 13 +- include/hw/ssi/ssi.h | 5 - include/hw/sysbus.h | 19 +-- include/hw/timer/cmsdk-apb-timer.h | 4 +- include/hw/timer/i8254.h | 9 +- include/hw/usb.h | 6 +- include/qom/object.h | 30 +++- hw/acpi/pcihp.c | 2 +- hw/acpi/piix4.c | 6 +- hw/alpha/typhoon.c | 4 +- hw/arm/allwinner-a10.c | 50 +++---- hw/arm/allwinner-h3.c | 57 +++----- hw/arm/armsse.c | 174 +++++++++-------------- hw/arm/armv7m.c | 12 +- hw/arm/aspeed.c | 18 ++- hw/arm/aspeed_ast2600.c | 110 ++++++-------- hw/arm/aspeed_soc.c | 84 +++++------ hw/arm/bcm2835_peripherals.c | 71 ++++----- hw/arm/bcm2836.c | 17 +-- hw/arm/cubieboard.c | 6 +- hw/arm/digic.c | 16 +-- hw/arm/digic_boards.c | 2 +- hw/arm/exynos4210.c | 48 +++---- hw/arm/exynos4_boards.c | 11 +- hw/arm/fsl-imx25.c | 64 ++++----- hw/arm/fsl-imx31.c | 43 +++--- hw/arm/fsl-imx6.c | 76 ++++------ hw/arm/fsl-imx6ul.c | 105 +++++--------- hw/arm/fsl-imx7.c | 100 +++++-------- hw/arm/highbank.c | 28 ++-- hw/arm/imx25_pdk.c | 10 +- hw/arm/integratorcp.c | 6 +- hw/arm/kzm.c | 5 +- hw/arm/mcimx6ul-evk.c | 7 +- hw/arm/mcimx7d-sabre.c | 7 +- hw/arm/microbit.c | 22 ++- hw/arm/mps2-tz.c | 79 +++++----- hw/arm/mps2.c | 26 ++-- hw/arm/msf2-soc.c | 25 ++-- hw/arm/msf2-som.c | 12 +- hw/arm/musca.c | 60 ++++---- hw/arm/musicpal.c | 8 +- hw/arm/netduino2.c | 4 +- hw/arm/netduinoplus2.c | 4 +- hw/arm/nrf51_soc.c | 30 ++-- hw/arm/nseries.c | 8 +- hw/arm/omap1.c | 16 +-- hw/arm/omap2.c | 16 +-- hw/arm/orangepi.c | 6 +- hw/arm/pxa2xx.c | 8 +- hw/arm/pxa2xx_gpio.c | 5 +- hw/arm/pxa2xx_pic.c | 5 +- hw/arm/raspi.c | 10 +- hw/arm/realview.c | 22 +-- hw/arm/sabrelite.c | 6 +- hw/arm/sbsa-ref.c | 26 ++-- hw/arm/spitz.c | 4 +- hw/arm/stellaris.c | 12 +- hw/arm/stm32f205_soc.c | 34 ++--- hw/arm/stm32f405_soc.c | 45 +++--- hw/arm/strongarm.c | 9 +- hw/arm/versatilepb.c | 18 +-- hw/arm/vexpress.c | 18 +-- hw/arm/virt.c | 38 ++--- hw/arm/xilinx_zynq.c | 44 +++--- hw/arm/xlnx-versal-virt.c | 15 +- hw/arm/xlnx-versal.c | 53 +++---- hw/arm/xlnx-zcu102.c | 26 ++-- hw/arm/xlnx-zynqmp.c | 92 +++++------- hw/audio/intel-hda.c | 4 +- hw/block/fdc.c | 16 +-- hw/block/nand.c | 4 +- hw/block/pflash_cfi01.c | 4 +- hw/block/pflash_cfi02.c | 4 +- hw/block/xen-block.c | 4 +- hw/char/exynos4210_uart.c | 5 +- hw/char/mcf_uart.c | 5 +- hw/char/parallel-isa.c | 5 +- hw/char/serial-isa.c | 9 +- hw/char/serial-pci-multi.c | 8 +- hw/char/serial-pci.c | 7 +- hw/char/serial.c | 14 +- hw/char/spapr_vty.c | 4 +- hw/core/bus.c | 23 ++- hw/core/cpu.c | 2 +- hw/core/empty_slot.c | 5 +- hw/core/qdev.c | 128 ++++++++--------- hw/core/sysbus.c | 27 ++-- hw/cpu/a15mpcore.c | 5 +- hw/cpu/a9mpcore.c | 23 ++- hw/cpu/arm11mpcore.c | 18 ++- hw/cpu/realview_mpcore.c | 10 +- hw/cris/axis_dev88.c | 4 +- hw/display/ati.c | 5 +- hw/display/milkymist-tmu2.c | 4 +- hw/display/sm501.c | 13 +- hw/display/virtio-gpu-pci.c | 3 +- hw/display/virtio-vga.c | 3 +- hw/display/xlnx_dp.c | 13 +- hw/dma/i8257.c | 9 +- hw/dma/pxa2xx_dma.c | 8 +- hw/dma/rc4030.c | 5 +- hw/dma/sparc32_dma.c | 16 +-- hw/dma/xilinx_axidma.c | 9 +- hw/hppa/dino.c | 4 +- hw/hppa/lasi.c | 4 +- hw/hppa/machine.c | 4 +- hw/hyperv/hyperv.c | 2 +- hw/i2c/core.c | 5 +- hw/i2c/smbus_eeprom.c | 4 +- hw/i386/amd_iommu.c | 3 +- hw/i386/pc.c | 12 +- hw/i386/pc_q35.c | 14 +- hw/i386/pc_sysfw.c | 4 +- hw/i386/x86.c | 8 +- hw/ide/isa.c | 5 +- hw/ide/microdrive.c | 3 +- hw/ide/qdev.c | 4 +- hw/intc/armv7m_nvic.c | 15 +- hw/intc/exynos4210_gic.c | 5 +- hw/intc/i8259_common.c | 5 +- hw/intc/pnv_xive.c | 10 +- hw/intc/realview_gic.c | 4 +- hw/intc/s390_flic.c | 6 +- hw/intc/spapr_xive.c | 10 +- hw/intc/xics.c | 2 +- hw/intc/xive.c | 2 +- hw/isa/isa-bus.c | 27 ++-- hw/isa/isa-superio.c | 20 +-- hw/isa/piix4.c | 3 +- hw/isa/vt82c686.c | 13 +- hw/m68k/mcf5208.c | 4 +- hw/m68k/mcf_intc.c | 5 +- hw/m68k/next-cube.c | 12 +- hw/m68k/q800.c | 36 ++--- hw/microblaze/petalogix_ml605_mmu.c | 26 ++-- hw/microblaze/petalogix_s3adsp1800_mmu.c | 14 +- hw/microblaze/xlnx-zynqmp-pmu.c | 21 ++- hw/mips/boston.c | 14 +- hw/mips/cps.c | 20 ++- hw/mips/fuloong2e.c | 6 +- hw/mips/gt64xxx_pci.c | 5 +- hw/mips/jazz.c | 16 +-- hw/mips/malta.c | 10 +- hw/mips/mipssim.c | 8 +- hw/misc/auxbus.c | 20 +-- hw/misc/mac_via.c | 14 +- hw/misc/macio/cuda.c | 8 +- hw/misc/macio/macio.c | 56 +++----- hw/misc/macio/pmu.c | 8 +- hw/net/etraxfs_eth.c | 4 +- hw/net/fsl_etsec/etsec.c | 5 +- hw/net/lan9118.c | 5 +- hw/net/lasi_i82596.c | 5 +- hw/net/smc91c111.c | 5 +- hw/net/spapr_llan.c | 4 +- hw/net/xilinx_axienet.c | 9 +- hw/nios2/10m50_devboard.c | 12 +- hw/nvram/fw_cfg.c | 8 +- hw/openrisc/openrisc_sim.c | 8 +- hw/pci-bridge/dec.c | 6 +- hw/pci-bridge/pci_expander_bridge.c | 8 +- hw/pci-host/bonito.c | 9 +- hw/pci-host/designware.c | 6 +- hw/pci-host/gpex.c | 6 +- hw/pci-host/i440fx.c | 4 +- hw/pci-host/pnv_phb3.c | 21 ++- hw/pci-host/pnv_phb4.c | 11 +- hw/pci-host/pnv_phb4_pec.c | 8 +- hw/pci-host/prep.c | 7 +- hw/pci-host/q35.c | 6 +- hw/pci-host/sabre.c | 13 +- hw/pci-host/versatile.c | 4 +- hw/pci-host/xilinx-pcie.c | 6 +- hw/pci/pci.c | 31 ++-- hw/pci/pcie.c | 2 +- hw/pci/shpc.c | 2 +- hw/pcmcia/pxa2xx.c | 5 +- hw/ppc/e500.c | 32 ++--- hw/ppc/mac_newworld.c | 46 +++--- hw/ppc/mac_oldworld.c | 26 ++-- hw/ppc/pnv.c | 103 ++++++-------- hw/ppc/pnv_bmc.c | 2 +- hw/ppc/pnv_core.c | 2 +- hw/ppc/pnv_psi.c | 10 +- hw/ppc/ppc440_uc.c | 8 +- hw/ppc/prep.c | 35 +++-- hw/ppc/sam460ex.c | 4 +- hw/ppc/spapr.c | 27 ++-- hw/ppc/spapr_cpu_core.c | 2 +- hw/ppc/spapr_drc.c | 2 +- hw/ppc/spapr_iommu.c | 2 +- hw/ppc/spapr_irq.c | 6 +- hw/ppc/spapr_pci.c | 3 +- hw/ppc/spapr_vio.c | 4 +- hw/ppc/virtex_ml507.c | 9 +- hw/riscv/riscv_hart.c | 7 +- hw/riscv/sifive_clint.c | 5 +- hw/riscv/sifive_e.c | 20 +-- hw/riscv/sifive_e_prci.c | 5 +- hw/riscv/sifive_plic.c | 5 +- hw/riscv/sifive_test.c | 5 +- hw/riscv/sifive_u.c | 52 +++---- hw/riscv/spike.c | 21 ++- hw/riscv/virt.c | 15 +- hw/rtc/m48t59-isa.c | 7 +- hw/rtc/m48t59.c | 5 +- hw/rtc/mc146818rtc.c | 4 +- hw/rtc/sun4v-rtc.c | 5 +- hw/s390x/ap-bridge.c | 4 +- hw/s390x/css-bridge.c | 6 +- hw/s390x/event-facility.c | 64 ++++----- hw/s390x/s390-pci-bus.c | 8 +- hw/s390x/s390-skeys.c | 2 +- hw/s390x/s390-stattrib.c | 2 +- hw/s390x/s390-virtio-ccw.c | 16 +-- hw/s390x/sclp.c | 12 +- hw/s390x/tod.c | 2 +- hw/s390x/vhost-vsock-ccw.c | 3 +- hw/s390x/virtio-ccw-9p.c | 3 +- hw/s390x/virtio-ccw-balloon.c | 3 +- hw/s390x/virtio-ccw-blk.c | 3 +- hw/s390x/virtio-ccw-crypto.c | 3 +- hw/s390x/virtio-ccw-gpu.c | 3 +- hw/s390x/virtio-ccw-input.c | 3 +- hw/s390x/virtio-ccw-net.c | 3 +- hw/s390x/virtio-ccw-rng.c | 3 +- hw/s390x/virtio-ccw-scsi.c | 6 +- hw/s390x/virtio-ccw-serial.c | 3 +- hw/scsi/scsi-bus.c | 4 +- hw/scsi/spapr_vscsi.c | 4 +- hw/sd/aspeed_sdhci.c | 2 +- hw/sd/milkymist-memcard.c | 4 +- hw/sd/pxa2xx_mmci.c | 8 +- hw/sd/ssi-sd.c | 4 +- hw/sh4/r2d.c | 12 +- hw/sparc/leon3.c | 20 +-- hw/sparc/sun4m.c | 64 ++++----- hw/sparc64/sun4u.c | 50 ++++--- hw/ssi/aspeed_smc.c | 1 - hw/ssi/imx_spi.c | 2 - hw/ssi/mss-spi.c | 1 - hw/ssi/ssi.c | 43 +----- hw/ssi/xilinx_spi.c | 1 - hw/ssi/xilinx_spips.c | 4 - hw/usb/bus.c | 52 +++---- hw/usb/dev-serial.c | 4 +- hw/virtio/vhost-scsi-pci.c | 3 +- hw/virtio/vhost-user-blk-pci.c | 3 +- hw/virtio/vhost-user-fs-pci.c | 3 +- hw/virtio/vhost-user-scsi-pci.c | 3 +- hw/virtio/vhost-vsock-pci.c | 3 +- hw/virtio/virtio-9p-pci.c | 3 +- hw/virtio/virtio-balloon-pci.c | 3 +- hw/virtio/virtio-blk-pci.c | 3 +- hw/virtio/virtio-crypto-pci.c | 3 +- hw/virtio/virtio-input-pci.c | 3 +- hw/virtio/virtio-iommu-pci.c | 3 +- hw/virtio/virtio-net-pci.c | 3 +- hw/virtio/virtio-pmem-pci.c | 3 +- hw/virtio/virtio-rng-pci.c | 3 +- hw/virtio/virtio-scsi-pci.c | 3 +- hw/virtio/virtio-serial-pci.c | 3 +- hw/virtio/virtio.c | 5 +- hw/xen/xen-bus.c | 4 +- hw/xen/xen-legacy-backend.c | 7 +- hw/xtensa/virt.c | 4 +- hw/xtensa/xtfpga.c | 8 +- migration/migration.c | 2 +- qdev-monitor.c | 8 +- qom/object.c | 19 ++- target/i386/cpu.c | 3 +- tests/test-qdev-global-props.c | 9 +- MAINTAINERS | 2 + 287 files changed, 1956 insertions(+), 2372 deletions(-)