| Message ID | 20201215001312.3120777-1-wuhaotsh@google.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Additional NPCM7xx devices | expand |
On Mon, Dec 14, 2020 at 4:13 PM Hao Wu <wuhaotsh@google.com> wrote: > This patch series include a few more NPCM7XX devices including > > - Analog Digital Converter (ADC) > - Pulse Width Modulation (PWM) > > We also modified the CLK module to generate clock values using qdev_clock. > These clocks are used to determine various clocks in NPCM7XX devices. > > Thank you for your review. > > Changes since v2: > - Split PWM test into a separate patch in the patch set > - Add trace events for PWM's update_freq/update_duty > - Add trace events for ioread/iowrite in ADC and PWM > - Use timer_get_ns in hw/timer/npcm7xx_timer.c > - Update commit message in ADC/PWM to mention qom-get/set method for usage > - Fix typos > > Changes since v1: > - We removed the IPMI and KCS related code from this patch set. > > Hao Wu (5): > hw/misc: Add clock converter in NPCM7XX CLK module > hw/timer: Refactor NPCM7XX Timer to use CLK clock > hw/adc: Add an ADC module for NPCM7XX > hw/misc: Add a PWM module for NPCM7XX > hw/misc: Add QTest for NPCM7XX PWM Module > > docs/system/arm/nuvoton.rst | 4 +- > hw/adc/meson.build | 1 + > hw/adc/npcm7xx_adc.c | 321 +++++++++++++ > hw/adc/trace-events | 5 + > hw/arm/npcm7xx.c | 55 ++- > hw/misc/meson.build | 1 + > hw/misc/npcm7xx_clk.c | 795 ++++++++++++++++++++++++++++++- > hw/misc/npcm7xx_pwm.c | 559 ++++++++++++++++++++++ > hw/misc/trace-events | 6 + > hw/timer/npcm7xx_timer.c | 23 +- > include/hw/adc/npcm7xx_adc.h | 72 +++ > include/hw/arm/npcm7xx.h | 4 + > include/hw/misc/npcm7xx_clk.h | 146 +++++- > include/hw/misc/npcm7xx_pwm.h | 106 +++++ > include/hw/timer/npcm7xx_timer.h | 1 + > meson.build | 1 + > tests/qtest/meson.build | 4 +- > tests/qtest/npcm7xx_adc-test.c | 400 ++++++++++++++++ > tests/qtest/npcm7xx_pwm-test.c | 490 +++++++++++++++++++ > 19 files changed, 2964 insertions(+), 30 deletions(-) > create mode 100644 hw/adc/npcm7xx_adc.c > create mode 100644 hw/adc/trace-events > create mode 100644 hw/misc/npcm7xx_pwm.c > create mode 100644 include/hw/adc/npcm7xx_adc.h > create mode 100644 include/hw/misc/npcm7xx_pwm.h > create mode 100644 tests/qtest/npcm7xx_adc-test.c > create mode 100644 tests/qtest/npcm7xx_pwm-test.c > > -- > 2.29.2.684.gfbc64c5ab5-goog > >
On 12/15/20 1:13 AM, Hao Wu via wrote: > This patch series include a few more NPCM7XX devices including > > - Analog Digital Converter (ADC) > - Pulse Width Modulation (PWM) > > We also modified the CLK module to generate clock values using qdev_clock. > These clocks are used to determine various clocks in NPCM7XX devices. > > Thank you for your review. The list is still rewriting your author ident. Maybe try 'git-format-patch --from' next time to force it on each patch? Regards, Phil.
Thanks for the tip! I'll use that in the future. Best, Hao On Tue, Dec 15, 2020 at 7:17 AM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote: > On 12/15/20 1:13 AM, Hao Wu via wrote: > > This patch series include a few more NPCM7XX devices including > > > > - Analog Digital Converter (ADC) > > - Pulse Width Modulation (PWM) > > > > We also modified the CLK module to generate clock values using > qdev_clock. > > These clocks are used to determine various clocks in NPCM7XX devices. > > > > Thank you for your review. > > The list is still rewriting your author ident. > > Maybe try 'git-format-patch --from' next time to force it > on each patch? > > Regards, > > Phil. >